Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <81686bc4-c580-862b-1c29-51b34e419154@nvidia.com>
Date:   Mon, 11 Apr 2022 20:32:40 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [Patch v6 3/4] dt-bindings: memory: Update reg maxitems for
 tegra186
Content-Language: en-US
To:     Dmitry Osipenko <digetx@gmail.com>, krzysztof.kozlowski@linaro.org,
        thierry.reding@gmail.com, jonathanh@nvidia.com, robh+dt@kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc:     vdumpa@nvidia.com, Snikam@nvidia.com
References: <20220406052459.10438-1-amhetre@nvidia.com>
 <20220406052459.10438-4-amhetre@nvidia.com>
 <3e044f9e-3200-bb26-897d-1977e3825c92@gmail.com>
From:   Ashish Mhetre <amhetre@nvidia.com>
In-Reply-To: <3e044f9e-3200-bb26-897d-1977e3825c92@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHBRY05DVHBLOG9Qb1FHNXUxTmdMVzhkbitTZGVidXNKcFB3eTFiVlloZTJa?=
 =?utf-8?B?eFZQdXEvSWdpQUdDd25rWnMrSmtBNUN1QU4wWGJIWVRkWnY0Vi9iSFM4a0Ur?=
 =?utf-8?B?ODRxNmM2a2J6eDNjdmxJMURhYndvbjZ4RnlYUXN5WXlweWRUK2dXeUhSSSsx?=
 =?utf-8?B?SitHaEZST2d0OHFUUU9DMmsvelViVDVmeGRtVFBTNlBzVm5VdU0zcFlSb3RL?=
 =?utf-8?B?bVRKakhWRndVakRGZEt5NE5YSWNmMnVLamVucE4vTE14NisxRytxVGx6SjhU?=
 =?utf-8?B?TG5yYVRHaUJodXU2cmR4bTAwdmcraUxZcFQ1OVZnUnhycXovV2hoZzQ2L296?=
 =?utf-8?B?elBSN21RbDBnbDdBblFibTJoODZQZFNXNWhQRzBBZC9xTTM0YTJiM3FCUUZX?=
 =?utf-8?B?N2luNFN1Q3ZlRjkvZ0U3SE9MeW5BOWUrckUyQlZqRHN2akxaK2Iydm1JQjlC?=
 =?utf-8?B?RzJSRUwxRm5zdldyZjZhaEhkOGJqV1NKaHlrQlFSalZTK25jTXl2Z0NmcUh3?=
 =?utf-8?B?aVd0TXVUMSs4VWJMK1JMWW1WWkEyaDUveHdGay9JVloyRlRSYURqbWtCazdW?=
 =?utf-8?B?NFhkdHJWK25qZHRoVnhmdHVKZkRqMmV1T2J4MGsrVnFWY1VhRUtiU2JiODN6?=
 =?utf-8?B?eFhYNVRqS0pWcmF2U2NSdG1GbzNobXJRS0l1cGtPYW5YaUdYb1VUWWNYYmRk?=
 =?utf-8?B?a1NuMVBVWGhqWi9TSTZyWklUQ0hNMi8vZlJRaWpHZndkdmVwK09ickhjV1dq?=
 =?utf-8?B?ZHhOSHBFRjBVQ3E2eXpCVTQyeGJucGxvbkE2TUZMRDhLNmpQMmxIQXpnZGUw?=
 =?utf-8?B?QWREbVcxZHhKMUx0clhpUEhYd1lCOVpjQUNLYXNpWVZIMys0azVFbkJhcHNP?=
 =?utf-8?B?WXErdENON2ZKODVtUDhSNVdGaklDZzBiY1lFVGtJUW5NTWdQdkRxbG5iZWZH?=
 =?utf-8?B?Y1l6ZVNVU2xTWEZlSkQ4enN2RlliMDZxTmpSK0VYM29EYVA2d25NeUVJQlNH?=
 =?utf-8?B?SG5hRnRtdWUwZWR4QVlVbTBadjdzUXNsZGNVU2plbU5WaUlZTXc4Ty9oWnh2?=
 =?utf-8?B?TEorQkJzbks3eGZ2T0kwVUlSclhKZDFwdExBWG9BSm5xSXFVUTBxNUhydWdQ?=
 =?utf-8?B?c0RTK3pCby9qMEQyeUowL0kyVm5Cc0hadHhHcVllRUMvUmRyd1h2TlRLWEU4?=
 =?utf-8?B?WDF5YjJacXE5a0RIT1RlWUdzc0hNNUVYclk2ZDArSDR6Mi9CdkFnZWY3TUU3?=
 =?utf-8?B?a1BKZHBpckZoNVZBdXEwTFBjazhYWW1SQXVKUGFkVUdTVVNhN1BRWVRWcWtJ?=
 =?utf-8?B?dHB5RWZiWWpRMnpkU1pBdDRtcGlyM1VNSjNpelNLUWpNOXNMN2p2Qmo5Ykxk?=
 =?utf-8?B?dDR4NWxoV2MveGpiVlV0SXJRT2h4Z2g3MmRDdmlTQ0Noamk4NnBNcXFlamFJ?=
 =?utf-8?B?eUxabGQ3TGR0KzlQQjl0YUtJSkhHY3dncXU3MXg0QVJ1Z1l6TWY2VmdZdjVK?=
 =?utf-8?B?dEpEc0M2ajAvMW4xWDdPQjY0UmFoRXNLWE1YZXV6cG0zTGxPYldldTZpVm9F?=
 =?utf-8?B?ZFJsZWlWT1N1NGIzNWh4TmZUckFqcSthQXQxbTZoSUg3UVViaG9hNHhIL1RU?=
 =?utf-8?B?L1NsdTlUaG5zbTJ3Z3dWNVdqQ09TNmRIYlRSZlovVkRsOGhRY3JXNkEwTlA2?=
 =?utf-8?B?Tkp5NEc0YnV4ZHJmcTJLMUtYcGxrNk93S2ZNSVgzdjJpY1BxYW02YUdsVWE2?=
 =?utf-8?B?NE1rWG1NbEc1eHZXYk0rSDRzS20rMmxFVUhCNEdPS3NoY3NNb2hkdWRMbEx6?=
 =?utf-8?B?cWM2NXZrZTNOYndzcWQ1U1VxSktRaE9CR1JFeUhVQ2FDZFl5alBNT0pVMHpJ?=
 =?utf-8?B?ZlZpTFR6bDZiMGhRSVNIYUwweE9yM3FBbXZNcWVoZ3BCbEVja2svK1NRTzdh?=
 =?utf-8?B?VjNOTDNrVW13bFFBU3BrRnJFNHlGdENMdE9YMGZZOEZoMC9Ca0hTRGtXdVV1?=
 =?utf-8?B?dWtEVUVzS09VUWJMMXR0OXYvSzh1TGlYZVhRSkJWSmh1NEFDZWUxU2xHdWFW?=
 =?utf-8?B?MmNKSTR4QzJibC9ONlVUbHZTRUsvZEI5c3IySGxMVGlDRXZOVzVKYXo4Q0dr?=
 =?utf-8?B?WjIyVDEySTg0VDRKa1VSYVRzUmNjdWkvTk9Rb0N0bU5UM3dyUE1EMUhLU0FK?=
 =?utf-8?B?Y3dNMDJZNEk3dE9IcmtOUnlXTVlMakhPYmhlRkhKWDlYZ0o4d2ExWlpySitZ?=
 =?utf-8?B?RGcxekhwcGQxUUx1ZWhLMGp6TndEYzFpMTlER21MZURWclVSUXpaS1BiMzds?=
 =?utf-8?B?d0FqTWJiT1V0aFhUL3p3RXJEOVlDUXNieTI3STZJUHBFWlRYaTQzQT09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da5dff40-773d-4ae0-fca6-08da1bcc5af0
X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB4349.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 15:02:54.3711
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TD147+xxr97BP+e0ETG10YscxGmY+S3yqPMX4ngvsS8Z+aLSPpRAyFIY41HQP1xH+uKX0xjidhyhNVZm508M0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5851
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/10/2022 7:51 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
> 
> 
> 06.04.2022 08:24, Ashish Mhetre пишет:
>>           memory-controller@2c00000 {
>>               compatible = "nvidia,tegra186-mc";
>> -            reg = <0x0 0x02c00000 0x0 0xb0000>;
>> +            reg = <0x0 0x02c00000 0x0 0x10000>,    /* MC-SID */
>> +                  <0x0 0x02c10000 0x0 0x10000>,    /* Broadcast channel */
>> +                  <0x0 0x02c20000 0x0 0x10000>,    /* MC0 */
>> +                  <0x0 0x02c30000 0x0 0x10000>,    /* MC1 */
>> +                  <0x0 0x02c40000 0x0 0x10000>,    /* MC2 */
>> +                  <0x0 0x02c50000 0x0 0x10000>;    /* MC3 */
>> +            reg-names = "mc-sid", "mc-broadcast", "mc0", "mc1", "mc2", "mc3";
> 
> The "mc-" prefix feels redundant to me, I'd name the regs like this:
> 
>    "sid", "broadcast", "ch0", "ch1", "ch2", "ch3"
> 
> 
> You should also add validation of the regs/reg-names to the yaml based
> on SoC version. I.e. it's not enough to only bump the maxItems.

Okay, I will add validation of reg-names as following:

   reg-names:
     minItems: 0
     maxItems: 6
     items:
       - const: sid
       - const: broadcast
       - const: ch0
       - const: ch1
       - const: ch2
       - const: ch3


We will have to keep minItems to 0 in order to make it compatible with
old DT, right?