Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp52780pxb; Tue, 12 Apr 2022 16:34:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvJZ0J3Ngw0SvXdtPMElbwLJ7PJVc2h0DK+RrpN6RdlJSiCaF5TeV94t1x5KNosyK+RDcV X-Received: by 2002:a17:902:ea4f:b0:158:5013:1403 with SMTP id r15-20020a170902ea4f00b0015850131403mr15371953plg.75.1649806451141; Tue, 12 Apr 2022 16:34:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649806451; cv=none; d=google.com; s=arc-20160816; b=l1pI8e1NmQC+HyO6Ttg/YtirTEg1t0dpg1WvdBy/86uOb4IHnmNJM+YUsyiDntQi4d poU1bUCZG/7GnXJjBHZLkQVXatL6aOh/Ut2ZyBj6kgDtfxGwJFQ/jX6Y/rkUO0jJKRdS e9Yq7dDGlo2+HpihVVfvlIIfo3zUGSVaqU4De/QsaDgVm3f6eoZqeMHy1R348Fy6xQj6 CL+u+Odz26RnfjlN/P7aaYqYTVNwEEEda4w7BuPxaulLs1cyxavfP1+2Z0hCpdjZp0/c 3GUoOCeEpcM2QioT8LGko+zyU4BrLDEwP77QEVutnj150CozmWtbRZfHJqjFAfJAjLJw dK5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DbevLgUGb3AyNEz/IRzohhMjaLJebvQDvejFFUWU7Mc=; b=S5Mk30WazoiJoo/YTRV6KlyK6YP8Sd40C+b9eSww2+X69nt0bDTb8JsjqOB2rRU7/V Gzx51dqOMOTsSKDQBhlmPOLIuT4gVITKs4NnoqqYCBMHlUnZfI1ln58sJ+iBr1ep/TcL a5izKLM6UOA2GyYNW5BPAnouryvyXf6yJ78ozUUJ8izMz1eMKj2ttRy5o5j21edIRtOa u2CXvKiLeFzqPw8gFXjCIcm2k4+rvnTzes+OtJNWtQmITeT/r5ovEac4N8/JZvNuwYup qHf7uzHmBep9Yc52v0hrHHp/T+UQTy7Lxv+bW+EseUbygSfYZD2MppGgAK4cbmPoDba1 OX+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kofISyJl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q6-20020a170902f78600b001583bcdb540si10727921pln.155.2022.04.12.16.34.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 16:34:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kofISyJl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E975C10241D; Tue, 12 Apr 2022 14:25:03 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231226AbiDLGsb (ORCPT + 99 others); Tue, 12 Apr 2022 02:48:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351180AbiDLGoM (ORCPT ); Tue, 12 Apr 2022 02:44:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D66B39830; Mon, 11 Apr 2022 23:37:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E49E961902; Tue, 12 Apr 2022 06:37:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED668C385A1; Tue, 12 Apr 2022 06:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649745459; bh=Ur7rnRKD7I0yAumOWBGWGZkPPf4CPiK8FlaCdTnTWQw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kofISyJlfKaddVDd1GKP2sPnWzoI/7VF2c4xhhLY0zFkrpRvoEUwCTDD5LB3sH3rM qI8zSuXzmefpFstbZibeePGBgDYlYIFAQ/aVcZK/vMqLKI2FLJyJhy/xTt8alXXHve UYq2m+P/LDFd+Sa866BAPurQlhtHAPqfNlEh/q2E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geert Uytterhoeven , Christophe JAILLET , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.10 102/171] scsi: zorro7xx: Fix a resource leak in zorro7xx_remove_one() Date: Tue, 12 Apr 2022 08:29:53 +0200 Message-Id: <20220412062930.835918660@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062927.870347203@linuxfoundation.org> References: <20220412062927.870347203@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 16ed828b872d12ccba8f07bcc446ae89ba662f9c ] The error handling path of the probe releases a resource that is not freed in the remove function. In some cases, a ioremap() must be undone. Add the missing iounmap() call in the remove function. Link: https://lore.kernel.org/r/247066a3104d25f9a05de8b3270fc3c848763bcc.1647673264.git.christophe.jaillet@wanadoo.fr Fixes: 45804fbb00ee ("[SCSI] 53c700: Amiga Zorro NCR53c710 SCSI") Reviewed-by: Geert Uytterhoeven Signed-off-by: Christophe JAILLET Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/zorro7xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/zorro7xx.c b/drivers/scsi/zorro7xx.c index 27b9e2baab1a..7acf9193a9e8 100644 --- a/drivers/scsi/zorro7xx.c +++ b/drivers/scsi/zorro7xx.c @@ -159,6 +159,8 @@ static void zorro7xx_remove_one(struct zorro_dev *z) scsi_remove_host(host); NCR_700_release(host); + if (host->base > 0x01000000) + iounmap(hostdata->base); kfree(hostdata); free_irq(host->irq, host); zorro_release_device(z); -- 2.35.1