Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp53175pxb; Tue, 12 Apr 2022 16:34:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxX1ZcEz8EfbMuOK0YdNwpMaMrjdpbCZCIQ3ZtlOWGw0Gl5nDSftw2Xx9qo9IYceDbIET4Q X-Received: by 2002:a65:6e4d:0:b0:39d:a6ce:14dc with SMTP id be13-20020a656e4d000000b0039da6ce14dcmr2756511pgb.476.1649806494956; Tue, 12 Apr 2022 16:34:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649806494; cv=none; d=google.com; s=arc-20160816; b=HJQSZJtS/V1nvCQRm+OLJCMkzDhHCvt5yBXHnTOh8ie4gDNbUWgoyaookwg3TxArhv KvtjkijslxOsQE+PjidHXLwbcp20RN6ejog3+CLExSw4ME1MHuPCxgixib/SGqVs+Cf/ JeLvSeeBCe+emYkaJOag1/wBeKM7F0y7IReeQdhsd0Nj8DAUGmbr9yN8PgMbg+6vb9z+ Xnqno5xijRAxfOBrP4Ry9KKEmOVK2A4Q8tK+FYLLOdvpHmn/jMzFn6htEMTsXS6Co2S0 5sNcyYwzuAZ3I67qlO5bqxx4FSiv6/FJmQDKbflQDNlcEkivxJbCNpjYdDcJ/s7/3JDZ Au7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DbevLgUGb3AyNEz/IRzohhMjaLJebvQDvejFFUWU7Mc=; b=z20O7huU9gzDkC8azhyGa+AoqsZy+6vVqVePSO4qiHS+DZagDfXmRYsz3J/50LN+H/ I/XmXpxh3azRc65K1CTwzBoyStoAZNIQlLvN1nfyYWxzwv43KRXPrMp/QLAnifbSdSdV 1P4R8U5LQMRPpCyqY5FbgadTZXZEe4QFvgGZkznlXHPLXmnzJHdFdnPCoRGDGgHvRYDC Z1MKKOvqaXtVAtmsWyZFjX+zar2tGeORDqTfNgKkOTtftDNtBlEhS37oPFREZgT/qWmj aOouRaewY7F8/46/3bjd4wGREicxmCrCdNjaV2K7zGzjh/kUsfgDawjkylZ4L0K20Nva UfAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zdL8uc0V; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id b10-20020a65578a000000b003825f9cfbcasi4165444pgr.776.2022.04.12.16.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 16:34:54 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zdL8uc0V; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D092B1B4EBF; Tue, 12 Apr 2022 14:26:23 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352982AbiDLH5s (ORCPT + 99 others); Tue, 12 Apr 2022 03:57:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353552AbiDLHZq (ORCPT ); Tue, 12 Apr 2022 03:25:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 394F926573; Tue, 12 Apr 2022 00:01:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C8B4E60B2B; Tue, 12 Apr 2022 07:01:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0921C385A1; Tue, 12 Apr 2022 07:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649746885; bh=Ur7rnRKD7I0yAumOWBGWGZkPPf4CPiK8FlaCdTnTWQw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zdL8uc0V2AKBw4wKWjvpNrTD5itzkgaRDkgTeyHWJ0PsVSwo86Ax0XXUfo73v7pxi C86cJmiOEEC7lcokbcNKRd9tlWE6UTaOBAhmGMDyHR1hA/rf2HCRgtL+NX4KXY76gC FLBPZ9bjquMlIpeAEjLqk3chQheS/N083eWQv4Q0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geert Uytterhoeven , Christophe JAILLET , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.16 158/285] scsi: zorro7xx: Fix a resource leak in zorro7xx_remove_one() Date: Tue, 12 Apr 2022 08:30:15 +0200 Message-Id: <20220412062948.231550167@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062943.670770901@linuxfoundation.org> References: <20220412062943.670770901@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 16ed828b872d12ccba8f07bcc446ae89ba662f9c ] The error handling path of the probe releases a resource that is not freed in the remove function. In some cases, a ioremap() must be undone. Add the missing iounmap() call in the remove function. Link: https://lore.kernel.org/r/247066a3104d25f9a05de8b3270fc3c848763bcc.1647673264.git.christophe.jaillet@wanadoo.fr Fixes: 45804fbb00ee ("[SCSI] 53c700: Amiga Zorro NCR53c710 SCSI") Reviewed-by: Geert Uytterhoeven Signed-off-by: Christophe JAILLET Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/zorro7xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/zorro7xx.c b/drivers/scsi/zorro7xx.c index 27b9e2baab1a..7acf9193a9e8 100644 --- a/drivers/scsi/zorro7xx.c +++ b/drivers/scsi/zorro7xx.c @@ -159,6 +159,8 @@ static void zorro7xx_remove_one(struct zorro_dev *z) scsi_remove_host(host); NCR_700_release(host); + if (host->base > 0x01000000) + iounmap(hostdata->base); kfree(hostdata); free_irq(host->irq, host); zorro_release_device(z); -- 2.35.1