Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Apr 2022 16:20:49 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        <tony@atomide.com>
CC:     Devarsh Thakkar <devarsht@ti.com>, <linux-kernel@vger.kernel.org>,
        <jyri.sarha@iki.fi>, <tomba@kernel.org>, <airlied@linux.ie>,
        <daniel@ffwll.ch>, <dri-devel@lists.freedesktop.org>,
        <a-bhatia1@ti.com>, <r-ravikumar@ti.com>, <nikhil.nd@ti.com>,
        <linux-arm-kernel@lists.infradead.org>, <vigneshr@ti.com>,
        <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] drm/tidss: Soft Reset DISPC on startup
Message-ID: <20220412212049.gjnel7aubol56azk@earache>
References: <20220314113739.18000-1-devarsht@ti.com>
 <86a07099-1074-e8d1-6d0e-1ce68414b627@ideasonboard.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <86a07099-1074-e8d1-6d0e-1ce68414b627@ideasonboard.com>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 17:24-20220412, Tomi Valkeinen wrote:
> Hi,
> 
> On 14/03/2022 13:37, Devarsh Thakkar wrote:
> > Soft reset the display subsystem controller on startup and wait for
> > the reset to complete. This helps the scenario where display was
> > already in use by some other core before the linux was booted.
> 
> The reason the omapdrm doesn't do a reset is that the PM features on some of
> the DSS registers were set and controlled outside dss driver, so the dss
> driver could not do a reset just like that. That design was carried to the
> tidss driver, although I'm not sure if the reason is valid on AM6 and J7
> platforms.
> 
> If that reasoning is not valid, this patch is ok and:
> 
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> 

Tony - sysc control for older omap devices still control this directly?

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D