Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "Jankowski, Konrad0" <konrad0.jankowski@intel.com>
To:     "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "Lobakin, Alexandr" <alexandr.lobakin@intel.com>
CC:     ivecera <ivecera@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        mschmidt <mschmidt@redhat.com>,
        Brett Creeley <brett@pensando.io>,
        open list <linux-kernel@vger.kernel.org>,
        poros <poros@redhat.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net v2] ice: Fix incorrect locking in
 ice_vc_process_vf_msg()
Thread-Topic: [Intel-wired-lan] [PATCH net v2] ice: Fix incorrect locking in
 ice_vc_process_vf_msg()
Thread-Index: AQHYRbUMDJGo38dwqUSS7ixfLZwgCqzmEuQAgAAlZoCABe8vsA==
Date:   Tue, 12 Apr 2022 10:39:01 +0000
Message-ID: <SJ0PR11MB5629903816D77836D62E8EAEABED9@SJ0PR11MB5629.namprd11.prod.outlook.com>
References: <20220401104052.1711721-1-ivecera@redhat.com>
 <20220408134714.1834349-1-alexandr.lobakin@intel.com>
 <97c58b06-11b5-182b-eed2-e5a74824241c@intel.com>
In-Reply-To: <97c58b06-11b5-182b-eed2-e5a74824241c@intel.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
dlp-version: 11.6.401.20
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CYIXw9ReR6lUfkNqT/hrFb62n3MDMVEI4fU2KQjLizml1/AMrPiL2JS7yTND?=
 =?us-ascii?Q?lTZKsy5UH4WYt3InXXhrWNUQqQpKFqnCYz+HYvpB6E3AlCti/nArfnNxg2o5?=
 =?us-ascii?Q?MrFoQInxMfGlLl3IF+OkNYPZRThknqjpuCX/ML6iKrZ9bXJd3pSVooKQ9H9b?=
 =?us-ascii?Q?N6mdm3Ukzww1siDcRC3HJuXwYw538Ef2yn6PUnFXMsHxXnUMVahJGYmvfigy?=
 =?us-ascii?Q?/y6zdjnPznGnMlh/n7l1iTuVXqzGH2eEHrixWvfRBKa79THUzugimNF0LCYI?=
 =?us-ascii?Q?jkaF1wv7dkAG2Dq4UMs6jxHa4BdVWTvAqigs+JJfnt+WiR3g8bB7d4pfpOWA?=
 =?us-ascii?Q?+6tXT80MVl/I5rS8bVKrXWyjsVNSXfNSn2kpBk9Tyi0npYFVNWFXcAps82Ud?=
 =?us-ascii?Q?GNAqN8eQVNYtJKGkgvrgILCeY/PxqZzsJsgSrvUcKy5ixAjb7Cr6XCi/GM1Z?=
 =?us-ascii?Q?EzmWHvA+bFTZLd3MziYL5+b8qDAtgrwcI5bXnX7Ndqbfdcv0+dU0eiz+CSZJ?=
 =?us-ascii?Q?Wue3Mjim2Vysk7hwuHZzY62L3JpUT0Yw8telBbKxoVBpHauZGIjaOItvFpqT?=
 =?us-ascii?Q?UWyBYFzhG7K2bshxz66y11y5K7dbrId5OCEV0/aZ537pn5d6kuSGDk9QzwIC?=
 =?us-ascii?Q?oiUlnO+2tNa+0TAGIONi5eJS13Ti7RzB0h0cgz+8tqayLdDWen79JgOco46s?=
 =?us-ascii?Q?IYJXQ9DFTYpsQrGQbyp/ULs/6kXU1cYyXmMioqG20vncwAo2U1fLvLn/lT+w?=
 =?us-ascii?Q?YjlEPNXqDlZ36QqB5M5oiXw1uGx3O8lTgeDbrsEZWmx4Z4zmHeILSzqmjACU?=
 =?us-ascii?Q?wpT9uCpRM6PnCw04U2CtQT/SH3EEI3NLlokKW2byoB0QBVe/52rOgh6hvyPz?=
 =?us-ascii?Q?nxMqX9n5pGChFfxjdJ5gf5UayRWFuADUoxjihLmxBRk1H+8BatH13XeI7FJk?=
 =?us-ascii?Q?IV79gC4jpK1jJFTNQN4lU+hlpdoLfmOkbdUeaQLwwMnSOCWPfbsPpf5z8A8q?=
 =?us-ascii?Q?q2F0W/krJdGJMcEkbzKuBf2ll6mGwi8S8HkhdKN84CIFU7yBjOQT4TLbNOpz?=
 =?us-ascii?Q?x85G1zFRoB+hYyfZMm0ku0zCJWS4KDpUD2blYMDpa3tpDdSh6rfT4kIbYtaS?=
 =?us-ascii?Q?vA2RO9dlwn2/tyKrGxgWcN1gVXq+KL8fvvTsJMlqfqN6Zu5DZ8f2IwpvKgCb?=
 =?us-ascii?Q?wspIreYDeYp7Ct3853zh9UhZbGpTHHUBOzqx22b14Uq9CQ3wKo32fwxPjOr3?=
 =?us-ascii?Q?s7JkiMxzI2RP/HL8+HjQj3hPdd5mce07k3PKDZkt6vu4qe0IssaIWRW78E9f?=
 =?us-ascii?Q?uWG6SUaCBUJbooiCeBWbHWyvyZfezdiC0mWuACjM4xR7tnUfd788hkit6Yzu?=
 =?us-ascii?Q?3tn3C9T7vJRze3KA31XkJ7Bz+8nQHyHA356aUIR47vd5P+IpP1O+P9eQ/SQe?=
 =?us-ascii?Q?09oQSisA+TcdOWV4h7BSrHcWrohFgGWDxoZN51ddR6Z7gxB425fq8G5jzeHo?=
 =?us-ascii?Q?/ne3PcpRIzXUsQ1enC8dUC9dohCEwI9Pmfn8v+vqWf2NSkBs/+Olo7XgCU/b?=
 =?us-ascii?Q?nskXxiDd7D7QjZYp2XCSh5mDUYm0Czvrx/lp1PIG8/hniUXBIEm0uXSysO+X?=
 =?us-ascii?Q?IX7MmcKhk1sgSe6aRVe0cXdGZkfNnnpHiFM4EvMO6XXMVnUDgM/nlfLHKugA?=
 =?us-ascii?Q?5oB5Z4jP+CE+Mz9nuUlaLtJn18j6gyJjNHz8HPwUPe8bGXkrBrMLDDao9YmF?=
 =?us-ascii?Q?sVCWrvgQMQ3uod5bafPMc2AR12nn5yA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5629.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef331338-6d3b-4172-6e6f-08da1c70a8c8
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2022 10:39:01.8563
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: b+c3oqN7peStrDb5klrebqk/MtBjZ4aISwPK8skfpon2R6wH5IQxN7WbimAq43e7nfApRuxEpmKDpMQrfS+Iyb4okEAS+Hozhjjj2OzmMkE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1789
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Tony Nguyen
> Sent: Friday, April 8, 2022 6:01 PM
> To: Lobakin, Alexandr <alexandr.lobakin@intel.com>
> Cc: ivecera <ivecera@redhat.com>; netdev@vger.kernel.org; mschmidt
> <mschmidt@redhat.com>; Brett Creeley <brett@pensando.io>; open list
> <linux-kernel@vger.kernel.org>; poros <poros@redhat.com>; moderated
> list:INTEL ETHERNET DRIVERS <intel-wired-lan@lists.osuosl.org>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S.
> Miller <davem@davemloft.net>
> Subject: Re: [Intel-wired-lan] [PATCH net v2] ice: Fix incorrect locking =
in
> ice_vc_process_vf_msg()
>=20
>=20
> On 4/8/2022 6:47 AM, Alexander Lobakin wrote:
> > From: Ivan Vecera <ivecera@redhat.com>
> > Date: Fri,  1 Apr 2022 12:40:52 +0200
> >
> >> Usage of mutex_trylock() in ice_vc_process_vf_msg() is incorrect
> >> because message sent from VF is ignored and never processed.
> >>
> >> Use mutex_lock() instead to fix the issue. It is safe because this
> >> mutex is used to prevent races between VF related NDOs and handlers
> >> processing request messages from VF and these handlers are running in
> >> ice_service_task() context. Additionally move this mutex lock prior
> >> ice_vc_is_opcode_allowed() call to avoid potential races during
> >> allowlist acccess.
> >>
> >> Fixes: e6ba5273d4ed ("ice: Fix race conditions between virtchnl
> >> handling and VF ndo ops")
> >> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> > Hey Tony,
> >
> > I guess you missed this one due to being on a vacation previously.
> > It's been previously reviewed IIRC, could you take it into net-queue?
>=20
> I remember applying this but I don't see it on the tree so I must be mist=
aken.
> :( I'll get it applied, thanks for catching.
>=20
> -Tony
>=20
> >> ---
> >>   drivers/net/ethernet/intel/ice/ice_virtchnl.c | 21 +++++++----------=
--
> >>   1 file changed, 7 insertions(+), 14 deletions(-)
> >>
> >> diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> >> b/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> >> index 3f1a63815bac..a465f3743ffc 100644
> >> --- a/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> >> +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl.c
> >> @@ -3642,14 +3642,6 @@ void ice_vc_process_vf_msg(struct ice_pf *pf,

Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>