Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "nakamura.shun@fujitsu.com" <nakamura.shun@fujitsu.com>
To:     'Jiri Olsa' <olsajiri@gmail.com>
CC:     "peterz@infradead.org" <peterz@infradead.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "acme@kernel.org" <acme@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "jolsa@redhat.com" <jolsa@redhat.com>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>
Subject: RE: [RFC PATCH v2 5/7] libperf: Add perf_evsel__check_overflow()
 functions
Thread-Topic: [RFC PATCH v2 5/7] libperf: Add perf_evsel__check_overflow()
 functions
Thread-Index: AQHYRD0nCXA2T4GG5UGkrEtp9vrZWqzqdW1A
Date:   Mon, 11 Apr 2022 08:35:32 +0000
Message-ID: <OSBPR01MB460018BDE6C3F4ABDFE2CBD7F7EA9@OSBPR01MB4600.jpnprd01.prod.outlook.com>
References: <20220325043829.224045-1-nakamura.shun@fujitsu.com>
 <20220325043829.224045-6-nakamura.shun@fujitsu.com> <YkRgLBTHVQbdX8rK@krava>
In-Reply-To: <YkRgLBTHVQbdX8rK@krava>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?SUFlajUxYWRDTVdjTnlMZ1Bibys0MkZTOXVmUWdTRzg5bDJYNmRTbWVM?=
 =?iso-2022-jp?B?eEd2Slo1VUNHbjNmVVpOSHdYOHNKQ1Bla2hNUkJteHBwTnpsQS90SGdn?=
 =?iso-2022-jp?B?TytlOXg5TE11SVVWSk9hSmhBbkFjdkF3N2Q2NFNqdGNEK0k4NGJjbXBY?=
 =?iso-2022-jp?B?bzJuem5DUFRHTHBGVERkc1k1dHRObmJQQi8vUXhXRGd3WUw5WDlXNjhn?=
 =?iso-2022-jp?B?QjBqQnJUZXFNN0thWDlwV05jSUZyWUE5MlVZOWVKL1pIS3dvbHhjZmRk?=
 =?iso-2022-jp?B?bFlvNFpvN1RLTVBkd1BpZ1lyMmN1QnRhektGTTkxM1ZOWnZkTkVPemdW?=
 =?iso-2022-jp?B?QTc1dlVkZVc0SzE0VnZNeDVzTUkwUHFtdjAxUGZ1bnFwZnlnY3ZjOUxs?=
 =?iso-2022-jp?B?dGhCc3YvZyt1U2VyclFrdGxxT1h5c0Q3T2g2STlsVTBCUHpSRm1ySVVU?=
 =?iso-2022-jp?B?b1JJMmEzZTdNRlNiZzF2Y1FQa2h0dHFGdWRNZGdpTmhNaXZjaXk4NUNx?=
 =?iso-2022-jp?B?OCtuWHN5SGMyR0JpdHpZZmtjazNxblhzNVVwNmtEaWpKSVVFa01SS2tu?=
 =?iso-2022-jp?B?R2hCYm11ZlBsSWZ3R2haQ01CcXJRbjA3Yjg2bkVVc284V3JVSGt2N3pj?=
 =?iso-2022-jp?B?Q0NXZ1granNVaU1UaEF5anNmUTUwMmtybU5rS20zSDFRN1Z2aFFzUkp1?=
 =?iso-2022-jp?B?aVhwVjJPRmduQys0SDZyN2lEU25SaTB3ZDkzbkNJZHVJYXZFRGVXMzYr?=
 =?iso-2022-jp?B?b2orbFZVMU5haFNRSDF0akpHb3UrRjhjT3FjNzJQa1YxM3R5VGFuMHpE?=
 =?iso-2022-jp?B?Q2ZXYWZlaWlVemh4NUxWekVhYVEyYitwbjlPRWFOV2NXd3puSUtMeDdI?=
 =?iso-2022-jp?B?TCtoZnB0d1hmUTJ3VHcvTWQ2SEVGcGltRjJSdDljTktOeXNuTHhjT2NH?=
 =?iso-2022-jp?B?ejFCemZxaVRqWXhhYXpYdFEvNTE4M01obXRkVkRwQlV5WDRYM2k1bCt0?=
 =?iso-2022-jp?B?TnRNNFBLYWYvaFFNdDFkVmJoQ3JGWkpoS0M2RnJodlZSUTEveERIbnNq?=
 =?iso-2022-jp?B?eVZVVjFDZWQzZVovNzBqOFhzVUcreWhDaWNrTkQ2U3dOa05zdERyM0lT?=
 =?iso-2022-jp?B?QnVEdTBWNTUvd0c1RkFqSzVwWUVoTFFMa2syU2dHTWxGU2N0R2ZEVHJs?=
 =?iso-2022-jp?B?Rkw0b2tzMy8wa1V0V05xRUNkUmNEbmNYZzdreDNUOCtWVzZmZVZFZ0Fh?=
 =?iso-2022-jp?B?TTkyN2Ztd09tQmFjTFlpUGtoaTNqZ0xQajFndFVSTHVQOTVsc0xXSm1w?=
 =?iso-2022-jp?B?aGttaUtOYnp6NDlMQ1NyUFhSNFdoVWdTZWVnbFVCM3NCSFhiSHZWcHJj?=
 =?iso-2022-jp?B?bFFIUW4xMFNqR3Z5azJqZ29OL2pSL3lqQWJ3anl6dW5wUDNhZEZUNjV4?=
 =?iso-2022-jp?B?emsxR2tKc3FYMDdiUUR2QzBRL3Y1THZ6ZWtKM0JpTWZUQTVOSVlaWWJB?=
 =?iso-2022-jp?B?anpEWVZKSG81b3hxWjA4OHNHd3VvZWJVNDVuZ3dQY2Y3RVBUOUdKL0M2?=
 =?iso-2022-jp?B?KytwbUsxcTlJSHk0aHJjUE8wMUtZZjdRdVBwU2w5YWIySTBEWkZrMi80?=
 =?iso-2022-jp?B?MzllcXQ0R0dLci9aaGNCdTRTV2QxQ3ZncFpFZitDZjhqbExkTFhETEJa?=
 =?iso-2022-jp?B?WTlkaWVFZ3JEWE4yVTRHcVBTNjFCN29EdC9oN0ZtNWhqWHpGM3F6bW5a?=
 =?iso-2022-jp?B?cGs2UVVwSnN4TDIyWWMvTTZDeHU4NU84ZzIwUm1abENnb2dOSVJQRjc0?=
 =?iso-2022-jp?B?aEplWVBYdUIwUi9Qb1hqL2VaTWRFOHgzRERmZ2RDWG1ZS2lacklGNGhL?=
 =?iso-2022-jp?B?MGdzWTlla2hDNndnOGdxRjlDTm9VSWZZM1VjMlpRTWluWFJNMUI2ZS8w?=
 =?iso-2022-jp?B?RWpUZnFnUWIySlIwQTlwV2x1MFlXT01zZXE3VExUT1U1Z3A0VUFaNkFS?=
 =?iso-2022-jp?B?YW5DRnpJYmZ6WVlmaXZkVGtJL2FnN0cvWW9oMWd2OE0vb0xpcW43NWsy?=
 =?iso-2022-jp?B?Qk11TkF4VzhhZWlSTm5RMFdDTGpta2ZnOGp2RTlxajJpekxrajVISXZC?=
 =?iso-2022-jp?B?b2l3VFhTclhnbFd3ODU4Q25qcVlEVThBRkFXTmtGRTFvdDFIREdSZ1Rl?=
 =?iso-2022-jp?B?NEtLREYrb2lIL0l4Z01KeElqTWJiaWNyOHZUdVh5RkU2UmVkS0NBcUlU?=
 =?iso-2022-jp?B?Mm5DQ2ZBNTdCUFAzSmM2THVvenRuR3J2NzE3YnRGOFZuTmd0TU1jeWZs?=
 =?iso-2022-jp?B?TFRmNVJhRWFTMXJCRkh5MHBPVnhydFVmNTlSUW5mbC9iNEtVaTAva2FC?=
 =?iso-2022-jp?B?UFBvT1pGTFhiZGxsQXpoblV6YnU4T2tXVXJXZEJlTENUNUNDVGpKU2pw?=
 =?iso-2022-jp?B?NXphUVpuNXlVcmpNU3JrWmZPVkNYVmhiRVJGTGxralZQYVVFZUxKSXgw?=
 =?iso-2022-jp?B?Wk40aGJMTFVuclBTeUcvMFFCSTkzMVNmME0rTGhNbklGMEtPYzAxZHNW?=
 =?iso-2022-jp?B?eTFNYi9oYz0=?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: fujitsu.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSBPR01MB4600.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0aa849e7-6873-4a17-51b2-08da1b963df5
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2022 08:35:32.4409
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nJM4MUZY5Q7wRQ0aNn3+s6+oYV+j89XXRdmGJS5t3AKdReIH/EL3CsOrrmHTJybnQI/jpI8Retvg5vQyy6E095+tamaE8lrhkKLl/ccBXTE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB3316
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi jirka

> On Fri, Mar 25, 2022 at 01:38:27PM +0900, Shunsuke Nakamura wrote:
> > Add the following functions:
> >
> >   perf_evsel__check_overflow
> >   perf_evsel__check_overflow_cpu
> >
> > to check for perf events with the file descriptor specified in the
> > argument.
> > These functions can be used in signal handlers to check overflow.
> >
> > Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com>
> > ---
> >  tools/lib/perf/Documentation/libperf.txt |  3 +++
> >  tools/lib/perf/evsel.c                   | 34
> ++++++++++++++++++++++++
> >  tools/lib/perf/include/perf/evsel.h      |  4 +++
> >  tools/lib/perf/libperf.map               |  2 ++
> >  4 files changed, 43 insertions(+)
> >
> > diff --git a/tools/lib/perf/Documentation/libperf.txt
> > b/tools/lib/perf/Documentation/libperf.txt
> > index 700c1ce15159..4ae8d738b948 100644
> > --- a/tools/lib/perf/Documentation/libperf.txt
> > +++ b/tools/lib/perf/Documentation/libperf.txt
> > @@ -165,6 +165,9 @@ SYNOPSIS
> >                                int cpu_map_idx);
> >    int perf_evsel__period(struct perf_evsel *evsel, int period);
> >    int perf_evsel__period_cpu(struct perf_evsel *evsel, int period,
> > int cpu_map_idx);
> > +  int perf_evsel__check_overflow(struct perf_evsel *evsel, int
> > + sig_fd, bool *overflow);  int perf_evsel__check_overflow_cpu(struct
> perf_evsel *evsel, int cpu_map_idx,
> > +                                     int sig_fd, bool *overflow);
>=20
> should this be more like:
>=20
>   perf_evsel__has_fd(struct perf_evsel *evsel, int fd)
>=20
I'll fix it.


> also why do we need to export *_cpu version for this?
> I don't see it used in the test
>=20
Sorry, not necessary.
I'll fix it.

> >    struct perf_cpu_map *perf_evsel__cpus(struct perf_evsel *evsel);
> >    struct perf_thread_map *perf_evsel__threads(struct perf_evsel *evsel=
);
> >    struct perf_event_attr *perf_evsel__attr(struct perf_evsel *evsel);
> > diff --git a/tools/lib/perf/evsel.c b/tools/lib/perf/evsel.c index
> > db9b7274feb5..6ff3cf692df3 100644
> > --- a/tools/lib/perf/evsel.c
> > +++ b/tools/lib/perf/evsel.c
> > @@ -616,3 +616,37 @@ int perf_evsel__open_opts(struct perf_evsel
> > *evsel, struct perf_cpu_map *cpus,
> >
> >  	return err;
> >  }
> > +
> > +int perf_evsel__check_overflow_cpu(struct perf_evsel *evsel, int
> cpu_map_idx,
> > +				   int sig_fd, bool *overflow)
> > +{
> > +	int thread;
> > +	int *fd;
> > +	int err =3D 0;
> > +
> > +	if (!overflow)
> > +		return -EINVAL;
> > +
> > +	*overflow =3D false;
> > +
> > +	for (thread =3D 0; thread < xyarray__max_y(evsel->fd) && !err; ++thre=
ad)
> {
> > +		fd =3D FD(evsel, cpu_map_idx, thread);
> > +		if (sig_fd <=3D 0 || !fd || *fd < 0)
> > +			err =3D -EINVAL;
>=20
> sig_fd check should be before the loop
>=20
I'll fix it.


Best Regards
Shunsuke