Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <657edaae-cb56-9c01-383b-680a0e95f722@oracle.com>
Date:   Mon, 11 Apr 2022 08:54:28 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH v6 2/8] x86/crash: Introduce new options to support cpu
 and memory hotplug
Content-Language: en-US
To:     Baoquan He <bhe@redhat.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com,
        konrad.wilk@oracle.com, boris.ostrovsky@oracle.com,
        akpm@linux-foundation.org
References: <20220401183040.1624-1-eric.devolder@oracle.com>
 <20220401183040.1624-3-eric.devolder@oracle.com>
 <Yk/tMnoYN/p6vxxT@MiWiFi-R3L-srv>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <Yk/tMnoYN/p6vxxT@MiWiFi-R3L-srv>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHRDY2gxeGJTTW4vUERZNW9wd1VTNGhXK3RIdlVyWGtDSG9lZGh4enJRVEJE?=
 =?utf-8?B?YkxDWUVLZm5RMDd3Mkg5MFhSZSsrVU83UEt6dm9qK1VsUlhGVzRzU3l4N2k0?=
 =?utf-8?B?bVZrUk1SOERoUEJEWGIvOEZYakk1RmJOdVNtNmJVTmVGSWdwdmFqTW45OHFD?=
 =?utf-8?B?aG44YTMrRjJJUWg1eEI3eE0wREkrVGhQSjBBVHgvRUQzZVRMWlI2cXNvVyt0?=
 =?utf-8?B?NnlhWXljRDcyRytJWi9BZDloaTY2RytkTVBxRnhLN3hnNlRISUs5RmpsWWtp?=
 =?utf-8?B?K1cxV1RRd0xkTDVFd0szcitHRG5UZkVrNEJEaVJVSDJiWHVMbWFFcFptbXR0?=
 =?utf-8?B?K3BTQnFRVUVrWmVUVzFkVFU2a2lEMXFUdUQ4TFYvbnJUY0pZc2Y3S1JsenNM?=
 =?utf-8?B?bXhzVnVETG9uVmpLREVCdTdQYjFVRDBFbUhBS20zZm9UNmdoU1F0SzJhNDc1?=
 =?utf-8?B?RU5YTktQc2RSV3FxTkw4QWJ5UTdSdnZzUDI0dCt6Q1JYbm5LUzRGV2pHcWlJ?=
 =?utf-8?B?dmd3cDJGKy82WGJUalJsWGFYa09QQ3p0eUdSTGdrMG1meDVRYS82bytnWUhQ?=
 =?utf-8?B?RFczM2xRWFRNN2JoRVR6ekQ2am8zN1oxZVVUN0crcnY2eGd6am9kZXRKcHgr?=
 =?utf-8?B?WEZkYkdMSWRxSVAvbkJuZzVzZUtNMUdiNlNXdmpwYWh1bjhsOVpDVEpKMFA5?=
 =?utf-8?B?QnNjMjdxUG80T3lqQmlGNGRxNzBpVU9LNVB5ajZwdDRFNW9STTVWUk45VXlG?=
 =?utf-8?B?OVZjMlZWUjlVR2FZTjFxcGZFUnNoWmoyTy9pNEpTSGN3UlllWThXUmxKOTdT?=
 =?utf-8?B?dVM4cUpJVGJEMXVaL0hrTWM5OVlVWVJCYk9PVUdkdGRtVkI5eXlGWGkvTFlN?=
 =?utf-8?B?WEJUNnVvYW5PWFlNdkh1ZWNRZkNMQlBQMnByN05CMUhpT1d1TWpNNDFtZExL?=
 =?utf-8?B?NXRPckg3T3gxb0VCd3oxOHpHVVE5Y1RnZUtWMEN0aU13UEM0b0JtTmErUk04?=
 =?utf-8?B?d25TazI3OHgvS2hsTFl1WkNZTzh4czNCMXNmSlhxTEQyaWMxMVFkM0laSlNP?=
 =?utf-8?B?S3dwTVE3UTl0alJwV2ZGQ09vUEQ3MThFMENMWUwzZEhlRGpxcmJHRmowRWVC?=
 =?utf-8?B?MjM5RlQ3d0hrRGtTN1RiV2J4eDlHSGtKaXNqNFN3UFg4Qk1Oem90NDEzbkNa?=
 =?utf-8?B?WjRad2dMdlZaeVRxRC8yQzVLY3NRblM2RmM0c0FyUmhyMFRpVkw0bDFYZ0xF?=
 =?utf-8?B?c255dFBsSlNLR280VUVQck0vSG9WQVE3blp5WDdnSXl5WldiYzExeFYwY1pO?=
 =?utf-8?B?T1padnlMYkRiMnZUVHg5eS9qcHl0ZWNiZlZZL3BxOGFjQTllV1RIalBkV3dh?=
 =?utf-8?B?RjRTUGVlaE5XUWxaajlLYy9jRldHTko5QjdpTGtvV3RQTmJNcHgvSXNuTnhw?=
 =?utf-8?B?QmFWTEZ4WVRSNUIyM2ZhbXYyb1lLaW56MFpsbW53MENtUHZBRXNwSXRjOTlF?=
 =?utf-8?B?Mlg3UWVHRTQvalAvVEkvUzBBMmp5K2RGNVYxOEJtWS92V0dpTFpkc001VzJZ?=
 =?utf-8?B?TmdvWkRscVJyZC9VaUFGTU5VTHFhV2RHNkVKeDQ5aFdEQldYQVJ2OEtqTEt6?=
 =?utf-8?B?UjlBYXZ2bWR2Y1lZSXZmbmJ5bkQ5Y0YzNjgrNlJ1YmZSOWZYNExYRmdpc0lw?=
 =?utf-8?B?MEsrR3JHV29nQjlaS1BTbkVjbDlDRmErUER1bU5yQnVXWVIzR2w0WHNwRm8w?=
 =?utf-8?B?MXQ0RldYeStuYmdMZ0IrUmk1QkxZYUZpU09VczVEMFU3ZU04RTBkVlZJU2JM?=
 =?utf-8?B?MkxBS083OUQ5K1V3KzlEcEpFdWc3MmVSV3JPMWRUd2d3R2k5N0wyMUhGOUpr?=
 =?utf-8?B?RUpZeStIeDNOMkZHb3V6dXcvR1d1QzVZNHNFRkhWZk1lRDc0WEQzdjVqTHhK?=
 =?utf-8?B?eVBScHp1SCtvTFRFOWp0Rml1QXJsMnVXWjJOeXVpRFRDU1RWeW5BNURiQ01D?=
 =?utf-8?B?ZXlnMzd5SlhMZnBrQ0IxTFA0ZHFabDAyKzN0d0F1R2FlSWFieTI2a2Z0d0VM?=
 =?utf-8?B?RTcvdllzWDlEVmgvYS9Jc1ZVTnlnV2JCdjUwMk5KTGpOUGF5YXdHUlJWSjdp?=
 =?utf-8?B?RENWRGh1MkZYNFlpbmZaNENPUjdHSWI2Y3VJZkU1ZXJzb1J3U1l1SDJleVNm?=
 =?utf-8?B?alF3NFBXRERCYU42a20rU3F4aHZkR1BIQjZwWUQwcW9GL3pVQ3RxcHhqcVF5?=
 =?utf-8?B?WXdHclBSSGQxcVBLWFlYb1NKdGRvRVh2S1FyNC8zUUt5YWJxMWt3NnNGVHlm?=
 =?utf-8?B?S0pRL0x4QS9rRC9EU2lJTTRzbDZMamV0Ni9GcTR5cUs0d2pickFVSjA4Zi9U?=
 =?utf-8?Q?d8X0WrozuyFw8Ljww+fRY+5bkTNxv7Vjc4is9A29QtqSo?=
X-MS-Exchange-AntiSpam-MessageData-1: H+eq+mDQJIAQ7g==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e0ba774-c5d1-4f93-4a54-08da1bc2cfbc
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 13:54:35.1206
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FpAMdNZiArX/7/rmKak6ND5BnjMK3vRHixPrZhGZ3pVbuy81jv80CJEKjxOchmOfJOIMU4ihY7MpycyNRAH60lyEMK3AlTpUkMKuQz5BUL4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1379
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.858
 definitions=2022-04-11_05:2022-04-11,2022-04-11 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 mlxscore=0 phishscore=0 suspectscore=0 spamscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204110076
X-Proofpoint-ORIG-GUID: h6a6yPmPDJU6iLO1fZ-97RgumwQRz4hn
X-Proofpoint-GUID: h6a6yPmPDJU6iLO1fZ-97RgumwQRz4hn
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/8/22 03:07, Baoquan He wrote:
> On 04/01/22 at 02:30pm, Eric DeVolder wrote:
>> CRASH_HOTPLUG is to enable cpu and memory hotplug support of crash.
>>
>> CRASH_HOTPLUG_ELFCOREHDR_SZ is used to specify the maximum size of
>> the elfcorehdr buffer/segment.
>>
>> This is a preparation for later usage.
>>
>> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
> 
> LGTM,
> 
> Acked-by: Baoquan He <bhe@redhat.com>

Excellent, thanks!
eric

> 
>> ---
>>   arch/x86/Kconfig | 26 ++++++++++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 7340d9f01b62..8b51d3196b82 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -2072,6 +2072,32 @@ config CRASH_DUMP
>>   	  (CONFIG_RELOCATABLE=y).
>>   	  For more details see Documentation/admin-guide/kdump/kdump.rst
>>   
>> +config CRASH_HOTPLUG
>> +	bool "kernel updates of crash elfcorehdr"
>> +	depends on CRASH_DUMP && (HOTPLUG_CPU || MEMORY_HOTPLUG) && KEXEC_FILE
>> +	help
>> +	  Enable the kernel to update the crash elfcorehdr (which contains
>> +	  the list of CPUs and memory regions) directly when hot plug/unplug
>> +	  of CPUs or memory. Otherwise userspace must monitor these hot
>> +	  plug/unplug change notifications via udev in order to
>> +	  unload-then-reload the crash kernel so that the list of CPUs and
>> +	  memory regions is kept up-to-date. Note that the udev CPU and
>> +	  memory change notifications still occur (however, userspace is not
>> +	  required to monitor for crash dump purposes).
>> +
>> +config CRASH_HOTPLUG_ELFCOREHDR_SZ
>> +	depends on CRASH_HOTPLUG
>> +	int
>> +	default 131072
>> +	help
>> +	  Specify the maximum size of the elfcorehdr buffer/segment.
>> +	  The 128KiB default is sized so that it can accommodate 2048
>> +	  Elf64_Phdr, where each Phdr represents either a CPU or a
>> +	  region of memory.
>> +	  For example, this size can accommodate a machine with up to 1024
>> +	  CPUs and up to 1024 memory regions, eg. as represented by the
>> +	  'System RAM' entries in /proc/iomem.
>> +
>>   config KEXEC_JUMP
>>   	bool "kexec jump"
>>   	depends on KEXEC && HIBERNATION
>> -- 
>> 2.27.0
>>
>