Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <78ec4bb7-b575-2554-9a29-e25c28022bdf@ti.com>
Date:   Tue, 12 Apr 2022 12:49:39 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] net: ethernet: ti: cpsw: using pm_runtime_resume_and_get
 instead of pm_runtime_get_sync
Content-Language: en-US
To:     <cgel.zte@gmail.com>
CC:     <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <linux-omap@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Minghao Chi <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20220412082847.2532584-1-chi.minghao@zte.com.cn>
From:   Grygorii Strashko <grygorii.strashko@ti.com>
In-Reply-To: <20220412082847.2532584-1-chi.minghao@zte.com.cn>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/04/2022 11:28, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. This change is just to simplify the code, no
> actual functional changes.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>   drivers/net/ethernet/ti/cpsw.c | 36 ++++++++++++----------------------
>   1 file changed, 12 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 03575c017500..9f37b5b196a5 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -756,11 +756,9 @@ static int cpsw_ndo_open(struct net_device *ndev)
>   	int ret;
>   	u32 reg;
>   
> -	ret = pm_runtime_get_sync(cpsw->dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(cpsw->dev);
> +	ret = pm_runtime_resume_and_get(cpsw->dev);
> +	if (ret < 0)
>   		return ret;
> -	}
>   
>   	netif_carrier_off(ndev);
>   
> @@ -968,11 +966,9 @@ static int cpsw_ndo_set_mac_address(struct net_device *ndev, void *p)
>   	if (!is_valid_ether_addr(addr->sa_data))
>   		return -EADDRNOTAVAIL;
>   
> -	ret = pm_runtime_get_sync(cpsw->dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(cpsw->dev);
> +	ret = pm_runtime_resume_and_get(cpsw->dev);
> +	if (ret < 0)
>   		return ret;
> -	}
>   
>   	if (cpsw->data.dual_emac) {
>   		vid = cpsw->slaves[priv->emac_port].port_vlan;
> @@ -1052,11 +1048,9 @@ static int cpsw_ndo_vlan_rx_add_vid(struct net_device *ndev,
>   	if (vid == cpsw->data.default_vlan)
>   		return 0;
>   
> -	ret = pm_runtime_get_sync(cpsw->dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(cpsw->dev);
> +	ret = pm_runtime_resume_and_get(cpsw->dev);
> +	if (ret < 0)
>   		return ret;
> -	}
>   
>   	if (cpsw->data.dual_emac) {
>   		/* In dual EMAC, reserved VLAN id should not be used for
> @@ -1090,11 +1084,9 @@ static int cpsw_ndo_vlan_rx_kill_vid(struct net_device *ndev,
>   	if (vid == cpsw->data.default_vlan)
>   		return 0;
>   
> -	ret = pm_runtime_get_sync(cpsw->dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(cpsw->dev);
> +	ret = pm_runtime_resume_and_get(cpsw->dev);
> +	if (ret < 0)
>   		return ret;
> -	}
>   
>   	if (cpsw->data.dual_emac) {
>   		int i;
> @@ -1567,11 +1559,9 @@ static int cpsw_probe(struct platform_device *pdev)
>   	/* Need to enable clocks with runtime PM api to access module
>   	 * registers
>   	 */
> -	ret = pm_runtime_get_sync(dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(dev);
> +	ret = pm_runtime_resume_and_get(dev);
> +	if (ret < 0)
>   		goto clean_runtime_disable_ret;
> -	}
>   
>   	ret = cpsw_probe_dt(&cpsw->data, pdev);
>   	if (ret)
> @@ -1734,11 +1724,9 @@ static int cpsw_remove(struct platform_device *pdev)
>   	struct cpsw_common *cpsw = platform_get_drvdata(pdev);
>   	int i, ret;
>   
> -	ret = pm_runtime_get_sync(&pdev->dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(&pdev->dev);
> +	ret = pm_runtime_resume_and_get(&pdev->dev);
> +	if (ret < 0)
>   		return ret;
> -	}
>   
>   	for (i = 0; i < cpsw->data.slaves; i++)
>   		if (cpsw->slaves[i].ndev)

Thank you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

-- 
Best regards,
Grygorii, Ukraine