Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <48939b53-ede5-103a-ceae-9d7b9dcc4a1b@ti.com>
Date:   Tue, 12 Apr 2022 11:46:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] soc: ti: knav_dma: using pm_runtime_resume_and_get
 instead of pm_runtime_get_sync
Content-Language: en-US
To:     <cgel.zte@gmail.com>, <nm@ti.com>
CC:     <ssantosh@kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Minghao Chi <chi.minghao@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20220412082923.2532649-1-chi.minghao@zte.com.cn>
From:   Grygorii Strashko <grygorii.strashko@ti.com>
In-Reply-To: <20220412082923.2532649-1-chi.minghao@zte.com.cn>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/04/2022 11:29, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>   drivers/soc/ti/knav_dma.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c
> index 700d8eecd8c4..061f92c8cf7d 100644
> --- a/drivers/soc/ti/knav_dma.c
> +++ b/drivers/soc/ti/knav_dma.c
> @@ -747,9 +747,8 @@ static int knav_dma_probe(struct platform_device *pdev)
>   	INIT_LIST_HEAD(&kdev->list);
>   
>   	pm_runtime_enable(kdev->dev);
> -	ret = pm_runtime_get_sync(kdev->dev);
> +	ret = pm_runtime_resume_and_get(kdev->dev);
>   	if (ret < 0) {
> -		pm_runtime_put_noidle(kdev->dev);
>   		dev_err(kdev->dev, "unable to enable pktdma, err %d\n", ret);
>   		goto err_pm_disable;
>   	}

Thank you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

-- 
Best regards,
Grygorii, Ukraine