Received: by 2002:a05:6512:3d0e:0:0:0:0 with SMTP id d14csp49017lfv; Tue, 12 Apr 2022 16:49:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz46tAZxaYCp7dY1f5NMSsu4CHdsCdMjj59F1M/Xorj3OxEWoCLcuV9HL1L8xKGr1I4aSaf X-Received: by 2002:a63:4d4c:0:b0:39d:3808:804f with SMTP id n12-20020a634d4c000000b0039d3808804fmr13162547pgl.312.1649807352350; Tue, 12 Apr 2022 16:49:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649807352; cv=none; d=google.com; s=arc-20160816; b=Aps3kFO19RnIUl9qNDJMrvzQ6AuBs9hVu05oP8CH48pqn9sKqB/NPCzba0jjEOSgBt s5ndDFTKItjyjrCJMNVj7XMU6QDdVx7dzcFmYBHZLbALleC+hLyRH9PfIdNDBf7OpoD+ 3oZvWqAgRC9W3QmQ2+RDl70e3wuYjd5VsAQlhO3SGt9YOYkT7xmmGW7WJL4RQOr7TI5+ gc81YggTe/gYXNxXVJiSvseVFgMq4vrfyRMKZdII/EHBQ0SkU7QA0OCKmLmz0GEXEL88 aH8wUSWd0uJtEhhr25tWUkWwNC0cIs+uIAhM0g6vBh1u4lCJ3e2M30vX5fay9uT2AVx1 rBcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=O84u4g0rEMhiEbnfnW6weOWFhugAjRvAb7liky1i+SU=; b=Yf0hmBh+hymX0baWAnKY+tc6KNxpDJyk1POJHZ9Lik1PPqdC3TKzwrtGIOZcO5E5FV HfIfWJtb/5GJYL+9vHalt324eXnOHsZ8s2eWzbROQDyw5jfqq+Ce6eXAhlN6rmLxUKz0 XiV8k+4snHDsaaePC+bjn1vgUvpi/Vy/xGPMXvt2gKLEcyh0VSc8EsmChkfM4WZ12Wyv RycIsxeV34FiTykTvvTRQnrw3QXv11YNwHK7KESyH8F/1WUDyvpTsJ4yyKtgvs5pXM21 9SrPF3Sr7AM+/RyLYiBf9hO8rgsxhFDW3x59zLaKrrJPJ8fxSeB6AeaYDtweM8Xmsbfz NKtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=DneHJtvU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id x15-20020a170902ec8f00b00155f2da2cccsi14711708plg.54.2022.04.12.16.49.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 16:49:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=DneHJtvU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 682EC1275C7; Tue, 12 Apr 2022 14:41:57 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241989AbiDKENF (ORCPT + 99 others); Mon, 11 Apr 2022 00:13:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233151AbiDKEND (ORCPT ); Mon, 11 Apr 2022 00:13:03 -0400 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D30CB273E; Sun, 10 Apr 2022 21:10:50 -0700 (PDT) Received: by mail-qv1-xf29.google.com with SMTP id ke15so12317365qvb.11; Sun, 10 Apr 2022 21:10:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=O84u4g0rEMhiEbnfnW6weOWFhugAjRvAb7liky1i+SU=; b=DneHJtvUWQgzhOZMeRyv/pSo0pxe+UFtg/MsQ1rVH5VYF1UxmxumkfkI9sbO0pO3YW mLqbiQOwBibN4dPwSUNoqxw9l40OCyYRn6kSRLXm+OZPkLL19xfXYcgtR83ICfbZdoI8 dTbYZY4xMkBLKnCQSI5z8nUdu+w4FtqAqVpsPmmXR73HV5GdiXBqmsPscwvwi1VR0/jj cQ2X3sh67++uXNGhhADPVGdCCQH33h+5AnIzpWxXNJqrYdkm7dKLn9aqyiD1RPZUpZi4 FyAHQWguvtperffgP7ByO/yxwLwYtv5CEpHYp6mYgvuRNGTPlXlU8SsXUFLN7nhyrWid B21w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=O84u4g0rEMhiEbnfnW6weOWFhugAjRvAb7liky1i+SU=; b=e0Erzy59O3DdJfPmGwfQpmKimH+3MFYwBHSWPWpObbEadl6brNHYYAM/yyr5M0f9K8 iiI7SnZpfse3UhPN74bqqg3Pv3/WN/rDITKqewV73fR5djKY2gczsdA+ATEV9cJ4bQqS CHGq4g8F6WFX5V9tjKIFjDWq046SjQh3w7ZjD0oQoMn66ZalGDqxrOrJCUIoO+iNHCmM ml8a8Bhde/kr1vo7O8vg/DrRzwvOnoB0kg0E6mB9b6D3Q5zWt7amLx7ikcVHgX2CiQQ8 wQgBi2Vm56MbHkUomm2rM+ztHK8k6Nm1P8dFV/nMKz7sRtMJmTqFTfNrjwak86K4kEle ppJA== X-Gm-Message-State: AOAM5323uuDHXMX0BGu3zDPusoCAmyIdASobdCsdysGlLzTpADsy6/Uz Flda+IJoiNrzQ9gM4Yq+MWo= X-Received: by 2002:a0c:ea52:0:b0:444:330a:2f19 with SMTP id u18-20020a0cea52000000b00444330a2f19mr7304876qvp.32.1649650249725; Sun, 10 Apr 2022 21:10:49 -0700 (PDT) Received: from ?IPV6:2600:1700:2442:6db0:91e2:dfcf:c904:aebc? ([2600:1700:2442:6db0:91e2:dfcf:c904:aebc]) by smtp.gmail.com with ESMTPSA id x138-20020a376390000000b0069bf27a8d26sm4568598qkb.47.2022.04.10.21.10.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Apr 2022 21:10:49 -0700 (PDT) Message-ID: Date: Sun, 10 Apr 2022 23:10:48 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 0/2] of: overlay: rework overlay apply and remove kfree()s Content-Language: en-US From: Frank Rowand To: Rob Herring , pantelis.antoniou@konsulko.com, Slawomir Stepien Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Slawomir Stepien , Geert Uytterhoeven , Alan Tull , Jan Kiszka References: <20220410210833.441504-1-frowand.list@gmail.com> In-Reply-To: <20220410210833.441504-1-frowand.list@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org adding cc: Jan Kiszka On 4/10/22 16:08, frowand.list@gmail.com wrote: > From: Frank Rowand > > Fix various kfree() issues related to of_overlay_apply(). > > The fixes revealed inconsist variable names for the same variable > across functions, resulting in difficulty understanding the code > that was being modified. Doing both variable renaming and the > fixes results in a hard to review patch, so split into two patches. > > The first patch in the series contains only variable renaming. > The second patch contains the kfree() related fixes. > > Frank Rowand (2): > of: overlay: rename variables to be consistent > of: overlay: rework overlay apply and remove kfree()s > > Documentation/devicetree/overlay-notes.rst | 23 ++- > drivers/of/overlay.c | 175 +++++++++++---------- > 2 files changed, 115 insertions(+), 83 deletions(-) >