Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 8 Apr 2022 14:55:22 +0300
From:   Abel Vesa <abel.vesa@nxp.com>
To:     xkernel.wang@foxmail.com
Cc:     mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: imx: scu: fix a potential memory leak in
 __imx_clk_gpr_scu()
Message-ID: <YlAiqhRf1p+svR1O@abelvesa>
References: <tencent_27FF59903EE6AB5C0D0E6D0A8E7059A59007@qq.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tencent_27FF59903EE6AB5C0D0E6D0A8E7059A59007@qq.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7S0TR5d7Xj3Y77eo6tclzF29XZlb5iP7kQUjAV3O4Yz7LaLNFTvotf8qTmj5?=
 =?us-ascii?Q?y2FL7o6L8s0tMWSMVSVhAlF65vaH2ZnBy6yJ0K5uFX9rK1KssWuYQdGGcVoL?=
 =?us-ascii?Q?PIBuNV6oo2pm0Oo3jU5jUBD5Trfm5j4qTitdU52c5DBOZAuFPYPISxBK/9Ue?=
 =?us-ascii?Q?4d5LV+/GOFbac2SED/0tk36gHT6OzUxyRqoZcuylJJ4pJfQe7QF28HfvXumf?=
 =?us-ascii?Q?LndNz21EpudWH/nes8upZOCko4DHWt6F4LPm6tj3orX8TDYAORueb9+vq28E?=
 =?us-ascii?Q?JWnNwrHzNZgm6a6mEflqJAsh4XfHMNBsdLh4UPWb0c/im3lGge2vYdCWS2QA?=
 =?us-ascii?Q?lvYsf1603HodFkpjMJjxBIdS9a44SIur4dbq7grej8qS9cPCd5KIQIcXt+j6?=
 =?us-ascii?Q?0aHITs0FcRklC0+QuNjWbIUahiPp+aKZ3FlxiswhIEMARHcgFv5CHAjF+tyT?=
 =?us-ascii?Q?mbDoZIncEyDwASgD6zTDQK7FejM/a1YExaL97hJ8urc74P9NZ1+6V45osq0c?=
 =?us-ascii?Q?2DlYUCFqNSEVj3ZH6nx1diHw4RKs2UQtwN71wrWdfL70Fwx2pLk97J5GhQHb?=
 =?us-ascii?Q?PCVrk3tlHt+/8bzcAlV4LzFcGLCkM2Kd2LbO8zzv6tLBIjwr3xnB5q0o9rHD?=
 =?us-ascii?Q?CqjJ71dLizuJn+9e+d8VvmYqrPke5UTl7eWPKdwTmHmKYKKku0vgmRr/fe9l?=
 =?us-ascii?Q?T0qtLJ2pCDeqZKYBLS6xcqLuwrHRRXaiwVxLI1qonoDQM4CdcR0JA3o3GuMP?=
 =?us-ascii?Q?fhbsxwRaM2rXxbwsQZmRRNEIJFYLyFkAzaFSSPM3SofMkMJ4YVOrDxh/7RYz?=
 =?us-ascii?Q?HB8H1dX8x7icZw+QuICplVdKsv9VqZEXOxuZMy/iq83sUF1aCs2OFtAmBzOe?=
 =?us-ascii?Q?qRevAWk8/poOTO3wnhRSfWBBH/hMikgzfxiyhG27mGQCg5Fj8XvKS6DANQsf?=
 =?us-ascii?Q?wopLlWe+HF3S1TIZ8EElpq9DKSHwoIbzw2YKkj4Hh/RZG9DCUJnozdxWc+9l?=
 =?us-ascii?Q?GkwCVIrQeRsKfBrf5AkgxZ5C8mP/tuXGYAUpkjHbOjabW6XB4ciZQ0wLz4dA?=
 =?us-ascii?Q?shl13r0c4yzsR7pglXpSAr3KuItaa8IUiUuo1dEIJZWXWTKf05ryOtXO8T3G?=
 =?us-ascii?Q?oCiCfOClTUf9Jeve13WK9Lm6eROTnCihPMMTuhjFKnJhqX1FmqtXsb/9Mkzd?=
 =?us-ascii?Q?mIrz2IUkRPzSXV5WUK3ZEL5k3HoZGQpfmgmLIKCpSJHBQ7WKUhAPT2fVoxOh?=
 =?us-ascii?Q?YoGGz7di5rmtmfyRBL+sBNVe3cWKMgq5nLpCSmyCKeS58EoZ9kD6qU3Zz0mZ?=
 =?us-ascii?Q?ujmKXkkDhXbVlYLHsPc6p+ThoQD+zfDiZtYt8FgAJPkT77ufFFddUzCODwQJ?=
 =?us-ascii?Q?hLJQOJfvoWwBEXDBUSRJHKdZXIS+CMPsbnzSf8jRGprsdNKTLpcCqc6dBEyK?=
 =?us-ascii?Q?rKa9x/NKUzyte526I0n8Xb9nObDoB9MWy5FfGN29+3bhe8p2wha+WGiqtv88?=
 =?us-ascii?Q?X31MXyGX+rAJ3i3VDJ6j6uI+dqT9yRl27iTjdViRLgB8x+RyU0vbfQ06K+f+?=
 =?us-ascii?Q?q8p1BqM7WEMhKn6R+sfz0SXxVGAJx1p03oh68f1/yqAypsrPT1Fk1F6qbpci?=
 =?us-ascii?Q?GrAYuAptSmzrMtbF1f5hMUJ56D6F1dYJuS/NXW1MEpAICK7yoP6z3OHzNkHG?=
 =?us-ascii?Q?Vow1VC2xnjK3mR3vw0wNOaLcDzuveeH4FEyfsHvqV+SsQCMN51Q4P+Qt/dV+?=
 =?us-ascii?Q?6b7Yw9W3MQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9136091b-79cc-46c2-915e-08da1956aa83
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2022 11:55:24.6539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oSKirM5zzgjQsUjXx3w13JqnwLaixciXOMfckd/4/EFn5I6+yl+beZ2TO6UQh1k2dnR/yJEFUTCpRJrhcijGDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6978
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22-04-07 15:37:22, xkernel.wang@foxmail.com wrote:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> In __imx_clk_gpr_scu(), if imx_scu_clk_is_valid(rsrc_id) fails, then
> `clk_node` which is allocated by kzalloc() is not properly released,
> which may lead to memory leak.
> So this patch added kfree(clk_node) on the above error path before
> return ERR_PTR(-EINVAL).
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

> ---
>  drivers/clk/imx/clk-scu.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
> index 083da31..ed3c01d 100644
> --- a/drivers/clk/imx/clk-scu.c
> +++ b/drivers/clk/imx/clk-scu.c
> @@ -837,8 +837,10 @@ struct clk_hw *__imx_clk_gpr_scu(const char *name, const char * const *parent_na
>  	if (!clk_node)
>  		return ERR_PTR(-ENOMEM);
>
> -	if (!imx_scu_clk_is_valid(rsrc_id))
> +	if (!imx_scu_clk_is_valid(rsrc_id)) {
> +		kfree(clk_node);
>  		return ERR_PTR(-EINVAL);
> +	}
>
>  	clk = kzalloc(sizeof(*clk), GFP_KERNEL);
>  	if (!clk) {
> --