Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Gabriel Krisman Bertazi <krisman@collabora.com>
To:     Shreeya Patel <shreeya.patel@collabora.com>
Cc:     Jonathan Cameron <jic23@kernel.org>, krzk@kernel.org,
        lars@metafoo.de, robh+dt@kernel.org, Zhigang.Shi@liteon.com,
        linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com,
        alvaro.soliverez@collabora.com
Subject: Re: [PATCH 3/3] iio: light: Add support for ltrf216a sensor
Organization: Collabora
References: <20220325103014.6597-1-shreeya.patel@collabora.com>
        <20220325103014.6597-4-shreeya.patel@collabora.com>
        <20220327153049.10e525e9@jic23-huawei>
        <d5de6b56-ad90-feec-c65a-53699c8ddbe9@collabora.com>
Date:   Tue, 12 Apr 2022 10:06:18 -0400
In-Reply-To: <d5de6b56-ad90-feec-c65a-53699c8ddbe9@collabora.com> (Shreeya
        Patel's message of "Mon, 11 Apr 2022 22:36:56 +0530")
Message-ID: <875ynexup1.fsf@collabora.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Shreeya Patel <shreeya.patel@collabora.com> writes:

>>> +	val_1 = i2c_smbus_read_byte_data(data->client, addr + 1);
>>> +	val_2 = i2c_smbus_read_byte_data(data->client, addr + 2);
>>> +	ret = (val_2 << 16) + (val_1 << 8) + val_0;
>> This is a le24_to_cpu() conversion.
>> Preferred choice would be to use something like
>> 	u8 buf[3];
>> 	int i;
>>
>> 	for (i = 0; i < 3; i++) {
>> 		ret = i2c_smbus_read_byte_data(data->client, addr);
>> 		if (ret < 0)
>> 			return ret;
>> 		buf[i] = ret;
>> 	}
>> 	return le24_to_cpu(buf);
>>
>
> We do not have any le24_to_cpu() function in current kernel source code.
> I was thinking to use le32_to_cpu() instead but it requires an argument of
> type __le32 and our case we storing the values in u8 buf[3] so I'm not
> really sure if it's possible to use le32_to_cpu() or any other function.

I guess you could make it a 32-bit buffer, keep the most
significant byte zeroed and return le32_to_cpu:

  u8 buf[4];

  memset(buf, 0x0, sizeof(buf));

  for (i = 0; i < 3; i++) {
 	ret = i2c_smbus_read_byte_data(data->client, addr);
 	if (ret < 0)
 		return ret;
	buf[i] = ret;
  }
  return le32_to_cpu(buf);

-- 
Gabriel Krisman Bertazi