Received: by 2002:a05:6512:3d0e:0:0:0:0 with SMTP id d14csp51779lfv; Tue, 12 Apr 2022 16:57:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLU3N7orJb3LdkyxCwfiYdhpKeZu+lMjdJ+owoJF4rxmkKaUpCou/h+JYj/zaELxMCs1Qz X-Received: by 2002:a17:902:8b88:b0:156:2b14:cb6e with SMTP id ay8-20020a1709028b8800b001562b14cb6emr40543485plb.14.1649807835672; Tue, 12 Apr 2022 16:57:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649807835; cv=none; d=google.com; s=arc-20160816; b=ilDlHadfDH+BIdrV7C5g4cP6IXfbkhqImKFLq2tzJ/1WM2kgkIQShYQ6OwKsEJZ+yz 6Va60cMZh8dYWnNOuKW4LC59uYfW10F7gyoY0DlSHNNhdU1ds1EhsbvdwyjzsOWafpHm +1G5RsPGMdyaZSwLlQ4cbL5Ln3N2xHcsPc/309+i5zA0S3kklZCXrRJt7IKRG45kFtta gjgXUsCxlLoWZsqKahSiwuO24gTrr+lpTOcBJCP/hI0gC0Y8iLoHQqQ2J3dOjSkoILv+ ZLR+PFvs/2xS6LcL5d8NFyNpk+mCBLybPTgH3UaQOUSjv4RA3AFDzj9cS2SxFklYTFJp lQ6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Pp2QlPIqWKu7TF3yRjh0vctAmwroRFTvzsQHgFfgF80=; b=Y28XxmM1w1ugkCfwdCJBqfOe8AuCmPYh8uzL1lJvsmMP8ZH073WcSm3WVzP+3N7D5c EvtLkFPyCk0nCSlI+/8hszSnGXE43rSvBORjkAjxvd0A4WFR21uwBGycImaRB3GGbZgg aO2GW9+3+gvpSoX6AXjLYjumXDjeaCErU2jYdfhTwSbje/LMso8kywGqxJuxCxwPUD9Z /OltYYT4ZDbKISYyQSheyt9HwZRQ42vRzsLQ1kLWAr+3zIqP1LzfuNmph3jas4wVfyup s1jdDrbik5vmI2IM5anP65NLedPd+RsW7xpAUsUQDYu+jFPyFvvtB7vc3m1DZ76N+dTz O9uA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ql95LVOi; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id me8-20020a17090b17c800b001ca89f0563fsi14978203pjb.61.2022.04.12.16.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 16:57:15 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ql95LVOi; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4E7E415CB60; Tue, 12 Apr 2022 14:52:53 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379811AbiDLIU7 (ORCPT + 99 others); Tue, 12 Apr 2022 04:20:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345177AbiDLHbX (ORCPT ); Tue, 12 Apr 2022 03:31:23 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE86150058; Tue, 12 Apr 2022 00:08:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 47248B81B4E; Tue, 12 Apr 2022 07:08:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3A1BC385B7; Tue, 12 Apr 2022 07:08:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649747309; bh=h1/zFxNl/9AODl5mu6g3Vx4iIcbiKVoR2kXvfkVY7UY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ql95LVOiyFF2/zHywtuAjRI5hKez0WuxzvkSpVlZsaWbKO1Q8PrynGrt18cd/kxiS Ek8XTf0nPDuH9pUpTe1XkWg2wYOafxCf696CapApNIPKSO1bndvDz75QsA4h5AAGa1 /tHwrkjoEqGkLQ1Iu0y7TlZFJcTCrPpH2BthYafY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Felix Kuehling , Yang Wang , "Tianci.Yin" , Alex Deucher , Sasha Levin Subject: [PATCH 5.17 033/343] drm/amdgpu: Fix an error message in rmmod Date: Tue, 12 Apr 2022 08:27:31 +0200 Message-Id: <20220412062952.062299541@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220412062951.095765152@linuxfoundation.org> References: <20220412062951.095765152@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tianci.Yin [ Upstream commit 7270e8957eb9aacf5914605d04865f3829a14bce ] [why] In rmmod procedure, kfd sends cp a dequeue request, but the request does not get response, then an error message "cp queue pipe 4 queue 0 preemption failed" printed. [how] Performing kfd suspending after disabling gfxoff can fix it. Acked-by: Felix Kuehling Reviewed-by: Yang Wang Signed-off-by: Tianci.Yin Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index f18c698137a6..b87dca6d09fa 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -2723,11 +2723,11 @@ static int amdgpu_device_ip_fini_early(struct amdgpu_device *adev) } } - amdgpu_amdkfd_suspend(adev, false); - amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE); amdgpu_device_set_cg_state(adev, AMD_CG_STATE_UNGATE); + amdgpu_amdkfd_suspend(adev, false); + /* Workaroud for ASICs need to disable SMC first */ amdgpu_device_smu_fini_early(adev); -- 2.35.1