Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 12 Apr 2022 11:14:03 +0300
From:   Abel Vesa <abel.vesa@nxp.com>
To:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc:     sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V2 2/2] clk: imx8m: check mcore_booted before register clk
Message-ID: <YlU0y9F2VGXsJDzU@abelvesa>
References: <20220228124112.3974242-1-peng.fan@oss.nxp.com>
 <20220228124112.3974242-2-peng.fan@oss.nxp.com>
 <YlU0JRrInWbCiylZ@abelvesa>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YlU0JRrInWbCiylZ@abelvesa>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4pMWS40R1d/IFgQZGeWGuzLEE/l9ibe4YJPtmSfXufh4JgXGWxTd5Sa/lurv?=
 =?us-ascii?Q?Ra4KEGyg7PS1ym1bvd1JoL4GMb0r6qIuS55/1Po8spMg+mZhKWvt4DeqYx5+?=
 =?us-ascii?Q?UDcGYV1n9jXNnnMQjJDBjz0d5JCvvRNRa4BciDlc+OXF8Mv0eqMteW673UXu?=
 =?us-ascii?Q?LiND9g08aTuGrYfoo4J49n7Kf0jX8NZqLnjjemxvcPdh0IIRFH1BrF4PTB/3?=
 =?us-ascii?Q?hwEevBWg7GeYUsUNP8V1kzicAwMV0mOYmcTrezqtyhmGqzCs/0IESO7bUsS9?=
 =?us-ascii?Q?nc2c9GMbhozod8izY+O6MlpYsQzT2ZpYRDk6rirInuZmNcwr85r8MllDt8DA?=
 =?us-ascii?Q?Ytq1qZFqhhAe9jBZNdzDmuQFUehm4Zmap31WHsD19zJq3Zw7wOgnBX5Kktup?=
 =?us-ascii?Q?OlB4yBP/UGyElCHn3crSW26fBKmZpURCBcJErWR8nF1JX62JoottCu7XTCuc?=
 =?us-ascii?Q?vbwTM77Qh1N7JWbIf1vyVwr8I+3m+Ebf2N+KBmLrhi+7Pi9rsqKnwNxbe2pf?=
 =?us-ascii?Q?HwbEzKy2r1aCCObEdXkCXQyi4mbGCYemfM1IERUtTvqex/sW/ALkOIey7G5a?=
 =?us-ascii?Q?aWmsZWdkCEESUjr5JBwq4t6EcJ6PMvULTgLND1+eoti4UlYRUI/ay8mQ27TR?=
 =?us-ascii?Q?FgZ1RAgMuGmg3rvoASbz2wLB266jHzaO1YXvEoCcW0ac5FtBdsG5FRJLDT8i?=
 =?us-ascii?Q?l8b9Uhluk/Ezj+acARz1mXEpYEwlgvScv5tlqiT3PZM55jbVfAraLYnICgoS?=
 =?us-ascii?Q?ON1ZKibaOh3ySsv5IJXkGXlPzb6mB8Z8l9OYr/tV+bedXWq6dzx/QVHsjlaU?=
 =?us-ascii?Q?OkMsSvkx3roEfuENQKMo4BkqUQ7syQPs85SbwuVqRlzbtFulnKGzxknMqDTC?=
 =?us-ascii?Q?dQ8vhWzOPwCfe4n/PwsbJPDh00OltJi4DlHCx3zNZA0Bz1Q1ktVEI4lFiyh7?=
 =?us-ascii?Q?5LA2nRdZS2BqipGbmN6QdF6kHoAyj+cuqo4N1QRNbMGCpyD7c2lvmFT7e2UD?=
 =?us-ascii?Q?OWvDFKWLuStOn23/KtNS4WfQVsO9IjlLXlk9lyuuGui/5JFWVEDCbcmWGsPB?=
 =?us-ascii?Q?TFc/NL9zgLCZAAyFoIBbBt3o+ithKzjO/I8YcJKKnCwvCkMVUtURuOSUANsX?=
 =?us-ascii?Q?SNdhcRGiaJpFN/l4pWz+H/1rOnW8IBydDkBHivFf+u7XDrdiFYleT63mYObt?=
 =?us-ascii?Q?rRngXWYxVWBKn9VUVRvtuYp17vL6jMEp+6T2X5oe9fvGuu70pXY5LUo3b54l?=
 =?us-ascii?Q?a1CSfu+mdno8AoRITB7zvNevbpQELsw2FM/mgLEh5ZNMvn4RhMz43bzXzpbz?=
 =?us-ascii?Q?/Mr4yk3ZiBGgfVKb5LH0Ci0xKiD0PqRwyVGFwo6AmfHB+0VVz0Jg7ENY17RF?=
 =?us-ascii?Q?uGa6m3pW0UqLZT717WZGsmlnuQz7A0vgX3FhvGNnFDv3F9IeBcofETINpSXE?=
 =?us-ascii?Q?lqhM3LK8w/ahnZF0m6y+QvOEvJS6mj+709SeZ7iTuGbxFY8rBTn5jirXkIkp?=
 =?us-ascii?Q?x+mwjF2J+YCZHnZGZELpMXu9lKFnM2b/bidM0KV8fBj22mc/OW5xm2DNCz+q?=
 =?us-ascii?Q?gH20OjZ8wKtM1IFCod/auJr3qftQCzqcaOr7LtD8shBz8d03GChdGuwAIU38?=
 =?us-ascii?Q?c1iIWpCN1X48YmeB6LrMMDhCW9hDNKD9ysjeJSleYdwaXWRMmMIR4Phr+ydt?=
 =?us-ascii?Q?DBxerk/ZvDN2SqkHDwBV7EiRLxFagcbPolMDWpgwnfy7AnKrZkuydOrraKTY?=
 =?us-ascii?Q?S+qyME8iQA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55e9f48d-4b12-41a4-01a5-08da1c5c68bc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 08:14:04.7160
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /TOlm0WcrUS/gxS1lsMUFkRwVZookAJIfYw8X91GE3n8KBaBVktfVYDMdOMBZYWc1UEycyZqjAw964kcIBNWpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3266
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22-04-12 11:11:17, Abel Vesa wrote:
> On 22-02-28 20:41:12, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > If mcore_booted is true, ignore the clk root gate registration and
> > this will simplify AMP clock management and avoid system hang unexpectly
> > especially Linux shutdown clk used by mcore.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > V2:
> >  None
> >
> >  drivers/clk/imx/clk-composite-8m.c | 21 +++++++++++++--------
> >  1 file changed, 13 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/clk/imx/clk-composite-8m.c b/drivers/clk/imx/clk-composite-8m.c
> > index 2dfd6149e528..b16c2c0ea9f6 100644
> > --- a/drivers/clk/imx/clk-composite-8m.c
> > +++ b/drivers/clk/imx/clk-composite-8m.c
> > @@ -223,14 +223,19 @@ struct clk_hw *__imx8m_clk_hw_composite(const char *name,
> >  	div->lock = &imx_ccm_lock;
> >  	div->flags = CLK_DIVIDER_ROUND_CLOSEST;
> >
> > -	gate = kzalloc(sizeof(*gate), GFP_KERNEL);
> > -	if (!gate)
> > -		goto fail;
> > -
> > -	gate_hw = &gate->hw;
> > -	gate->reg = reg;
> > -	gate->bit_idx = PCG_CGC_SHIFT;
> > -	gate->lock = &imx_ccm_lock;
> > +	/* skip registering the gate ops if M4 is enabled */
> > +	if (mcore_booted) {
> > +		gate_hw = NULL;
>
> Lets have the gate_hw set to NULL when declared and get rid of this if
> case.
>

On a second thought, no need to resend, I'll squash this in myself.

> > +	} else {
>
> And then lets do here:
>
> 	if (!mcore_booted) {
> > +		gate = kzalloc(sizeof(*gate), GFP_KERNEL);
> > +		if (!gate)
> > +			goto fail;
> > +
> > +		gate_hw = &gate->hw;
> > +		gate->reg = reg;
> > +		gate->bit_idx = PCG_CGC_SHIFT;
> > +		gate->lock = &imx_ccm_lock;
> > +	}
> >
>
> Would look a bit cleaner this way.
>
> With that done:
>
> Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
>
> >  	hw = clk_hw_register_composite(NULL, name, parent_names, num_parents,
> >  			mux_hw, mux_ops, div_hw,
> > --
> > 2.25.1
> >