Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <d90f37a3-e91a-c2a2-e349-5f835b048e5b@gmx.de>
Date:   Tue, 12 Apr 2022 22:06:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] video: fbdev-MMP: replace usage of found with dedicated
 list iterator variable
Content-Language: en-US
To:     Jakob Koschel <jakobkoschel@gmail.com>
Cc:     linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
References: <20220331223503.902142-1-jakobkoschel@gmail.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220331223503.902142-1-jakobkoschel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 4/1/22 00:35, Jakob Koschel wrote:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
>
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
>
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
>
> Link: https://lore.kernel.org/all/CAHk-=3DwgRr_D8CB-D9Kg-c=3DEHreAsk5SqX=
Pwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>

applied.

Thanks!
Helge

> ---
>  drivers/video/fbdev/mmp/core.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/video/fbdev/mmp/core.c b/drivers/video/fbdev/mmp/co=
re.c
> index 154127256a2c..03707461eced 100644
> --- a/drivers/video/fbdev/mmp/core.c
> +++ b/drivers/video/fbdev/mmp/core.c
> @@ -127,19 +127,18 @@ EXPORT_SYMBOL_GPL(mmp_unregister_panel);
>   */
>  struct mmp_path *mmp_get_path(const char *name)
>  {
> -	struct mmp_path *path;
> -	int found =3D 0;
> +	struct mmp_path *path =3D NULL, *iter;
>
>  	mutex_lock(&disp_lock);
> -	list_for_each_entry(path, &path_list, node) {
> -		if (!strcmp(name, path->name)) {
> -			found =3D 1;
> +	list_for_each_entry(iter, &path_list, node) {
> +		if (!strcmp(name, iter->name)) {
> +			path =3D iter;
>  			break;
>  		}
>  	}
>  	mutex_unlock(&disp_lock);
>
> -	return found ? path : NULL;
> +	return path;
>  }
>  EXPORT_SYMBOL_GPL(mmp_get_path);
>
>
> base-commit: f82da161ea75dc4db21b2499e4b1facd36dab275