Received: by 2002:a05:6512:3d0e:0:0:0:0 with SMTP id d14csp56174lfv; Tue, 12 Apr 2022 17:06:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZGpyNdc1/mIC+jGBO6Bu6g9Sw6A2EWW6zEXqK89z22zrwNIQ/kECS8FSgUhtlySFk2ctm X-Received: by 2002:a63:da4f:0:b0:39d:96b7:6d8 with SMTP id l15-20020a63da4f000000b0039d96b706d8mr4735885pgj.318.1649808399291; Tue, 12 Apr 2022 17:06:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649808399; cv=none; d=google.com; s=arc-20160816; b=kATxHplEF+o0tjPr8Chz6RI8ath2ltTrYNkLhRmxDTKzTZtYndSqJ2DLGtMMBVv57Y hDSsV/TqkOIml3AEDM5b+9RBRUJhBxVyWaiLx66UhsE+3P8HH6PXp99DFQD0ZGMkUr3A cOuvE3wNQVwKxam3FbMa56CEAwcAKzdd3/1TK5znR/0c7kGOdl/x+j4UR6YDQfrAuT9I s5XIPVwzlrf7HBFcuoHlgmhJl8vcNWAuqL3515LkZkFQSg/erAz/uTH3cX81nFGAOpdt FwdMT54dfJ3Dc3YQYKX5l1R/DnzKkJm8oCWE6QF7CTG6FBSB5nxD20+oJ75FE5LNbZqH O25Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=lMFB0InmoR4pDJv6lAsrdPu5Trt63wkiB+MRAm1baLo=; b=1Dj9rMlAqlCkoXB5pJUsQKWL+WDUSI0q1lGbDpLSBk2EkgOE93xDnaf6P1I4vldFtT EGzUa1Gn/WKxBo+HjjutQdgsF0oUNOeShDWsR+CjIjNtrXMg+ZfsJlhOxpmaWk+Nn6zb BT1zFTDkKGNWrg8W9c7pnrwdGC+i9WhEI6TBU4vzi2avFsphAig18xk4S9IG4Lu44Apw Bv9/eWXfr5qfEPP40ksLlltgEW92X4akkWZZFIUkMSnsMMUkFPEYiCM4BQLzy6VBTWtq 3+DKOoTIEzrc9E2QHWL6xrI7vqkzj9klMEb9Wk8DRxs82xtaL5pR/HCf/qysgOBTemCF XMLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=1dZDrF9L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id s28-20020a63451c000000b003816043f12esi3939315pga.803.2022.04.12.17.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 17:06:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=1dZDrF9L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BC84F220309; Tue, 12 Apr 2022 15:03:28 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230340AbiDLU6B (ORCPT + 99 others); Tue, 12 Apr 2022 16:58:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232234AbiDLU5x (ORCPT ); Tue, 12 Apr 2022 16:57:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D5851563DA; Tue, 12 Apr 2022 13:54:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0719EB82027; Tue, 12 Apr 2022 20:42:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46C9AC385A5; Tue, 12 Apr 2022 20:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1649796121; bh=lMFB0InmoR4pDJv6lAsrdPu5Trt63wkiB+MRAm1baLo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1dZDrF9L+F538gzNAjJz9VyO3gg4x+HiTdod5RYW0DmIWGmmunI4/OgjJyFcm9C3I eJeWQ+/r6DqlPyOi1XCg/kgPfZKRZAjNk41oTc+2jGsl4+x6/TMWkU59/I8DEOa5Nn v5RyIjcRhuMBFVO+EDJbPo65siomjZMUDj/79JTc= Date: Tue, 12 Apr 2022 13:41:59 -0700 From: Andrew Morton To: Axel Rasmussen Cc: Alexander Viro , "Dmitry V . Levin" , Gleb Fotengauer-Malinovskiy , Mike Kravetz , Nadav Amit , Peter Xu , Shuah Khan , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 2/2] userfaultfd: selftests: modify selftest to use /dev/userfaultfd Message-Id: <20220412134159.f0a1d0d77f5b01638007bf4b@linux-foundation.org> In-Reply-To: <20220412202942.386981-2-axelrasmussen@google.com> References: <20220412202942.386981-1-axelrasmussen@google.com> <20220412202942.386981-2-axelrasmussen@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Apr 2022 13:29:42 -0700 Axel Rasmussen wrote: > Prefer this new interface, but if using it fails for any reason just > fall back to using userfaultfd(2) as before. This seems a poor idea - the old interface will henceforth be untested. Why not tweak the code to test both interfaces?