Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220411205321.13109-1-mahak_g@cs.iitr.ac.in> <c5fc1685-b1cc-7cfa-1ddd-e2f93105c2a5@intel.com>
 <027acae3-29ee-ae35-4448-a56e66383849@lwfinger.net>
In-Reply-To: <027acae3-29ee-ae35-4448-a56e66383849@lwfinger.net>
From:   MAHAK GUPTA <mahak_g@cs.iitr.ac.in>
Date:   Wed, 13 Apr 2022 02:59:39 +0530
Message-ID: <CANnaPbBpWmp3PUgp=yRxhykzKjpP1HHh9Fk0aEBJ_+EGNUStvA@mail.gmail.com>
Subject: Re: [PATCH] staging: r8188eu: correct multiple misspellings in driver r8188eu
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     Dave Jiang <dave.jiang@intel.com>,
        Phillip Potter <phil@philpotter.co.uk>,
        gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Apr 12, 2022 at 10:48 PM Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
> On 4/11/22 16:28, Dave Jiang wrote:
> > Subject:
> >
> > staging: r8188eu: fix multiple spelling errors in driver source
> >
> > Given that it already annotated that it's the r8188eu driver, no need to add "in
> > driver r8188eu".
> >
> > Maybe the log can be something less terse:
> >
> > Fix multiple spelling errors reported by checkpatch.
> >
> >
> > Probably doesn't hurt to fix other issues on the same line while you are at it.
> > See below...
>
> Wrong on the first and last points. That subject is exactly what should be used
> - it describes what is being modified.
>
> A given patch should fix one, and only one, problem.
>
> Yes, the commit message could be less terse, but that is not a problem.
Ok so considering the last comment, I am sending version 2 of this
patch with an appropriate commit message.
>
> Larry