Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 11 Apr 2022 15:36:48 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>,
        intel-gfx@lists.freedesktop.org,
        intel-gvt-dev@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 28/34] drm/i915/gvt: convert to use
 vfio_register_emulated_iommu_dev
Message-ID: <20220411183648.GA2120790@nvidia.com>
References: <20220411141403.86980-1-hch@lst.de>
 <20220411141403.86980-29-hch@lst.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220411141403.86980-29-hch@lst.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lfPWxE6Kmfhgyz285N/nqsE58HorXpdceyTIf5CDLUBngvc8+KTTmFo/UUxa?=
 =?us-ascii?Q?lWd3bIRVRxifIL+ED39w63vdbJKuOpbpB1lzNTCHotZz6r19dKEMHH9i7Sq8?=
 =?us-ascii?Q?XdaMRarFeyNijHCdyFub7cW18ViqwK8ABeUYKL+Bf0m2IeVDW8wiDkObY7rE?=
 =?us-ascii?Q?zQu3ewRp4yyEIkxgaG5uHGndsyV8ftXA+HM5RC9PiWDkx15bccyxLhVZhEtA?=
 =?us-ascii?Q?RSA/jhMZdSfHFVLZ5DVCZRA/fakL6nN0eQrSP82mwn9DgydMl5UsoeFUtQVV?=
 =?us-ascii?Q?F+cmUVgBuCnB2Cc61s/ODiioFEmqqAo2tRiD7AUK5Ek7rOVVlm3QBuQ46iOa?=
 =?us-ascii?Q?tThTnMabLl6HZHuem0Rl7BjjsYSuPaoqHc/mFX/Vw9p39OiTVxL3RC0SNrLE?=
 =?us-ascii?Q?V4MxFxqw1arLTTkqSYE6n1lJExLdsLnsr1DFPDUIsujdjMMEgTfO3IIAl9wB?=
 =?us-ascii?Q?OeYwKeRbNndf/tMcUhVRQey8jQM92UapBlDfo6WH+/Xakhx11STw74wnG0mP?=
 =?us-ascii?Q?41UU+mXgrZIivcRheCl0doyQQvKVfxHrCjw/JHQ+nIyQJzyWkaElWBP6lZVw?=
 =?us-ascii?Q?U6Vj/LMblDHt3i5t1D1MQbgbo2fDNjOCgz56EAaoZtMiXl1pq/v4WT5iEVIj?=
 =?us-ascii?Q?0gYSmuoIXujDcWvYDL2GI2IFhZ8SYsS3Dv4y/zBa3bzp+CYAl++GtPZWyJKX?=
 =?us-ascii?Q?BW4v7JwJNCFBwYbNsXW7fu0DV3PdAZUpA82Q0YhosS0qok/hUcNXCcv4+y25?=
 =?us-ascii?Q?P4nrihczXu69lIsqiGnh1ocNBlruOfRJO9KIJYp9INA7V/KfUNuZDLb6APVH?=
 =?us-ascii?Q?r9L2Jfzl5DCKzyKu9RseGL5aZwuPxuFltfxueE9Ji0NwU4RW2gNvEfr3H5M0?=
 =?us-ascii?Q?4Ae76qyRBvN6jAz/T4GwyjN0toraKXa8rkro7c9llfaJ3Uk+oWckLltN1QRO?=
 =?us-ascii?Q?OY2QGqMt1JrhAYB2iffSnpGoIR7G5YK621DtL4DHA+8ks0OcQwyUJT1vNP2J?=
 =?us-ascii?Q?dMr2TtTFq3FcAitBvQijAKKs1X5Y2hMBr8RuAf5oFYmnQJxlEgeKclfoMBfd?=
 =?us-ascii?Q?E82o+1E+FlJd4qx7CTa84VXJBOQfZpHCt/UPVS2AUmviYhQ5cgDEavYqR8mx?=
 =?us-ascii?Q?MkgjkBOsH3YNxzORXDEReGc/MmAiMzDO9UHmUa/i2tR1WTGReuVuaIXGCWCl?=
 =?us-ascii?Q?jQMlkmVJPoG+t4nzg+QDHmiM5587VOR1NVUFnLS6bTukfaHBcEKXZuVKL5Iz?=
 =?us-ascii?Q?Dpormt9yYku/XtIZnO/qx1n3GhOE4zwd7y/k/Wc1aTsM/xmuil162wYh6HLf?=
 =?us-ascii?Q?oh4gecACjcebOg0t+WTzDxxkmnRsIxP+e1x3pcOiAYuaVoxrotqFVOrwyhqH?=
 =?us-ascii?Q?9vLx3pl52fNEq4Atfkt8+xX5UU3d1ANsoWifgF8Ot3WCLKrN4U6+MhProZAX?=
 =?us-ascii?Q?q26U7Iyo53MP/+jPf5Bt0p4oBmxag37CAM3o0sQXY3X+FsjVs/bybpGGbs7X?=
 =?us-ascii?Q?K/9j0PTHBMr1bdGhMUyiaHpYsMWwWtkUNmOUADYSDcXzwlQdtslIC0FIaOnG?=
 =?us-ascii?Q?1JLl2j0GjiT9oumi5qp0C5N0mxJHnPZG1vHqmxloZgDndbjrqSrS2oYDwNOF?=
 =?us-ascii?Q?Cu3lCFIAjz5PPcrc1d6INykCHBydPy9vC+mDz/RAafabeJ1kIJXI8elBXF1r?=
 =?us-ascii?Q?xhHw5JQpJsDpu43ar43B8oYcy0l/bnOPKZ4Uja83OZL22+4p44Opru6J/Ns6?=
 =?us-ascii?Q?lNLfHs8SDw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95414e2d-8466-4d73-0d19-08da1bea3d7b
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2022 18:36:49.5668
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RrZDsH1uL6PCDef/RFH2DvT7CvghAJ89v69jOzlZoItz017HmLWDr6KdG9/BTQkM
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1824
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 11, 2022 at 04:13:57PM +0200, Christoph Hellwig wrote:

> -static int intel_vgpu_create(struct mdev_device *mdev)
> -{
> -	struct device *pdev = mdev_parent_dev(mdev);
> -	struct intel_gvt *gvt = kdev_to_i915(pdev)->gvt;
> -	struct intel_vgpu_type *type;
> -	struct intel_vgpu *vgpu;
> -
> -	type = &gvt->types[mdev_get_type_group_id(mdev)];
> -	if (!type)
> -		return -EINVAL;
> -
> -	vgpu = intel_gvt_create_vgpu(gvt, type);
> -	if (IS_ERR(vgpu)) {
> -		gvt_err("failed to create intel vgpu: %ld\n", PTR_ERR(vgpu));
> -		return PTR_ERR(vgpu);
> -	}
> -
> -	INIT_WORK(&vgpu->release_work, intel_vgpu_release_work);
> -
> -	vgpu->mdev = mdev;
> -	mdev_set_drvdata(mdev, vgpu);
> -
> -	gvt_dbg_core("intel_vgpu_create succeeded for mdev: %s\n",
> -		     dev_name(mdev_dev(mdev)));

nit: the debug print has the wrong function name now

Rest looks OK

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason