Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 12 Apr 2022 00:18:13 -0400
From:   Jaehee Park <jhpark1013@gmail.com>
To:     =?iso-8859-1?B?Suly9G1l?= Pouiller <jerome.pouiller@silabs.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Stefano Brivio <sbrivio@redhat.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        outreachy@lists.linux.dev,
        Alison Schofield <alison.schofield@intel.com>
Subject: Re: [PATCH v2] staging: wfx: use container_of() to get vif
Message-ID: <20220412041813.GA2860081@jaehee-ThinkPad-X1-Extreme>
References: <20220408032349.GA2132476@jaehee-ThinkPad-X1-Extreme>
 <Yk++AMDTu7LCbjHu@kroah.com>
 <20220408074424.6e862f3f@elisabeth>
 <2419031.jE0xQCEvom@pc-42>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2419031.jE0xQCEvom@pc-42>
Precedence: bulk

On Sat, Apr 09, 2022 at 04:07:12PM +0200, J?r?me Pouiller wrote:
> On Friday 8 April 2022 07:44:24 CEST Stefano Brivio wrote:
> > On Fri, 8 Apr 2022 06:45:52 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > > On Thu, Apr 07, 2022 at 11:23:49PM -0400, Jaehee Park wrote:
> > > >
> > > > [...]
> > > >
> > > > @@ -61,7 +63,6 @@ struct wfx_dev {
> > > >
> > > >  struct wfx_vif {
> > > >     struct wfx_dev             *wdev;
> > > > -   struct ieee80211_vif       *vif;
> > >
> > > You need to test this on real hardware.  For an outreachy-first-task,
> > > this is not a good one at all.
> > 
> > We discussed about this on the outreachy list, and I suggested, as
> > Jaehee also mentioned, that maybe somebody (J?r?me?) with the hardware
> > could give it a try.
> >
> > It looks a bit difficult but it also looks almost correctly done now. :)
> 
> Absolutely.
> 
> I will test it once the various comments will be fixed.
> 
> 
> -- 
> J?r?me Pouiller
> 
>
I just wanted to update and let you know that I mailed a new patch v3 just now.
Thanks!