Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <157cb46a-d134-2e72-4a65-14e378dd2b8e@oracle.com>
Date:   Tue, 12 Apr 2022 18:35:27 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH RESEND 1/1] lib/Kconfig: remove DEBUG_PER_CPU_MAPS
 dependency for CPUMASK_OFFSTACK
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>, gregkh@linuxfoundation.org,
        masahiroy@kernel.org, tglx@linutronix.de, peterz@infradead.org,
        mingo@kernel.org, vbabka@suse.cz, akpm@linux-foundation.org
Cc:     linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org
References: <20220412231508.32629-1-libo.chen@oracle.com>
 <20220412231508.32629-2-libo.chen@oracle.com>
 <c7d26e9d-8c70-86a6-cdab-b180a365804f@infradead.org>
From:   Libo Chen <libo.chen@oracle.com>
In-Reply-To: <c7d26e9d-8c70-86a6-cdab-b180a365804f@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXZHMFpTRTMwRlRhZWlRWlZkdTMzVFRldVJIZjRpcXg0TENoTW4vaUFvWkl4?=
 =?utf-8?B?Z0hBdGZOK1Urb0NmeEk2WEZya3ArUkRkMWxKRmlvOVhXTEt0M2ljanFVK0tv?=
 =?utf-8?B?WWQvTVNENkV2L3NMQm5qZlMrVkJtNTNEZXZORGp1M01mMjVCUDZOTDB5eGZO?=
 =?utf-8?B?MGJRN1dYNjVqWU5SNDEzZldhOHgxVDZQUGo5Z0FybEtRUCtTU3p5STFnN3Zy?=
 =?utf-8?B?NGgzRWxBU09za1MzM3YxOHdPUDJLWktOdDFsU0xYQnhSTVkwSEIvLzFHajdN?=
 =?utf-8?B?QlB6WXgrdVI4SitoQmozWWpWNTk5S1YzVTdXQlBhemVrZGpvMHlMV1dDRUx5?=
 =?utf-8?B?bjdDbzFVTUNUYVRNVGY5QldJaTRjNGlGRzE0d1JsWFllWm96TjhFMDFlMklr?=
 =?utf-8?B?T0NzY3B0bXVNNHpmQzUrby9IUnFaSjJhZkRpNHVZZFROeFNxSjJUOXJDVUU5?=
 =?utf-8?B?Qzk2aVdjblJFSno3NmQ0QzRSMmdORUE2cXBhczVoNDBoejdndVE5d2hJUlFh?=
 =?utf-8?B?R29tQ2xhd3lFQUw2SXVnQTF1RUhUSzQ2V3hUb1ZtanQvUTNhZlF5L01vRzFP?=
 =?utf-8?B?RzAxaW9PbFlZSjlBL244MFk5ZEtkcGt4QzFuSVVXZVV2b21yR1BEUFp3ZDk3?=
 =?utf-8?B?N2RuVDAyQ002bjRLZU5WbWpvLzhsT25hTkM4T2FjbDVHOVhoL1V4V3ZJbCtl?=
 =?utf-8?B?dEtKMHVaemlFVjV6RmtuUE5CUGxZUzc2aVFTbmszWmVvVmt6aVZWQVMvWXkz?=
 =?utf-8?B?em4yWVkxZnZvN1B2NERFZnlMU09zOE5LQ0hET2lIMGVCU2dHWjFGY3E0R2hy?=
 =?utf-8?B?aldvaW5ocEtoWjJDNlVBOC8vV1BvTVdFNzFMYmNRc3JoSWlwMlVheHBNLzZx?=
 =?utf-8?B?cFBBWXMyWmxtOU9jcEVPdHY5NHdWanFvQ1daaEN4VHdxaXVyOElIMGc0OWhC?=
 =?utf-8?B?cndadTg2QjVaN1BpL1gvTVNYVlo2dDdJY2c5UERhTWltRit5MVZIUE9vbUNm?=
 =?utf-8?B?NDI1VWJ5NmZNaUthWXIxRlBPUHRybnF4bjFkUzhlNVJzUExNS3ZqQ1RUSDI1?=
 =?utf-8?B?NE9xcFVSQ3RlL0EyOXFQc2NUWFN4TjQ0OHNSK2RzMXhQQklGWm5GdWJpRjRl?=
 =?utf-8?B?QVdMY0VKMEsyOHhGYlkvRFFyeVFadnRpNmdpOXJCRE5ZTFJnNlVnWjczU2Q5?=
 =?utf-8?B?UXpwNnVrcjh6VTV4US84NFB3WGd1R0VsTTd4UWlBcTc1WTB2UzhDM0ZwOFdR?=
 =?utf-8?B?MmY1STY1Z3I5bXVQbTcvSEp5Qk4wM1RJMWhaS1NzTTBkNHFTaDNDMEZvMklR?=
 =?utf-8?B?QkJSSnZTajdTUStURFd0VWZ2dGVKNWFvdVJCTmM0RVBCemFTb0lybWhTeHdk?=
 =?utf-8?B?TUZQWHhVZG05M0s5ZlRRNThldThlUjFiY0NuV1RkWldLWlVBVFZjRFhYbWFJ?=
 =?utf-8?B?T1hYSGsvdXpSRm9OTU0zVGxVVWhWaUVsbnhHZjVTZTFNZFNsUkdmNnc2Tlhv?=
 =?utf-8?B?RDVwZXo3ZVFRek9IYk5pekVYazFVZ0V6T1RrRFYzVXB0eG8wNDA3KytKemFk?=
 =?utf-8?B?YVV3c2RpdytHelJUeVZFZnhudjJOdkhOYlV6cE5OcUg5UjF1b1VkZ1FwYnJG?=
 =?utf-8?B?dWYyWDlLanRjN2diTThqVW9sMi9JUk1kWTVtZGxJTXBWWUtUbzd6U0FXUit5?=
 =?utf-8?B?ZmpFNDY0RjJQbXY3WVNlVzR2SVlidmpaeDhKM21kMkFBQXk0VE83VDR3bWVX?=
 =?utf-8?B?NjE5NDBwTXNhOTM5NStuaHFMNlZBbG1obEJCc2xnaENyYWVlT003T3JtdWp3?=
 =?utf-8?B?akN1aTdmcEdBNDJBWFYvcVZPNGxRYnhjZkFnNFBwWFZCb3JxcDVWZUZUSThI?=
 =?utf-8?B?NkdxRTIwSkRla0J5VlpOaHVpcFFFaUVUZnAySjAzZEV0b2dDTTd2TlI3U0NP?=
 =?utf-8?B?RUt1M0c5Z0g0RGV5RmFKUmpFSTh6QkRBV29HOFUvMjBkWWEydlduMjhFV0c2?=
 =?utf-8?B?Vm5YKzNTWlN3YmFNVDlTYjVaNHMrQWJPSkVJUURvcDNrVFY1TU1pSHgxc0pL?=
 =?utf-8?B?N2t3YXJHeVNPVk10MnV3U2dkZm9MMjR2YnZ6WFZsMnhrRzBOdHhCU3htVklW?=
 =?utf-8?B?OTFrUGNKUWVLS2R0T3M5dkk1QVR2T01CVWJqbW9Iei9nVXJCby9OdHZmbzdU?=
 =?utf-8?B?Sjgxc0VvTFpWMEdXWVZudTJhanE0MkVoUUJGZ1VMU005NXB5eGRRS3B0b29P?=
 =?utf-8?B?TTViSUdSSUJaQy9nS0hmVEVhWUZDQmljcEt6NDRZVUQyaFJ2azN5dFQzS0Fx?=
 =?utf-8?B?cTdwR1Q4MFhDa28vTGdBVGRleXhPSFlDRHA3Y29Sa1psUHRmSjZmRFE1WFkv?=
 =?utf-8?Q?wAPTHUIu/GtBak9irCu/dg8PeC3T+I4OyqtcO612hhsxI?=
X-MS-Exchange-AntiSpam-MessageData-1: b7Qk62Ux3zZ8pw==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57107e02-717d-4492-a09a-08da1cede5ef
X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4569.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 01:35:32.1389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dq42s97iCitBcIBZybUnjCI0TCNKMzxQOOiTSmG8kjw9AOvXw/nXFcpmE/+RSR6iLuAuOgp9c+8w0DMLzz+QCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2932
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-12_06:2022-04-11,2022-04-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=999 spamscore=0 adultscore=0 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204130007
X-Proofpoint-ORIG-GUID: z3sY3gTZnr6OkhfkXx5sSRTCZ_7U7QPF
X-Proofpoint-GUID: z3sY3gTZnr6OkhfkXx5sSRTCZ_7U7QPF
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Randy,

On 4/12/22 17:18, Randy Dunlap wrote:
> Hi--
>
> On 4/12/22 16:15, Libo Chen wrote:
>> Forcing CPUMASK_OFFSTACK to be conditoned on DEBUG_PER_CPU_MAPS doesn't
>> make a lot of sense nowaday. Even the original patch dating back to 2008,
>> aab46da0520a ("cpumask: Add CONFIG_CPUMASK_OFFSTACK") didn't give any
>> rationale for such dependency.
>>
>> Nowhere in the code supports the presumption that DEBUG_PER_CPU_MAPS is
>> necessary for CONFIG_CPUMASK_OFFSTACK. Make no mistake, it's good to
>> have DEBUG_PER_CPU_MAPS for debugging purpose or precaution, but it's
>> simply not a hard requirement for CPUMASK_OFFSTACK. Moreover, x86 Kconfig
>> already can set CPUMASK_OFFSTACK=y without DEBUG_PER_CPU_MAPS=y.
>> There is no reason other architectures cannot given the fact that they
>> have even fewer, if any, arch-specific CONFIG_DEBUG_PER_CPU_MAPS code than
>> x86.
>>
>> Signed-off-by: Libo Chen <libo.chen@oracle.com>
>> ---
>>   lib/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/Kconfig b/lib/Kconfig
>> index 087e06b4cdfd..7209039dfb59 100644
>> --- a/lib/Kconfig
>> +++ b/lib/Kconfig
>> @@ -511,7 +511,7 @@ config CHECK_SIGNATURE
>>   	bool
>>   
>>   config CPUMASK_OFFSTACK
>> -	bool "Force CPU masks off stack" if DEBUG_PER_CPU_MAPS
> This "if" dependency only controls whether the Kconfig symbol's prompt is
> displayed (presented) in kconfig tools. Removing it makes the prompt always
> be displayed.
>
> Any architecture could select (should be able to) CPUMASK_OFFSTACK independently
> of DEBUG_PER_CPU_MAPS.
Do you mean changing arch/xxxx/Kconfig to select CPUMASK_OFFSTACK under 
some config xxx? That will work but it requires code changes for each 
architecture.
But if you are talking about setting CONFIG_CPUMASK_OFFSTACK=y without 
CONFIG_DEBUG_PER_CPU_MAPS directly in config file, I have tried, it 
doesn't work.

Libo
> Is there another problem here?
>
>> +	bool "Force CPU masks off stack"
>>   	help
>>   	  Use dynamic allocation for cpumask_var_t, instead of putting
>>   	  them on the stack.  This is a bit more expensive, but avoids