Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Subject: Re: [PATCH net-next v3 14/18] sfc: Remove usage of list iterator for
 list_add() after the loop body
From:   Jakob Koschel <jakobkoschel@gmail.com>
In-Reply-To: <20220412142905.54489567@kernel.org>
Date:   Wed, 13 Apr 2022 10:18:28 +0200
Cc:     "David S. Miller" <davem@davemloft.net>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        UNGLinuxDriver@microchip.com, Ariel Elior <aelior@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        Edward Cree <ecree.xilinx@gmail.com>,
        Martin Habets <habetsm.xilinx@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Jiri Pirko <jiri@resnulli.us>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Casper Andersson <casper.casan@gmail.com>,
        Bjarni Jonasson <bjarni.jonasson@microchip.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Michael Walle <michael@walle.cc>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Colin Ian King <colin.king@intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Eric Dumazet <edumazet@google.com>,
        Di Zhu <zhudi21@huawei.com>, Xu Wang <vulab@iscas.ac.cn>,
        Netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
        bpf@vger.kernel.org, Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
Content-Transfer-Encoding: 7bit
Message-Id: <132EC4A3-4397-4124-B736-0C3057B63B26@gmail.com>
References: <20220412121557.3553555-1-jakobkoschel@gmail.com>
 <20220412121557.3553555-15-jakobkoschel@gmail.com>
 <20220412142905.54489567@kernel.org>
To:     Jakub Kicinski <kuba@kernel.org>
Precedence: bulk


> On 12. Apr 2022, at 23:29, Jakub Kicinski <kuba@kernel.org> wrote:
> 
> On Tue, 12 Apr 2022 14:15:53 +0200 Jakob Koschel wrote:
>> -	struct list_head *head = &efx->rss_context.list;
>> +	struct list_head *head = *pos = &efx->rss_context.list;
> 
> ENOTBUILT, please wait with the reposting. Since you posted two
> versions today I guess that's 2x 24h? :)

oh gosh, seems like I indeed forgot to build this commit.
Sorry about all the mess :( Also I'll wait with reposting (not
going to make the same mistake twice ;)).

I messed up three times yesterday, was really not on a high.
I'll be more careful in the future to not the the same kind of
mistakes again :/