Received: by 2002:a05:6512:3d0e:0:0:0:0 with SMTP id d14csp346880lfv; Wed, 13 Apr 2022 05:28:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwppSsfV+W4iv3xO5up44djHKAJQxzg9FC34FU0icHjs/re4IpZW2knin9iivQhST8Njc0 X-Received: by 2002:a17:906:b6c7:b0:6db:2e14:875 with SMTP id ec7-20020a170906b6c700b006db2e140875mr38651445ejb.737.1649852925136; Wed, 13 Apr 2022 05:28:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649852925; cv=none; d=google.com; s=arc-20160816; b=iTK2Ct8FE8h5iX4/FVX12DSKsBPMwRD9QhkaANS7AAO1W/bclzhlhfmBGtqBOM369N N8k+0E5msTE617u2HR98CDVyNwjGJPi/feiqLtbKx+w8pvpryNXh2RWr7NtR2LxzAdov CrMyM+Y34911Oir7wXk7UY6Jr9ajzRAEdc/U46SYr9uUxaeJ9K37xYeJT6XC5zDSFv+K /CZbZHuxabqndazrV37LJsh1WVRIThlSsntdTyquB8rkQIaRdBIdXvilAXU73N1fPTHg 301c0JCmUogG1N00VqijRuYycKgkWktEz1yNAS+3plTZnwuKL/Unh3XCJLYsgt9d+kmC FYjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ubrOMCuCWdPaEr8ezLG4U26TNWFJPZgVZe6an8+lYVc=; b=kq3PyBZG02gxEKKKkIlHX4hVD/D2cBG2JlOv5X5Bzcd+N7OS5SfkBnAt2Puex3U4Se C7igGhSrm16KOAKsUR9c3bzUc1QAP8zXRsN7EQ/yj8+vasEO7+dIUFUD0Y82YmqMMjyO pHpua5sDv1iQkMhYchT6nug+Ud5wc0MguhBjujzHzHugEhB4yP9+ZJ2WCXZ/MfjdrWey gVetfyTwNN1+azbNkHOJw6nvUMwybDjBKyo60SmxSp9KDjlAejsnWjKtDydyYYY7bJoC 1bZN640vMfOm7pS9CbZvjbM9wZiCYtV5YZOn9BtTkwareL31f4qpyiKsOO3hxGcLb6cb /5eA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hq27-20020a1709073f1b00b006e89ef44c42si6867034ejc.366.2022.04.13.05.28.20; Wed, 13 Apr 2022 05:28:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235032AbiDMK70 (ORCPT + 99 others); Wed, 13 Apr 2022 06:59:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232020AbiDMK7Z (ORCPT ); Wed, 13 Apr 2022 06:59:25 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 86D1C5A163; Wed, 13 Apr 2022 03:57:04 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 527B51595; Wed, 13 Apr 2022 03:57:04 -0700 (PDT) Received: from e123427-lin.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C11093F73B; Wed, 13 Apr 2022 03:57:02 -0700 (PDT) From: Lorenzo Pieralisi To: Johan Hovold , Stanimir Varbanov , Andy Gross , Bjorn Andersson Cc: Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Bjorn Helgaas , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , linux-kernel@vger.kernel.org, Rob Herring Subject: Re: [PATCH v2] PCI: qcom: Fix pipe clock imbalance Date: Wed, 13 Apr 2022 11:57:01 +0100 Message-Id: <164984714583.9020.940270907096326400.b4-ty@arm.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220401133351.10113-1-johan+linaro@kernel.org> References: <20220401133351.10113-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Apr 2022 15:33:51 +0200, Johan Hovold wrote: > Commit ed8cc3b1fc84 ("PCI: qcom: Add support for SDM845 PCIe > controller") introduced a clock imbalance by enabling the pipe clock > both in init() and in post_init() but only disabling in post_deinit(). > > Note that the pipe clock was also never disabled in the init() error > paths and that enabling the clock before powering up the PHY looks > questionable. > > [...] Applied to pci/qcom, thanks! [1/1] PCI: qcom: Fix pipe clock imbalance https://git.kernel.org/lpieralisi/pci/c/dcd9011f59 Thanks, Lorenzo