Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Apr 2022 08:16:20 +0200 (CEST)
From:   Julia Lawall <julia.lawall@inria.fr>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
cc:     johan@kernel.org, Jaehee Park <jhpark1013@gmail.com>,
        elder@kernel.org, gregkh@linuxfoundation.org,
        greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH v2 2/2] staging: greybus: remove unneeded return
In-Reply-To: <5792471.alqRGMn8q6@leap>
Message-ID: <alpine.DEB.2.22.394.2204130815020.3470@hadrien>
References: <cover.1649793138.git.jhpark1013@gmail.com> <d4d01ecdabc492e52a3decebf165d1f584f3b3bf.1649793138.git.jhpark1013@gmail.com> <5792471.alqRGMn8q6@leap>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-929786816-1649830581=:3470"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-929786816-1649830581=:3470
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT


On Tue, 12 Apr 2022, Fabio M. De Francesco wrote:

> On marted? 12 aprile 2022 21:59:15 CEST Jaehee Park wrote:
> > An empty function with void return type does not need an explicit
> > return. Issue found by checkpatch.
> >
> > Signed-off-by: Jaehee Park <jhpark1013@gmail.com>
> > ---
> >  drivers/staging/greybus/audio_codec.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/
> greybus/audio_codec.c
> > index 0f50d1e51e2c..3e3a16568def 100644
> > --- a/drivers/staging/greybus/audio_codec.c
> > +++ b/drivers/staging/greybus/audio_codec.c
> > @@ -1032,7 +1032,6 @@ static int gbcodec_probe(struct snd_soc_component
> *comp)
> >  static void gbcodec_remove(struct snd_soc_component *comp)
> >  {
> >  	/* Empty function for now */
> > -	return;
> >  }
> >
> >  static int gbcodec_write(struct snd_soc_component *comp, unsigned int
> reg,
> > --
> > 2.25.1
> >
> Hi Jaehee,
>
> If I recall it correctly, Dan Carpenter suggested to remove this empty
> function.
>
> When developers remove lines of code from a function which becomes empty
> after the removals, they also remove the resulting empty function and
> delete all the calls (if there are any left) at the same time.

It's probably not relevant in this case, but the function could be needed
if it is a branch of an ifdef.  Also if it is stored in a structure field
and the user of the structure does not check for NULL.

julia
--8323329-929786816-1649830581=:3470--