Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Apr 2022 16:24:51 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     Kishon Vijay Abraham I <kishon@ti.com>,
        Tony Lindgren <tony@atomide.com>,
        linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] phy: mapphone-mdm6600: Fix PM error handling in
 phy_mdm6600_probe
Message-ID: <Ylar+x3fI9DpmeKB@matsya>
References: <20220105123947.17946-1-linmq006@gmail.com>
 <20220301024615.31899-1-linmq006@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220301024615.31899-1-linmq006@gmail.com>
Precedence: bulk

On 01-03-22, 02:46, Miaoqian Lin wrote:
> The pm_runtime_enable will increase power disable depth.
> If the probe fails, we should use pm_runtime_disable() to balance
> pm_runtime_enable(). And use pm_runtime_dont_use_autosuspend() to
> undo pm_runtime_use_autosuspend()
> In the PM Runtime docs:
>     Drivers in ->remove() callback should undo the runtime PM changes done
>     in ->probe(). Usually this means calling pm_runtime_disable(),
>     pm_runtime_dont_use_autosuspend() etc.
> 
> We should do this in error handling.

Applied, thanks

-- 
~Vinod