Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Apr 2022 16:49:41 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     German Gomez <german.gomez@arm.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
        James Clark <james.clark@arm.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf report: Set PERF_SAMPLE_DATA_SRC bit for Arm SPE
 event
Message-ID: <20220413084941.GB521036@leoy-ThinkPad-X240s>
References: <20220413075124.635589-1-leo.yan@linaro.org>
 <c21b3409-a8a0-aae7-7634-5e648f0a49b1@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c21b3409-a8a0-aae7-7634-5e648f0a49b1@arm.com>
Precedence: bulk

On Wed, Apr 13, 2022 at 09:15:40AM +0100, German Gomez wrote:

[...]

> >  	if (sort__mode == SORT_MODE__MEMORY) {
> > +		/*
> > +		 * FIXUP: prior to kernel 5.18, Arm SPE missed to set
> > +		 * PERF_SAMPLE_DATA_SRC bit in sample type.  For backward
> > +		 * compatibility, set the bit if it's an old perf data file.
> > +		 */
> > +		evlist__for_each_entry(session->evlist, evsel) {
> > +			if (strstr(evsel->name, "arm_spe_") &&
> 
> This didn't work for me when the file recorded "-e arm_spe//" instead of
> "-e arm_spe_0//". Could you remove the trailing _? With that:

Sure, will change to "arm_spe".  Just curious, if there any local
change at your side so we have the different event name?

> Tested-by: German Gomez <german.gomez@arm.com>

Thanks a lot, German!

Leo