Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a2731b2d77f9bf2adf36f0c05cb5e3b14a5a91a9.camel@nxp.com>
Subject: Re: [PATCH v6 resend 2/5] phy: Add LVDS configuration options
From:   Liu Ying <victor.liu@nxp.com>
To:     Vinod Koul <vkoul@kernel.org>
Cc:     linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org, kishon@ti.com,
        robh+dt@kernel.org, andrzej.hajda@intel.com,
        narmstrong@baylibre.com, Laurent.pinchart@ideasonboard.com,
        jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie,
        daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        agx@sigxcpu.org, robert.chiras@nxp.com, martin.kepplinger@puri.sm,
        robert.foss@linaro.org
Date:   Wed, 13 Apr 2022 20:39:41 +0800
In-Reply-To: <YlaqwoFCfusFgIIe@matsya>
References: <20220402052451.2517469-1-victor.liu@nxp.com>
         <20220402052451.2517469-3-victor.liu@nxp.com> <YlZpnrKt9NbHZv26@matsya>
         <d77b41d911e126331138ddaca146a581d316bd09.camel@nxp.com>
         <YlaqwoFCfusFgIIe@matsya>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFJkOGpxWU4yQ2hGRHpvNVZoTlNVNDhzNzdZcGVhWS9PYjdDeEVCdmg5dW5o?=
 =?utf-8?B?ZDFPYWdtY1ZxRkV0YWhBbzNrTk9Ba2wxR0pPUlgvRG1pRDVVZkg4bWNVb3Ri?=
 =?utf-8?B?MWpzMlJGNDJ1QVY0T21NVHRaV3FIOUJmUWhleklNRzZYK0VPcitmTEROM25m?=
 =?utf-8?B?R09lNFFyNmN5dU5NZ0xWUXI0bm1XUEtZZk1UK0hQM1lEM05ZZDhVbGpPSVEr?=
 =?utf-8?B?M1NiRnVWd3luNUFHOGRiRVJnaFR1MFhYaEd0K0NPUUl3WWRlNEMwUXdzSnY1?=
 =?utf-8?B?OHF2YmhUS0FYLzJOdS9GSUF1NjR4d0ZlQXBOdjdPNHpIRUp0dE1hN0VMdzBI?=
 =?utf-8?B?OFJrWDhERGJaazNVRnE0czZ4emZEUUw0NGFsYnpGeEJmTTBnblJIaWFrd2RN?=
 =?utf-8?B?Qmw4ekNrK3R2TTg3TEpyS0NvNElXa2NKOU0yWGQwamZpeG14N01OcmljN1JB?=
 =?utf-8?B?aFRmT3ZxRlMzd1Z6eUlCdmcraUUyNDNRNko1M1pEdG1veEt2eGhuL0xuQnA2?=
 =?utf-8?B?b3Via0hyVE9YdUlQS1IzTXVObGdENEE3OWM1U0I5TlNZTzlrWktSWTI5MkJr?=
 =?utf-8?B?S2RiU21XRlI5Z3hEUWx5RDRDOElkUGU3b0dmdkp6V3prL0Z2WkdaN3p0dlN2?=
 =?utf-8?B?ak5ZOUlIbFVkc3JKbUlWZTdqT1JGQzJRNEFNcmNScWpsVFBRdjNjUTZHa3Bm?=
 =?utf-8?B?c0ZaaC9rL0tVYi9VNDdaKzlJd0NjUW1Oc1kxU1VlZjJhNENLWG90NGQxMnQ4?=
 =?utf-8?B?bGdlWnhiWlRqa2w5R0VSNlZYQ0NBdGszSlh0dGZZaldWeHdIK0Z0TlRBaG1l?=
 =?utf-8?B?cXVLSUsvczlGamFrME9SMStWQUl3MmNFbkYrWnRjbDRROENzMFRpSU4zd20v?=
 =?utf-8?B?WW5ISE9JM25ydWoyRFFOME5qa3hCdHNvM1gxbFpncTI1YWJLVTRINlRCT1FN?=
 =?utf-8?B?cmhKa3ByVExCVTU2Rmk0QlozS2tJUEZtWW8reGt5enNwWFp5UHY4ZWpnQU15?=
 =?utf-8?B?cWhkbFRmdkgyS3dQazhxSmxBV0ZlOU1zZ2xYc1VIMDFtZjc5Y1ZGUVk0aWta?=
 =?utf-8?B?NHJtOHE5VGZQbUE4QWtiV3FpVTZnZ0hqeVdqblBEdTd3bUxMTTFnaGhNV0FT?=
 =?utf-8?B?Y0VjdFQrcXNsazMzVUxab1JOWlNiTCtOa3lzVGlBUTRBS0E0ZlUzUVdmWHR2?=
 =?utf-8?B?Z3JrNnFsZERhL3l4MUZSLzFyb2VuS0lVQkFGNUhwMEdsMm5pNGlVZlM1OEpX?=
 =?utf-8?B?U0oyU1IyZUswczBTNHdGTzNxdm1wNi83U2o3YktDT0tFTzBnU2x4UDhUOG1K?=
 =?utf-8?B?RmJiWkQwVU9rV3Jlc1RSNnpCRkdSWVYwSGNmbEtOekZvNERmL0lCdXhKNXVD?=
 =?utf-8?B?VmMreEsvNGdQTTR1MFRsOHNmbXZEQk40SXZEa295QmlEZWN5dzdPTjJ5Ynpm?=
 =?utf-8?B?RnpIaC9oZ1gyTlRBRVVTQXdNNHN4dEltdnRvUU9lZ3dMWU1Rc3ZDQWJhcWpv?=
 =?utf-8?B?WkdqSkF6QTl6b1J6WGdZbmJWNmsrd2tMRCs0WmNFZmZGU1UwRTZ1MTBxd0dz?=
 =?utf-8?B?aWhyVjBqSlcvenBnOWxuNStmcmoxU3RFZzMxSnNnUEtPS0I0aTM1R1cvYm1p?=
 =?utf-8?B?S2ZJVXRFRUdrSFFkMXFJWExLRlltZ3lVSXVaTXJvZ0NZMDBKVktXbk9RZWJw?=
 =?utf-8?B?SWhEMHBBaFZBejlpREU4dlg0KzlhTkV5d0xVWFRKQXQ0TUFrUkswV3RHcHB4?=
 =?utf-8?B?RkhmYUNPaTR0em84c3g4bFRlcDJkQWlUbnd1WVllRndPRDhHaHhKeEpOMmt1?=
 =?utf-8?B?RkpxUXBoQkFnNFU0WDVYZ25XbmVXTVBEQWVTVnRVUFpFeThiZ2RiS3ZzZzFV?=
 =?utf-8?B?K0ZQZEVxVXg5Q1ZJYktMVlROM3lYaUlJaER0SHpsbDNnL2syVlpuSld2MHJy?=
 =?utf-8?B?VHFHR0pWSkhYTTdneEZzVXZrdnBBRmJqQTRmenZNakxRZ0l6ODN5RzlZSXMv?=
 =?utf-8?B?Mjgybms1V2hrQ0RWR2xJSDIzeEIvVEVybnliVk1Qb24xWG9uSCs1bW1ZU1Zr?=
 =?utf-8?B?WkoxRlg0SDZyemhXaXhxZDB3OEc0Q29GWXlPdmxqQVZ2ZW0yMElXSDIrUEVM?=
 =?utf-8?B?KytacFBxSmc1T2pmQWlIVmo3Q3JpYzdwQlAwemh6QzV6K3VZV1g0Kzcya3BT?=
 =?utf-8?B?dk9GVlZYc0hPanZQQzBOUU81OVNwUjR6ZVRJdGtqQzZ2RHpRT29DajRRQ0Zx?=
 =?utf-8?B?dFlhVTJnK21IYXRlTTlwVE5ZSTNUbDM0Nmk5VzVVOU5DS0M4aHRjRUR4NUpj?=
 =?utf-8?B?eFR6TFhER1UwdUZidnJtNEZIWmlUT04zYzMrbnN2elZnRStWSkczZz09?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3768b46-dd34-4c21-9c7b-08da1d4ab7d6
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 12:39:57.6676
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VCTTW0z1QLClJL9tbZlQmpHVjGLUA4C+Q/0RYlPPTUZTSvKOv6XYUzEyS7S43YOxwpHXMLs3gfNP5fTBG90MIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6065
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2022-04-13 at 16:19 +0530, Vinod Koul wrote:
> On 13-04-22, 18:04, Liu Ying wrote:
> > Hi Vinod,
> > 
> > On Wed, 2022-04-13 at 11:41 +0530, Vinod Koul wrote:
> > > On 02-04-22, 13:24, Liu Ying wrote:
> > > > This patch allows LVDS PHYs to be configured through
> > > > the generic functions and through a custom structure
> > > > added to the generic union.
> > > > 
> > > > The parameters added here are based on common LVDS PHY
> > > > implementation practices.  The set of parameters
> > > > should cover all potential users.
> > > > 
> > > > Cc: Kishon Vijay Abraham I <kishon@ti.com>
> > > > Cc: Vinod Koul <vkoul@kernel.org>
> > > > Cc: NXP Linux Team <linux-imx@nxp.com>
> > > > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > > > ---

[...]

> > > > + */
> > > > +
> > > > +#ifndef __PHY_LVDS_H_
> > > > +#define __PHY_LVDS_H_
> > > > +
> > > > +/**
> > > > + * struct phy_configure_opts_lvds - LVDS configuration set
> > > > + * @bits_per_lane_and_dclk_cycle:	Number of bits per data
> > > > lane
> > > > and
> > > > + *					differential clock
> > > > cycle.
> > > 
> > > What does it mean by bits per data lane and differential clock
> > > cycle?
> > 
> > Please check
> > Documentation/devicetree/bindings/display/panel/lvds.yaml.
> > lvds.yaml metions slot.  'bits_per_lane_and_dclk_cycle' means the
> > number of slots.  But, I don't find the word 'slot' in my lvds
> > relevant
> > specs which mentioned in lvds.yaml, so 'slots' is probably not a
> > generic name(lvds.yaml is for display panel).  So, I use
> > 'bits_per_lane_and_dclk_cycle' as the name tells what it means.
> 
> variable name is fine, explanation for bit per lane and differential
> clock cycle didnt help, maybe add better explanation of what this
> variable means

I may add an example diagram as below...

> 
> > 
> > > 
> > > > + * @differential_clk_rate:		Clock rate, in Hertz,
> > > > of the
> > > > LVDS
> > > > + *					differential clock.
> > > > + * @lanes:				Number of active,
> > > > consecutive,
> > > > + *					data lanes, starting
> > > > from lane
> > > > 0,
> > > > + *					used for the
> > > > transmissions.
> > > > + * @is_slave:				Boolean, true if the
> > > > phy is a slave
> > > > + *					which works together
> > > > with a
> > > > master
> > > > + *					phy to support dual
> > > > link
> > > > transmission,
> > > > + *					otherwise a regular phy
> > > > or a
> > > > master phy.

---------------------------------8<------------------------------------
+ * This is an example with 4 lanes and 7 bits per data lane and
differential
+ * clock cycle:
+ *
+ * ::
+ *               |<------------- one differential clock cycle --------
----->|
+
*                ________________                         ____________
_____
+ *      Clock                     \_______________________/
+
*                  ______  ______  ______  ______  ______  ______  ____
__
+
*      Lane0     ><_bit0_><_bit1_><_bit2_><_bit3_><_bit4_><_bit5_><_bit
6_><
+
*      Lane1     ><_bit0_><_bit1_><_bit2_><_bit3_><_bit4_><_bit5_><_bit
6_><
+
*      Lane2     ><_bit0_><_bit1_><_bit2_><_bit3_><_bit4_><_bit5_><_bit
6_><
+
*      Lane3     ><_bit0_><_bit1_><_bit2_><_bit3_><_bit4_><_bit5_><_bit
6_><
---------------------------------8<------------------------------------

What do you think?

Regards,
Liu Ying