Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp533706pxb; Wed, 13 Apr 2022 07:19:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbPB6exN1dkopi5M8eLDlule4SJdXTsbMb4pBFLJ4hnKY7WyVC8gY5DBL7WPhke4yYXKE9 X-Received: by 2002:a17:907:62aa:b0:6e0:f208:b869 with SMTP id nd42-20020a17090762aa00b006e0f208b869mr38100575ejc.270.1649859550319; Wed, 13 Apr 2022 07:19:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649859550; cv=none; d=google.com; s=arc-20160816; b=jRNFZesfRrD5FUr+n/p8y4I23psHhDgmXnJWEBpbUEok70s9MgFi4FJInubSiuxwQo IG8aelHTdMpbgDfltdYmJ2zxHsciBWUNdg4URITtNaMJyllW1DKQK0qEVhg+WW75yqjM c7NYUvWhGqx2+eZstGSZiHUPvrTb5UsI1HYYido1upI2JPiv7LIvto6MvY9Nc7GKo+Su uVjhva26aZxXcaW2T+6M3KYNsXGQ43vonVXBqtm7zntiLFOWNEBwKeENFJaKRLHLybfl KcGZMp5z14hPRPDkBisNZeVdeIn3RsFAI/WJrR533Q74k0gjWP4eT3Yz4jcC+uB5xvoY IdjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=y7Q0DzxtNb5qnDT8gTkIE1sZ4vZ4/dVJ0xBs7YGfUmM=; b=02a7w2YkyQlBJVUYE4Xrmi64Sd1IAiHncx8Iypv1aOqmGhtBQyKg2V/zHQA+OfXGMW kKkIGRwRhQht/5VLFB8/lcNLyHRrqXmdzKDycuxCUDaxCWaMM/zet9f2OhX0r3SegTBE zk8WBPX5UZSRFdBaN8PhCBd0oh+/01i2Iab/EWhd7rdkXjNy8ACn+C2IaoViQuXQKfVL llyDASCYnBooJqeKtSHb5kOzIGx/wigACmDz02VG+uFwl1aHJdoJ4sEsDdz5I818EouP pByIUADCOmImCH6ihWW7wRQlthtPJGT8+HeSPlgoC5JWrFTU5Dm8zJ5ms/mUWrrUNZhn gbfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bUeCiA6l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u10-20020a1709063b8a00b006e7f255e307si31210ejf.478.2022.04.13.07.18.27; Wed, 13 Apr 2022 07:19:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bUeCiA6l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234467AbiDMJgN (ORCPT + 99 others); Wed, 13 Apr 2022 05:36:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231169AbiDMJgM (ORCPT ); Wed, 13 Apr 2022 05:36:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A42053E31 for ; Wed, 13 Apr 2022 02:33:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CC23861AA0 for ; Wed, 13 Apr 2022 09:33:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91667C385A4; Wed, 13 Apr 2022 09:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649842431; bh=hEhA6vlEbgiN/xrO95gWAor7RejqPLSP7eutiio7lyU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bUeCiA6ljOPCKhNZSYEPSmsreon9E4L/fiv5x8KOA5PTYgPjF77h7ViZvfO+MZG1S DUJBOw8zLT41y8GIJxWusMpX/gACXHF4QNpK2JwywEgyIV7Bz0E9jOsLmuo9FlwiD0 wge3TbuEbqPjrB0sfka5+2k6bJpsWj/XfdAQoMKkuuSXC9QLdJOD9+W7Uxn+Vtkg12 EJPKb+j387t3q4kvQrhmppGoWqCHhfnSpCAq8nl+FGzHLCNj9fN4L4h+jvVpmi3vmj 9wRscZypVWFNJLySDdj/Wfa03ozdcGfavLjTtAiVozcZOR8Dd4QAQ7AfWo4Lo7P7+v hnTgqEDKqF/Ag== Date: Wed, 13 Apr 2022 15:03:46 +0530 From: Vinod Koul To: Miaoqian Lin Cc: Kishon Vijay Abraham I , Liam Beguin , Roger Quadros , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable_clocks Message-ID: References: <20220318105748.19532-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220318105748.19532-1-linmq006@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18-03-22, 10:57, Miaoqian Lin wrote: > The corresponding API for clk_prepare_enable is clk_disable_unprepare. > Make sure that the clock is unprepared on exit by changing clk_disable > to clk_disable_unprepare. Applied, thanks -- ~Vinod