Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1767747AbXEDIxk (ORCPT ); Fri, 4 May 2007 04:53:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1767749AbXEDIxk (ORCPT ); Fri, 4 May 2007 04:53:40 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.161]:45851 "EHLO mo-p00-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1767747AbXEDIxj (ORCPT ); Fri, 4 May 2007 04:53:39 -0400 From: Stefan Roese To: Robert Schwebel Subject: Re: Correct location for ADC/DAC drivers Date: Fri, 4 May 2007 10:54:05 +0200 User-Agent: KMail/1.9.5 Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org References: <200705011435.45046.ml@stefan-roese.de> <20070504082434.GA22585@pengutronix.de> In-Reply-To: <20070504082434.GA22585@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200705041054.05650.ml@stefan-roese.de> X-RZG-AUTH: j/Xgg0n2J5AIUJCkqLmy+bJbs1jMc+ebRMH8X0gX2f46QMnUI4cTITA7kWi4b/tFeJ1A X-RZG-CLASS-ID: mo00 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1545 Lines: 32 On Friday 04 May 2007 10:24, Robert Schwebel wrote: > On Tue, May 01, 2007 at 02:35:44PM +0200, Stefan Roese wrote: > > I'm in the stage of integrating some ADC and DAC drivers for the AMCC > > 405EZ PPC and looking for the correct location to place these drivers > > in the Linux source tree. The drivers are basically character-drivers, > > so my first thought is to put them in "drivers/char/adc/foo.c" or > > "drivers/char/adc_foo.c". Is this a good solution? > > > > Any suggestions welcome (could be that I missed an already existing > > example). > > > > BTW: I am aware of the hwmon subsystem, but I don't think it fits my > > needs in this case. > > Could you elaborate the requirements a bit more? ADC is not ADC, because > slow i2c ADCs which measure a temperature every five minutes have other > requirements than multi-megabyte-per-second-dma-driven ADCs. The hardware (PPC405EZ) actually implements an high speed, dma capable, ADC controller with 10-bit resolution and up to 4MHz sample rate. The current driver doesn't support all these features though (dma is not supported right now for example). Could be that this will be added in future releases. It would be good though, to have the driver located at the "correct" place in the kernel tree right away. Best regards, Stefan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/