Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <52225285-3b64-f709-81ff-0c26a9b13c02@gmail.com>
Date:   Wed, 13 Apr 2022 22:09:32 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
From:   SHIMAMOTO Takayoshi <takayoshi.shimamoto.360@gmail.com>
Subject: Re: [PATCH] ARM: dts: BCM5301X: Add DT for Buffalo WZR-1166DHP2
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        bcm-kernel-feedback-list@broadcom.com,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220412154432.12124-1-takayoshi.shimamoto.360@gmail.com>
 <ab529968-7dc5-f4c9-5ce4-5dc95b64838f@gmail.com>
Content-Language: en-US
In-Reply-To: <ab529968-7dc5-f4c9-5ce4-5dc95b64838f@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Thank you for the replies.

On 2022/04/13 2:49, Rafał Miłecki wrote:
>>   - 4x 10/100M ethernet switch
> 
> Isn't that 10/100/1000?

You are right.
It supports 10/100/1000Mbps.

>> +    model = "Buffalo WZR-1166DHP2 (BCM4708)";
> 
> We stopped adding SoC name to the "model" value, please drop it.

Understood.

I will fix it as follows
model = "Buffalo WZR-1166DHP2";

>> +
>> +        wireless1 {
>> +            label = "bcm53xx:amber:wireless";
>> +            gpios = <&hc595 7 GPIO_ACTIVE_HIGH>;
>> +        };
>> +    };
> 
> I'm wondering if all new DTS files should use "function" and "color"
> instead of "label". That's preferred solution and I guess it's good idea
> to use it for new code.

Understood.

I will rewrite it with "function" and "color."

I will post the patch again after testing.

Best regards