Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Zhi A" <zhi.a.wang@intel.com>
To:     Christoph Hellwig <hch@lst.de>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>
CC:     "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "Jason Gunthorpe" <jgg@nvidia.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: refactor the i915 GVT support and move to the modern mdev API v3
Thread-Topic: refactor the i915 GVT support and move to the modern mdev API v3
Thread-Index: AQHYTa50HopuXX46aU+QxtIWwnq/0azt3o0A
Date:   Wed, 13 Apr 2022 13:47:05 +0000
Message-ID: <82c13d8e-1cb4-2873-86e9-16fd38e15b27@intel.com>
References: <20220411141403.86980-1-hch@lst.de>
In-Reply-To: <20220411141403.86980-1-hch@lst.de>
Accept-Language: en-FI, en-US
Content-Language: aa
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?Omet3QpsO2mPqByo889kyZHP7cSYZ+RzC7KNBWjvswVvmauGCSjmOlvI?=
 =?Windows-1252?Q?tesmvt9o9VeNhNSW4eZ4H8pwQ11kQWOwXfvZl/uAukd+botiGxkNGTEJ?=
 =?Windows-1252?Q?wgf5LSY+aFL+bZxYpSE9XqQ3TR3Tr0Vcf+xxKGoWUoGFXD9K3XcOOnr7?=
 =?Windows-1252?Q?de4IboCuwh5auTnE8FoYEhqzpQ469dHdQNz62P3IHO0STBrUf3TRM5Yw?=
 =?Windows-1252?Q?7+SCNHpGtX8LrfdyfHaxDlpOtGWDHxASo97n0Mt+ZzIDkv1qsI/L0IQM?=
 =?Windows-1252?Q?o/z1ZOI9McR/n8fMO7RVH3T5cCfqaZD4BQZIZqxF2KASy0xYXMMdkmD1?=
 =?Windows-1252?Q?Jz4fG1IFhbTQdmytN+JGaGmkQLvL9ZyCTQ0v3WCKnRd4Mujyr3/DPqeK?=
 =?Windows-1252?Q?8DKHF90v+qqX+eyyFxwJPUEmspuxQeZ9uJROKv40D3ABCJk/3WYnQZDs?=
 =?Windows-1252?Q?mhXjrY2FDkKnz1Hr3u4JSw8lcvCVhj+4KwGuMqoRAAGOxHA1FRePRul2?=
 =?Windows-1252?Q?j1tm8/DqJbhFwO+zrjSRGYMsDF+yQ5FO1NfSVwY3aqlK4dNt/497JeGo?=
 =?Windows-1252?Q?+2bFTT4MDaSF7wU/U9P2aU2M6cxJddjv4d1JF6ZrOVNQKADlF1x36Kmd?=
 =?Windows-1252?Q?v1NwMa+rJz/lvBwkBRqfmt4tbT2tMgs13tu5Q13VlSyi+3Y90ELt94b9?=
 =?Windows-1252?Q?f/u/PlZ2bO7aakHxrKoRlnoKL6pK0PqH2LYN75bU5rozZ9D1Bg6EpZu/?=
 =?Windows-1252?Q?9ugKVQwkOlnxBrDRRaLjeiPkWMczNjmScg2VdKFq0Zk/8uXB2XLoc05v?=
 =?Windows-1252?Q?4EnisDk5qpgjQ/GBeNCWTU9ENFnHbIPzrgbPhL8JvwEOQgfd8gpWDZpo?=
 =?Windows-1252?Q?LXc3n5qij1bfhI/HV3UteGZkKhgROhnlkCKfaxCXNmhg2RZAJ+vuOGSX?=
 =?Windows-1252?Q?xX55p4R/H3VvAt6dxTDxYlbHo6VWYEqmL48apMHH3Xhgw7h0WXQeeyD3?=
 =?Windows-1252?Q?xVDTLBjBUaNmKyg6f0QSkge7oBYlhrYAQ8f8E9KvyCJVvfhdGkMqNsVR?=
 =?Windows-1252?Q?569sTTEynHvddVG5F0I67QKgzYKRHSTcPPNr/rbrJS85ig2agvDQeinY?=
 =?Windows-1252?Q?Cm7oPAo+UcJ9y7mMDzi9wwfCLZ3X9R6M5NfsNB09WGezEKJMEIFslqPI?=
 =?Windows-1252?Q?bx7aRaP6b+n/LdLp8lkdOU34/NLgoGYgjC06xIoA4Xi5zUffhLTTK6mj?=
 =?Windows-1252?Q?xmnAEZsOu6LIVqsvJUTdP0wzI8pStIjpjUtuNO6YFVN9ez170tm8UH7K?=
 =?Windows-1252?Q?IR6WBuaYQllRQOqUbGVgDT1q7JXNfBp8pqbEt5eMgRWXv7n0CDHvuoXn?=
 =?Windows-1252?Q?dedxkcc1BAmDJyk/QgmNiA38P+WmjibLI2z3mH3F6k0ZgYF+Q56X/RJy?=
 =?Windows-1252?Q?Mee2JOrpR2CB2mj2ccY2+22qjLxCBoB+ej7kTQAjURBz5pibDxAiJjyv?=
 =?Windows-1252?Q?MeT7FdBh2MZ59soznDkr2QDnIuTtNFgPJ7R3FX/uXqDOEcMAYGsqO6lO?=
 =?Windows-1252?Q?yAsMfKC7B3nNyx7aDI26YaRNDKqWaw6VLQhwr6HQtGYiM+rYkOapSv3+?=
 =?Windows-1252?Q?pEtHh0wytvxXQ+EHBcfZ8MvcVAjKOcLLvp0HdeRW7z1R5aore3V/1EcQ?=
 =?Windows-1252?Q?7K5FPZj+AuI7elhTHECyPHT/PiS8K8PPKZRMrqScUJs9n2zfTadz9yn9?=
 =?Windows-1252?Q?+I+UkTZPufrgDwX8URD6bHccMulfYhtESMcOLOQsQH0DZaWDP7jvwEmb?=
 =?Windows-1252?Q?GPm/7H9i9c/HXit5X2NGxbN+GrP+S51sD7nwlW6NCCL/wEImR3CdI1sc?=
 =?Windows-1252?Q?4DbsO5YZCDLAjw=3D=3D?=
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <CD3DEA7297D4FF4F9D84E6F4185D103E@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5549.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bbed6079-03c2-4614-a1b2-08da1d541886
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2022 13:47:05.1031
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wXBrrnMhfWZK1AAwcvXR6OUJxuoVm1zG+fGSIanKxKcdBCJjNc6+PIGl1orewkt77ZvUpZjIlcw1hiOIIi7Qmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5473
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/11/22 2:13 PM, Christoph Hellwig wrote:
> Hi all,
>=20
> the GVT code in the i915 is a bit of a mess right now due to strange
> abstractions and lots of indirect calls.  This series refactors various
> bits to clean that up.  The main user visible change is that almost all
> of the GVT code moves out of the main i915 driver and into the kvmgt
> module.

Hi Christoph:

Do you want me to merge the GVT-g patches in this series? Or you want them =
to get merged from your side?

Thanks,
Zhi.

>=20
> Tested on my Thinkpad with a Kaby Lake CPU and integrated graphics.
>=20
> Git tree:
>=20
>     git://git.infradead.org/users/hch/misc.git i915-gvt
>=20
> Gitweb:
>=20
>     http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/i915-=
gvt
>=20
> Changes since v2:
>  - rebased on top of Linx 5.18-rc +
>    "Refactor GVT-g MMIO tracking table and handlers"
>  - don't fold the gvt Makefile into the main Makefile
>  - add the mdev patches to remove the legacy interface that is now
>    unused to the end of the series
>=20
> Changes since v1:
>  - rebased on Linux 5.15
>  - allow the kvmgvt module to be loaded at any time and thus solve
>    the deadlock when both i915 amd kvmgvt are modular
>  - include the conversion to the modern mdev API
>=20
> Note that I do expect to rebased this again against 5.16-rc1 once
> released, but I'd like to get this out for review ASAP.
>=20
> Diffstat:
>  b/drivers/gpu/drm/i915/Kconfig          |   33=20
>  b/drivers/gpu/drm/i915/Makefile         |   31=20
>  b/drivers/gpu/drm/i915/gvt/cfg_space.c  |   89 --
>  b/drivers/gpu/drm/i915/gvt/cmd_parser.c |    4=20
>  b/drivers/gpu/drm/i915/gvt/dmabuf.c     |   36 -
>  b/drivers/gpu/drm/i915/gvt/execlist.c   |   12=20
>  b/drivers/gpu/drm/i915/gvt/gtt.c        |   55 +
>  b/drivers/gpu/drm/i915/gvt/gvt.h        |  125 ++-
>  b/drivers/gpu/drm/i915/gvt/interrupt.c  |   38 +
>  b/drivers/gpu/drm/i915/gvt/kvmgt.c      | 1099 +++++++++++++++----------=
-------
>  b/drivers/gpu/drm/i915/gvt/mmio.c       |    4=20
>  b/drivers/gpu/drm/i915/gvt/opregion.c   |  148 ----
>  b/drivers/gpu/drm/i915/gvt/page_track.c |    8=20
>  b/drivers/gpu/drm/i915/gvt/scheduler.c  |   37 -
>  b/drivers/gpu/drm/i915/gvt/trace.h      |    2=20
>  b/drivers/gpu/drm/i915/gvt/vgpu.c       |   22=20
>  b/drivers/gpu/drm/i915/i915_drv.c       |    7=20
>  b/drivers/gpu/drm/i915/i915_drv.h       |    1=20
>  b/drivers/gpu/drm/i915/i915_trace.h     |    1=20
>  b/drivers/gpu/drm/i915/intel_gvt.c      |  162 +++-
>  b/drivers/gpu/drm/i915/intel_gvt.h      |   17=20
>  drivers/gpu/drm/i915/gvt/Makefile       |    9=20
>  drivers/gpu/drm/i915/gvt/gvt.c          |  340 ---------
>  drivers/gpu/drm/i915/gvt/hypercall.h    |   82 --
>  drivers/gpu/drm/i915/gvt/mpt.h          |  400 -----------
>  25 files changed, 929 insertions(+), 1833 deletions(-)
>=20