Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Apr 2022 11:28:13 -0600
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
To:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc:     bjorn.andersson@linaro.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, linux-remoteproc@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        shengjiu.wang@nxp.com, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V2 0/2] remoteproc: elf: ignore PT_LOAD type segment with
 memsz as 0
Message-ID: <20220413172813.GB547134@p14s>
References: <20220413033038.1715945-1-peng.fan@oss.nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220413033038.1715945-1-peng.fan@oss.nxp.com>
Precedence: bulk

On Wed, Apr 13, 2022 at 11:30:36AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> V2:
>  Add R-b/A-b tag
>  Drop inaccurate comment in patch 1
> 
> i.MX DSP firmware has segments with PT_LOAD and memsz/filesz as zero.
> It is valid case the memsz set to zero according to elf spec:
> https://refspecs.linuxbase.org/elf/elf.pdf page 40
> 
> So we could let remoteproc elf loader handle this case, then no
> duplicate code in imx dsp rproc driver
> 
> Tested i.MX8MP DSP and M7 remoteproc
> 
> Peng Fan (2):
>   remoteproc: elf_loader: skip segment with memsz as zero
>   remoteproc: imx_dsp_rproc: use common rproc_elf_load_segments
> 
>  drivers/remoteproc/imx_dsp_rproc.c         | 95 +---------------------
>  drivers/remoteproc/remoteproc_elf_loader.c |  2 +-
>  2 files changed, 2 insertions(+), 95 deletions(-)
>

I have applied this set but as I pointed out in the previous revision, it will
have to be backed-out if something breaks.  Hopefully it won't get to that.

Thanks,
Mathieu

> -- 
> 2.25.1
>