Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1767778AbXEDJsX (ORCPT ); Fri, 4 May 2007 05:48:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1767779AbXEDJsX (ORCPT ); Fri, 4 May 2007 05:48:23 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:51396 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1767764AbXEDJsW (ORCPT ); Fri, 4 May 2007 05:48:22 -0400 Date: Fri, 4 May 2007 10:48:17 +0100 From: Christoph Hellwig To: Kristian H??gsberg Cc: John Stoffel , Stefan Richter , linux-kernel@vger.kernel.org, Linus Torvalds , Andrew Morton , linux1394-devel , Christoph Hellwig Subject: Re: [PATCH 3/6] firewire: char device interface Message-ID: <20070504094817.GA31811@infradead.org> Mail-Followup-To: Christoph Hellwig , Kristian H??gsberg , John Stoffel , Stefan Richter , linux-kernel@vger.kernel.org, Linus Torvalds , Andrew Morton , linux1394-devel References: <4637A29F.6070302@redhat.com> <20070502090007.GA28174@infradead.org> <17976.44988.734513.121919@smtp.charter.net> <4638FE91.6050001@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4638FE91.6050001@redhat.com> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 17 On Wed, May 02, 2007 at 05:11:45PM -0400, Kristian H??gsberg wrote: > The firewire-cdev.h file is meant to be a self-contained userspace header > file and shouldn't include other kernel header files. All duplicated > values are standardized ieee1394 values and won't ever change. I should > put a #ifndef __FW_COMMON_DEFINES protection around the duplicate values, I > guess, but I'm just wondering why I never saw a "symbol redefined" > warning... No, defining things in two places is not okay. Just add a new header that defines these protocol constants, which needs to be included by userspace that wants to use them. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/