Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754622AbXEDK0N (ORCPT ); Fri, 4 May 2007 06:26:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754248AbXEDK0N (ORCPT ); Fri, 4 May 2007 06:26:13 -0400 Received: from opal.biophys.uni-duesseldorf.de ([134.99.176.7]:51551 "EHLO opal.biophys.uni-duesseldorf.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2993188AbXEDK0L (ORCPT ); Fri, 4 May 2007 06:26:11 -0400 Date: Fri, 4 May 2007 12:25:53 +0200 (CEST) From: Michael Schmitz To: Dmitry Torokhov cc: Michael Schmitz , Geert Uytterhoeven , Linus Torvalds , Andrew Morton , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Schmitz , Roman Zippel Subject: Re: [patch 04/33] m68k: Atari keyboard and mouse support. In-Reply-To: Message-ID: References: <20070501195052.390551603@mail.of.borg> <20070501195129.842338339@mail.of.borg> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1389 Lines: 36 > > > > + // need to init core driver if not already done so > > > > + if (atari_keyb_init()) > > > > > > Memory leak > > > > How so? If the core has been initialized already this will just return ... > > > > You just allocated atakbd_dev. If atari_keyb_init() fails you leak it. I see. Won't probably happen, but there's no reason to take a risk. > > > It looks like this driver is not using standard input event codes. If > > > Roman does not want to adjust keymaps on Amiga and Atari that should > > > be handled in legacy keyboard driver (drivers/char/keyboard.c). As it > > > is programs using /dev/input/eventX have no chance of working. > > > > The translation map should not have been overwritten like above, is that > > what you mean? > > My original patch didn't have that bit; scancodes were translated to > > input keycodes using atakbd_keycode[scancode] instead. I'll have that > > reverted... > > > > Does KEY_1 actually maps to scancode 2 on atari? It sure does. For most of the keys, the identity mapping is in fact OK. There's a lot of keys where this breaks, though. Plus the notorious scancode 0 :-) Michael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/