Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Apr 2022 16:59:07 +0200
From:   Herve Codina <herve.codina@bootlin.com>
To:     Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     Marek Vasut <marek.vasut+renesas@gmail.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rob Herring" <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        "Geert Uytterhoeven" <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= <kw@linux.com>,
        Rob Herring <robh@kernel.org>, <linux-pci@vger.kernel.org>,
        <linux-renesas-soc@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Clement Leger <clement.leger@bootlin.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH 3/6] PCI: rcar-gen2: Add R9A06G032 support
Message-ID: <20220413165907.183c39f5@bootlin.com>
In-Reply-To: <75be60ce-d9b2-b9a0-c897-3cc904889db6@omp.ru>
References: <20220412094029.287562-1-herve.codina@bootlin.com>
        <20220412094029.287562-4-herve.codina@bootlin.com>
        <75be60ce-d9b2-b9a0-c897-3cc904889db6@omp.ru>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Sergey,

On Wed, 13 Apr 2022 12:08:01 +0300
Sergey Shtylyov <s.shtylyov@omp.ru> wrote:

> Hello!
>=20
> On 4/12/22 12:40 PM, Herve Codina wrote:
>=20
> > Add Renesas R9A06G032 SoC support to the Renesas R-Car gen2 PCI
> > bridge driver.
> > The Renesas RZ/N1D (R9A06G032) internal PCI bridge is compatible
> > with the one available in the R-Car Gen2 family.
> >=20
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> > ---
> >  drivers/pci/controller/pci-rcar-gen2.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >=20
> > diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/contr=
oller/pci-rcar-gen2.c
> > index 528bc3780e01..586e4785a57f 100644
> > --- a/drivers/pci/controller/pci-rcar-gen2.c
> > +++ b/drivers/pci/controller/pci-rcar-gen2.c
> > @@ -352,6 +352,8 @@ static const struct of_device_id rcar_pci_of_match[=
] =3D {
> >  	{ .compatible =3D "renesas,pci-r8a7791", },
> >  	{ .compatible =3D "renesas,pci-r8a7794", },
> >  	{ .compatible =3D "renesas,pci-rcar-gen2", },
> > +	{ .compatible =3D "renesas,pci-r9a06g032", }, =20
>=20
>    Do we really need this one here? Isn't it covered by the next item?

Yes, this one is not needed.
Miqu=C3=A8l did the same remark too.

I will remove '.compatible =3D "renesas,pci-r9a06g032"' in v2.

Regards,
Herve

>=20
> > +	{ .compatible =3D "renesas,pci-rzn1", },
> >  	{ },
> >  };
> >   =20
>=20