Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp1215467pxb; Thu, 14 Apr 2022 00:36:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwH4UVG1lakszDWUATomfuwhjTp4RVn06ZDCzx+QOL7jHbD0q9bKGzPpgbdn7TAqOttIs5Q X-Received: by 2002:a17:906:3acc:b0:6e8:8900:1bc9 with SMTP id z12-20020a1709063acc00b006e889001bc9mr1189800ejd.608.1649921805108; Thu, 14 Apr 2022 00:36:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649921805; cv=none; d=google.com; s=arc-20160816; b=Bqdg2UIMDbSCe6X5/z8xfgxeBjXXTydnZSx/vIjTOF+IIGvNm1Ke7Vw34MMqTSDDqc AHFgWdXcLaAECMM9mwBVvGGKHVB+/iHvoblFkHM+nTAl8/pzngk/desWZM/SigeqgMYu xHZMl59uj/0pf2fOGxya4AMIPFxVNYCoJEagT+Z/cIHWBR6MUhXpHuUNEgA/gU6vGggK 4pxx2grYiXwA5UzV7+Mqt+JLjVeBXJe8LzYOEA8WHgthx+hvsFf05Y0a4Sdqz1E1YmLI 3jRK4bhILIgbnG55199Bfsvd0Zt5UVuCGBK6TlSZCqdtt0vrR+aFtSQvLWDhJ/lLSzgD AxCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=25z+IEp/ocUelsSHYYZhGqcb+MPXgG1e2pbNAB1XpTU=; b=09MzUotLpQ8kXNPhg6GjRkgsmwAM0oPufWmIGvHOOs9B3D6W1oO+TYA653dsVII27u FuQhienp14W/M6+ESoMtbC/rSUTfFawwEda3a09jkN6n4hnCTcsSHsfrsWN2dU3R9ZtK CeiW2ZxZ2fiK3P7tKNTPbLYDlJkBawkh5ApbA8xqWzVxvRvreJx5DIlswNcbfwhQow4l fLriMnEX1kIu9lKW4dBL8Eh+XDeHJZ1kw4guVWTIcX+2SdVZyOeMjJ6MpBlmHUuHUVPf QenC45pzWqETXNUlP/2D5G1NnvfePsJL9eI8Kh9cF9MwYTK0xK9HDihz/FXxXxtOS2D1 ZPkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=UhglDxe9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g9-20020a056402090900b0041d7932031bsi3893095edz.59.2022.04.14.00.36.20; Thu, 14 Apr 2022 00:36:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=UhglDxe9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238418AbiDMTbG (ORCPT + 99 others); Wed, 13 Apr 2022 15:31:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238367AbiDMTbE (ORCPT ); Wed, 13 Apr 2022 15:31:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 181E775608 for ; Wed, 13 Apr 2022 12:28:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C9BA2B8276E for ; Wed, 13 Apr 2022 19:28:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B0C1C385A4; Wed, 13 Apr 2022 19:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1649878107; bh=KfuSlyE1Z5VblHuvIYYUHgpgwRqcjLvXRY0q5P7T52Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UhglDxe97PIX9nMF7wv1SmFiymZ/cqXvd0dgEdMWBnLtRRNwPv7tPttnZl+u4Y9Uo 0b1oGxWzdp6pH1h7fgLbLcpYlfzj1UHoYB2wfJVhfsYBXn41Kdqr0+vbC+XzIzkcJD KKeIyUjY148rBOoOzwakAm5zzAPbSWKVgcY/VhZg= Date: Wed, 13 Apr 2022 12:28:26 -0700 From: Andrew Morton To: Patrick Wang Cc: catalin.marinas@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: kmemleak: take a full lowmem check in kmemleak_*_phys() Message-Id: <20220413122826.792a859d90b6c2822b1c796a@linux-foundation.org> In-Reply-To: <20220413122925.33856-1-patrick.wang.shcn@gmail.com> References: <20220413122925.33856-1-patrick.wang.shcn@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Apr 2022 20:29:25 +0800 Patrick Wang wrote: > The kmemleak_*_phys() apis do not check the address for lowmem's min > boundary, while the caller may pass an address below lowmem, which > will trigger an oops: Do you believe this fix should be backported into -stable kernels?