Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp1241007pxb; Thu, 14 Apr 2022 01:20:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLSyeoAiEChDsEHrGySLlf1NLHrtlapfsIBliclTbxg7OgpTnOHdugqsPTHSaivHwpdcLQ X-Received: by 2002:a17:906:9c82:b0:6df:c5f0:d456 with SMTP id fj2-20020a1709069c8200b006dfc5f0d456mr1373593ejc.287.1649924406156; Thu, 14 Apr 2022 01:20:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649924406; cv=none; d=google.com; s=arc-20160816; b=O97wCcPg16nCBQE1PUGy3aCB90QtXGlVmpA/+Duc63y7oEiJAw0MoyxlP2TZDSSAMH F0o0rJ3Pev8nTbvSu4PNUQ/Orz73Jj036oG9HD5Hs5wYr5vVYqhcJrYFrMag9miz1Vzc 1Csap1Pb3RK/ZXq+i/vQeWCNkA8LG6D0WyZT/BGG10HoWldcwfO2Efimoh7cJJdNd+Vk 5/K3HiepLXuNnIZCGrYuVyjii7W+liRqvZ+6yC+JZ0BkcuTDmdBuO8KRBQRkseHD+0XB X6PTjHtCnGDxVbg1BbV7R7hcuKWUWKbfDok9INzpnpYZZVC+crYHiDGimiX8rsRMmEoO KCuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :to:subject; bh=Z8gtx4uRdAY1l3mZo5b2hfLNm++moTEM6hDKKjqJAGY=; b=foNhnZPfjmiWTo79P8JyiDfQSVBQcB0zgOA9P/bO0t50Z+pqx+tFaqNuowepq8zyP9 qVFZeFsFHw2wejVtYsqLHFfRSkjJF95DCtZ7xi4xgPSFwYv/LKnAftkAFoK3xNMg+d/i EJ3snh0UDx0Rs4L5hXGimEOhVdB8POqxxqIdYoe5hQA246Vi4DA0ZR7vMzOAe5k6Y8KJ MFVjye21B1zAeuBOMpBvkqk9tMR/oUllIffqk3SFS6q4h5MNIlJZIXkPrbzrgphBpJwK lBZT2dpxUP3v6g4eC+r73Or+lkj+4p+Hrv9+xfoHMj1RyOkiIpe8QyHNMZxFjVQujoQW DbtA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fe9-20020a1709072a4900b006e89ba5885bsi1462500ejc.78.2022.04.14.01.19.40; Thu, 14 Apr 2022 01:20:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232489AbiDMISM (ORCPT + 99 others); Wed, 13 Apr 2022 04:18:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229922AbiDMISJ (ORCPT ); Wed, 13 Apr 2022 04:18:09 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2D5F52CC9D; Wed, 13 Apr 2022 01:15:49 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C94A113D5; Wed, 13 Apr 2022 01:15:48 -0700 (PDT) Received: from [10.1.33.136] (e127744.cambridge.arm.com [10.1.33.136]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 890833F5A1; Wed, 13 Apr 2022 01:15:46 -0700 (PDT) Subject: Re: [PATCH] perf report: Set PERF_SAMPLE_DATA_SRC bit for Arm SPE event To: Leo Yan , Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ravi Bangoria , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220413075124.635589-1-leo.yan@linaro.org> From: German Gomez Message-ID: Date: Wed, 13 Apr 2022 09:15:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220413075124.635589-1-leo.yan@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Leo, On 13/04/2022 08:51, Leo Yan wrote: > Since commit bb30acae4c4d ("perf report: Bail out --mem-mode if mem info > is not available") "perf mem report" and "perf report --mem-mode" > don't report result if the PERF_SAMPLE_DATA_SRC bit is missed in sample > type. > > The commit ffab48705205 ("perf: arm-spe: Fix perf report --mem-mode") > partially fixes the issue. It adds PERF_SAMPLE_DATA_SRC bit for Arm SPE > event, this allows the perf data file generated by kernel v5.18-rc1 or > later version can be reported properly. > > On the other hand, perf tool still fails to be backward compatibility > for a data file recorded by an older version's perf which contains Arm > SPE trace data. This patch is a workaround in reporting phase, when > detects ARM SPE PMU event and without PERF_SAMPLE_DATA_SRC bit, it will > force to set the bit in the sample type and give a warning info. > > Fixes: bb30acae4c4d ("perf report: Bail out --mem-mode if mem info is not available") > Signed-off-by: Leo Yan > --- > tools/perf/builtin-report.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > index 1ad75c7ba074..f26dd14eb852 100644 > --- a/tools/perf/builtin-report.c > +++ b/tools/perf/builtin-report.c > @@ -353,6 +353,7 @@ static int report__setup_sample_type(struct report *rep) > struct perf_session *session = rep->session; > u64 sample_type = evlist__combined_sample_type(session->evlist); > bool is_pipe = perf_data__is_pipe(session->data); > + struct evsel *evsel; > > if (session->itrace_synth_opts->callchain || > session->itrace_synth_opts->add_callchain || > @@ -407,6 +408,21 @@ static int report__setup_sample_type(struct report *rep) > } > > if (sort__mode == SORT_MODE__MEMORY) { > + /* > + * FIXUP: prior to kernel 5.18, Arm SPE missed to set > + * PERF_SAMPLE_DATA_SRC bit in sample type. For backward > + * compatibility, set the bit if it's an old perf data file. > + */ > + evlist__for_each_entry(session->evlist, evsel) { > + if (strstr(evsel->name, "arm_spe_") && This didn't work for me when the file recorded "-e arm_spe//" instead of "-e arm_spe_0//". Could you remove the trailing _? With that: Tested-by: German Gomez > + !(sample_type & PERF_SAMPLE_DATA_SRC)) { > + ui__warning("PERF_SAMPLE_DATA_SRC bit is not set " > + "for Arm SPE event.\n"); > + evsel->core.attr.sample_type |= PERF_SAMPLE_DATA_SRC; > + sample_type |= PERF_SAMPLE_DATA_SRC; > + } > + } > + > if (!is_pipe && !(sample_type & PERF_SAMPLE_DATA_SRC)) { > ui__error("Selected --mem-mode but no mem data. " > "Did you call perf record without -d?\n");