Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Lars-Peter Clausen <lars@metafoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>
Subject: RE: [PATCH v1 3/3] iio: imu: adis16480: Fix getting the optional
 clocks
Thread-Topic: [PATCH v1 3/3] iio: imu: adis16480: Fix getting the optional
 clocks
Thread-Index: AQHYT0SimMwpSDVIaEuZFYVh6Y0wNazt+DxA
Date:   Wed, 13 Apr 2022 15:38:47 +0000
Message-ID: <PH0PR03MB67865D24BB7546CAF805D7BE99EC9@PH0PR03MB6786.namprd03.prod.outlook.com>
References: <20220413144124.72537-1-andriy.shevchenko@linux.intel.com>
 <20220413144124.72537-3-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20220413144124.72537-3-andriy.shevchenko@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 2
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?3M3GXfQ6N3AB04RAk0gcKcepZGn8nErYAaY0DoDuxZO2xLJqgW+PVW9N/n?=
 =?iso-8859-1?Q?0qsQjwy1x9B6ngNlYbOeTLGZ4K+9rpZogGABdmoZwgVRvT+rSr98+ccUsg?=
 =?iso-8859-1?Q?eMy4Ox2nmX9WP9+EO/wn1Szyvl3X29CdulgTR0EdlM3ZPF9znyPDCWZTQx?=
 =?iso-8859-1?Q?aMuSyTU+e+vGfqN4LBD00+GD3MhHxsZxVVslIlMjk9OdD10GovcCQASQlV?=
 =?iso-8859-1?Q?n9GI5EwcNta5ZTVtv0haYb0E9nJWmPzcLOOFsHXV1ewXP2RHCTEqQhJn7y?=
 =?iso-8859-1?Q?4d9mRkBlOI1DlWI4ZCCT06RnpXzKNoo2NmGVSKJUHlfr1/HoOeHENbM3sv?=
 =?iso-8859-1?Q?uSSaM3thTc+qKx3oYUBWkXwAkR62R+XeRmAWqtLAAoii3SbWujEEDPpgCH?=
 =?iso-8859-1?Q?kWHp/8GkVslKbcd4B3rTxSQJsFEN9pEBqHeFRI0Tkzhn9YjdnygQxvFwX8?=
 =?iso-8859-1?Q?YuFg/bZOnE6FRXnrV0lNCThyr9524eWbgEr81eBenE0diLMJUcSYP1xigB?=
 =?iso-8859-1?Q?v1kYv7C/AUC6jf7M3jmToxu97E7xjKcC0bmLW/BmYLRY3Ci2fplsAO0gKK?=
 =?iso-8859-1?Q?UuDvCaziNKY9+Kg4LrjtTIMICG5TWU/h7vVQin1RZ0UUCEAZaLnEwNtX7F?=
 =?iso-8859-1?Q?SjaQai1CSQq5LAQo9M/OdgoFIyzLcjuxXAi6is6m7d05X6+LRMGjkGCX0B?=
 =?iso-8859-1?Q?553bSYjASatB3P5HBjzEQEHa/gk3IsA9RCLotMVOLYv1S0JOrdccDKszdx?=
 =?iso-8859-1?Q?0QYPU1HLIfk+W+H/Wzymz0Hg8xNJNE/0RU9eTs05DJEGPsFdZKeYw0/paj?=
 =?iso-8859-1?Q?q80HD5EtiHrpkXYZPDKYp4Xe2GOZRxuCvJx2ObWPlkvVA9bDd93XHWZl5d?=
 =?iso-8859-1?Q?+9umSK9jmSS93N/cAuSdZEophBFxbsEfGhCIqQreBEC0YUwERAXtu7vFd8?=
 =?iso-8859-1?Q?v5tapmyqRUlJA6kqmqCOK0XB8m1nVSh/yiX9gFO7W7TO08mjJDmKwITWn2?=
 =?iso-8859-1?Q?LQqoeX8JhTxfQV5eCWDtW+vyG9FR7dV3VQFsnNJx4N8wMuv8pRLOmwwXYX?=
 =?iso-8859-1?Q?p2QiT6n8BMPP5Ug6qPHZI2wIs3OeQTemwDhjlYYHjm6K1IkXaXxZbnTOKj?=
 =?iso-8859-1?Q?dPd3jwXTaLhPNyEyCm6I5DEQpgvvKeU2s2EEFQQxvNnKmW5W39/H6zD+66?=
 =?iso-8859-1?Q?HFTg36Akw4B9D7/f9p+GvXrsQwaiF2HU8G075DP0vujrBVz4KwrEXMti8S?=
 =?iso-8859-1?Q?mw3u5pFAdQA+lzs+eab668v3CoEAn0lWMwS5kI3fst6hdwrENsFz3+gdg6?=
 =?iso-8859-1?Q?FOg/x9SzdWyH83ymieGTniIrWj7bFF04Dnj8eqK8nm1GZ59i/7IoTTvoy1?=
 =?iso-8859-1?Q?XjuK9ljQiZhSo7xgJBvB+GA2aXQQyHmqRPOYLGHj18pOsMTCOhZCzr1UZ6?=
 =?iso-8859-1?Q?Ams3an9L6HqWEc5AMnd0gjiHmCi0CxbmA+90JqPihQxBhIMXn8V5LvrubV?=
 =?iso-8859-1?Q?hHySk3R0GkxWemO/SgkfTt2ZL1DbsJaNTA9W1gn93UeT0zvaKkyyzwqxE0?=
 =?iso-8859-1?Q?/UMVRUDsyb2BzxUlX6rqJFOo1u942q9tuR0oEtCmymvEUIrTnKWT3ve8X3?=
 =?iso-8859-1?Q?erwgu+4ndvbdNdPEzRP0+lBWMtRoTw1oOrOJ2BR1fcu9TAg7kzsaph+ziw?=
 =?iso-8859-1?Q?aJFlZ9PwwGS+yZDlBFDIKUL3+Uzu5rqUA5U1Cei0cX36GSFzFJxgLphTV6?=
 =?iso-8859-1?Q?0xTkz7m4Rx8NjL6GTEFoO2poaHiA1C8Fbc+OktzvWkYaXQLUW27aj9N7SN?=
 =?iso-8859-1?Q?2Bq5uVYHq73FBTLx7ZQa+SXzYaoR9pXIhAcIzj3V88UYd9mIcdg6ttGefR?=
 =?iso-8859-1?Q?hs?=
x-ms-exchange-antispam-messagedata-1: E1uXODJbTO27hw==
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6786.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b6ef58e-e096-4976-202f-08da1d63b331
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2022 15:38:47.1030
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VPbDrPLC/c4XEiB14h53nPEZa9svYXcaolRd10Ta9rYKpuDdwPN1iBabmapCPvF+pNfGSmNdMLM4e9IPjUaf8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3528
X-Proofpoint-GUID: DYwIrhPtjBcKar1dbabsWKpjm5Zs50q2
X-Proofpoint-ORIG-GUID: DYwIrhPtjBcKar1dbabsWKpjm5Zs50q2
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-04-13_02,2022-04-13_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 phishscore=0 mlxscore=0 priorityscore=1501 adultscore=0 clxscore=1015
 mlxlogscore=672 impostorscore=0 bulkscore=0 spamscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204130083
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Wednesday, April 13, 2022 4:41 PM
> To: Sa, Nuno <Nuno.Sa@analog.com>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>; linux-iio@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Cc: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael
> <Michael.Hennerich@analog.com>; Jonathan Cameron
> <jic23@kernel.org>
> Subject: [PATCH v1 3/3] iio: imu: adis16480: Fix getting the optional
> clocks
>=20
> [External]
>=20
> The extended clocks are optional and may not be present for some
> SoCs
> supported by this driver. Nevertheless, in case the clock is provided
> but some error happens during its getting, that error should be
> handled
> properly. Use devm_clk_get_optional() API for that. Also report
> possible
> errors using dev_err_probe() to handle properly -EPROBE_DEFER
> error.
>=20
> Signed-off-by: Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>
> ---

This is a nice cleanup patch... But the subject might be a bit
misleading as it says "Fix". So I would expect a Fixes tag which
I'm not sure it's really worth it here. Yes, the code was pretty much
doing clk_get_optional() "by hand" but I think it was still functional.
So to me, this is more an improvement rather than a fix...

Anyways,

Reviewed-by: Nuno S=E1 <nuno.sa@analog.com>