Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liu Ying <victor.liu@nxp.com>
To:     linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org
Cc:     kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
        krzk+dt@kernel.org, andrzej.hajda@intel.com,
        narmstrong@baylibre.com, robert.foss@linaro.org,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org,
        robert.chiras@nxp.com, martin.kepplinger@puri.sm,
        Andrzej Hajda <a.hajda@samsung.com>,
        Jernej Skrabec <jernej.skrabec@siol.net>
Subject: [PATCH v7 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()
Date:   Thu, 14 Apr 2022 14:48:54 +0800
Message-Id: <20220414064858.405096-2-victor.liu@nxp.com>
In-Reply-To: <20220414064858.405096-1-victor.liu@nxp.com>
References: <20220414064858.405096-1-victor.liu@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVBURmdHbkVwK24yM0dWelNaT1Nvd0xyelpPTks5Rk5QRWZ6SEgwajJsSmd6?=
 =?utf-8?B?dStSbHhSbmpySkNYTXJRZGQvbll5RlNFdzd1OWxoRFJoRnRhNlhVMmo1MU9m?=
 =?utf-8?B?ejhpUDZHemRrdGdJNGtrMGFFWVI3eFExcnJ3aFhWekJGdzBYZnlPZ0FqRGFX?=
 =?utf-8?B?N1RkSGF0WDlXV1NNdklWTFpOMGpvV29QQW8zWVJWYTdMY3ozQ3RTL0JxWG5T?=
 =?utf-8?B?d1VISlpHd1NsclU1aytZanorcDFsOTlaV0l2eCs2MkZFYU5BT0FZY1JWekhP?=
 =?utf-8?B?eDU2WW5odVE5OU45L2tyY0ZuZWU1NU92d0p1Ry9QZloyc1hMQitkSmo5OWZX?=
 =?utf-8?B?UDNjU0w2REJyRTJva0JJQnNyWExXQk9TT0dKdEpzVUlwbFRCSXc4MmZEMGpw?=
 =?utf-8?B?UGY0V1NsUXJ4eE5rU2paTDFxUUkrWXZHSHFCbEh5Tlo2NUFtWHI2RWNHSEgr?=
 =?utf-8?B?OTlzbEpLZkZ2UFJGMmNJblJ5c1l2SWJSSzhQN3BWYTI4c2EzMVdXcy9nWks0?=
 =?utf-8?B?S2pBQUgxZGFxOVZpSFBtQW80cm5mUDNZck9kTzFNdlJNM1ZzYWd4TGNHeGE0?=
 =?utf-8?B?TFloNVF4cUtwUnVkYXpSQ2xzL2JkN2p3TWZoT2VkdmprMWxITzRaTUVaL2VW?=
 =?utf-8?B?RnVEVk1DY1AxcCtQYXE0cU9KcHFzZmF6OUZIWURSeXVMVUJnb0FETEJ5UERm?=
 =?utf-8?B?dG8xaUh0ZGUyc3JIZ2pSN0xSbDNkYUFka3BvcUdxWHF2UFYyWVBTTFVoUG5y?=
 =?utf-8?B?b2I5Z1NKeDlWT0tIeFVDcFZQczJKU2htcVRVUDlsbFcreXpwdDdLMW9GTW5s?=
 =?utf-8?B?SUVER2pkV3FEMXRYdS9vTmZwTW9QcHFHZy9MaDBKczJnNmlBR3Flc1JBblk3?=
 =?utf-8?B?dTdtTnk2b3lTVGNGcDArNEtLYTdadGt1RE42SXgzZ2VNU05WQitiY1pKWlVS?=
 =?utf-8?B?UG1vazcrM0p4N0lINERWTDArNnBKOW51aVNPdFlPdjNwaklVM0ZYRHhEMTBP?=
 =?utf-8?B?R2prQzk0WkYvODMwU25wYVZ1NFhnUk5Bc2xsMnFqZ21qRjFqaWNYNnByejU0?=
 =?utf-8?B?OVBWWHF5cWRpcTQzdzdQS0RDZnMzeFdXNGk1Z1d3dytZQ1NDLzlDNm5hV1Y0?=
 =?utf-8?B?RFRvZnJkeSswbUpha2RNK1NxQk1hMi96TmdhSlRza1NCZ3VKSmdGdnpoR3h2?=
 =?utf-8?B?ZzZPWk5DbXd1OU51MXEyVzE1WmVoWVQ4c3RQZERoeXE1b2doUDIzOXFLY3pE?=
 =?utf-8?B?TFdMV21lVUYvNUNhbXRxczIxN1l5NjhqVWN3bmV2dE5tdUltOFJ3UzJrR0pw?=
 =?utf-8?B?dzIyUjloaHdqSzhsM1BGL0tFRG9qdjFwZlBaNUpqa1VNeTFBM3N3Z09CUlBJ?=
 =?utf-8?B?aUVJZFNlUUNRcEZHWm9xQ0JyU2g0UkYrbDAzZ1d1K3VnZFhGaTByWFZSRFBN?=
 =?utf-8?B?a1dnQUJDcmtoSkUrTFIzcmg1cDR4VTQxdmJqM2krR2taWUoyemI3cnBNa3VU?=
 =?utf-8?B?NVFuZjRVTkp3ZFhOTi9kT0lDcnRvenozTDJuQTVSbGxPVGVxbXUrYXlRajB5?=
 =?utf-8?B?VXl0S1J3emRYclMvTkJ3RmtabjAzYzh1SUw0MWNPNWl3WnBtTk9qUkpJRXVl?=
 =?utf-8?B?TVlYc21rUHBvK3J6RDRjTkNWVHR3NGl5TnBDUVY5a2RlTGdQRDdSUmVIQ21J?=
 =?utf-8?B?REx6dHdHZXJLZlMydE5zajExRmE1OVd6ZW5LNjF4ZmJrL1lJVTduQ3o0cFEx?=
 =?utf-8?B?TlFncWV1RkdRdzFvOWNnSExuQjVucnQ5alFpeHVrd1hhTmRkV01kTDNZQmFH?=
 =?utf-8?B?Y28wbEdLamdwSWhQc3ZtYVlRaDh3YWxUWkQzM3QxM1hORHFNNnpzQUxYZTRj?=
 =?utf-8?B?ZnY5T1hROU9tRWphUTkxblZlWXFRT0hBaHk3MGpabjlmNzF4MjMxRi90MjB6?=
 =?utf-8?B?RzkvTTFhdHZwWmtlb0xrM0V6QmQ5eXkzdGdPOGZmcURCaVNJdGtvRGY2Q0VY?=
 =?utf-8?B?dkxTOXd3K1ZCNEVaUCtwa09Vc0xETmJJWGpEWVk3QUhvTGcvVE1BSHFGVHQw?=
 =?utf-8?B?TGdxV2VGNzA4MitmL09MbUNSV1V5RDZmOHUvOEYxM08rTVJGL2JXUFZYWlJv?=
 =?utf-8?B?RndSRGxiQjFQaURqYml2TEdKaXd3S3d3OUJHSHMwa1BYODZHVk5Gc2t2U1dT?=
 =?utf-8?B?VTdobHMrd2pDV1U1b01udmllOUUzMWk2T0szbjNIcVNYRGx2OXFSSjRtT0hO?=
 =?utf-8?B?UVloWTdDRmRlRFhQbEZwamdCVmxNY2dPL0FsZi9zMnl5bmxxcVMyL3BrQXpT?=
 =?utf-8?B?RldVSlBzcFRIZk10b0dEVWRJRTRWSjYzOUNSVmN0ZFhIZEpTaERmQT09?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51dc4fe1-8f9a-4cba-71a7-08da1de2a434
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 06:47:28.6529
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VePCckByugecxzg7fHppt8NfGoEomugMtQPtUylW95YBeVyYFxDABYBDCJe0BOo/HBjb//lZWqJ1Qqn81w2FAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9381
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp
works with a Mixel MIPI DPHY + LVDS PHY combo to support either
a MIPI DSI display or a LVDS display.  So, this patch calls
phy_set_mode() from nwl_dsi_mode_set() to set PHY mode to MIPI DPHY
explicitly.

Cc: Guido Günther <agx@sigxcpu.org>
Cc: Robert Chiras <robert.chiras@nxp.com>
Cc: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: NXP Linux Team <linux-imx@nxp.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v6->v7:
* No change.

v5->v6:
* Rebase the series upon v5.17-rc1.
* Set PHY mode in ->mode_set() instead of ->pre_enable() in the nwl-dsi
  bridge driver due to the rebase.
* Drop Guido's R-b tag due to the rebase.

v4->v5:
* No change.

v3->v4:
* No change.

v2->v3:
* No change.

v1->v2:
* Add Guido's R-b tag.

 drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
index d5945501a5ee..85bab7372af1 100644
--- a/drivers/gpu/drm/bridge/nwl-dsi.c
+++ b/drivers/gpu/drm/bridge/nwl-dsi.c
@@ -666,6 +666,12 @@ static int nwl_dsi_mode_set(struct nwl_dsi *dsi)
 		return ret;
 	}
 
+	ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY);
+	if (ret < 0) {
+		DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", ret);
+		goto uninit_phy;
+	}
+
 	ret = phy_configure(dsi->phy, phy_cfg);
 	if (ret < 0) {
 		DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", ret);
-- 
2.25.1