Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp1353883pxb; Thu, 14 Apr 2022 04:29:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyl27uCkTbJT4ojuL793bhZdwUWWLM376BxLy1Gu6a3RVNT/OIygVBeyBleYI08xn5jJ7tb X-Received: by 2002:a17:902:eb92:b0:158:5130:957b with SMTP id q18-20020a170902eb9200b001585130957bmr21827158plg.104.1649935795021; Thu, 14 Apr 2022 04:29:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649935795; cv=none; d=google.com; s=arc-20160816; b=omDcL3ud6801/5ybosi6YkBUcvEwvgc6bBT2e9YhGafXP1jej5J20Fky1SgQbgpeJA g9rpdRbtsEMG1c/YID7LUdgrJyhXbxeZmHAmQBN5GBNNlSNXTS5k2UzkC2f5g0PANnfG IsAdzRxze3VrxFBE8Abu7gFT66zT65L8Qf+DPK0O+e3CtYms18cUR2L4sz5QC/jTyxgB daTWXSXpkUXgf06wENxg6xj1UrqB6cshmncKSiSWBLpX2ntTAw15or3+UHzn0SIW2IQy LWtA6p6puDepCeupp59pL/VOjzfaYLW1s4S+glqDzqdpc4hUsbGHjE5VNyGaV/HJBNer i15A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=8lcWdwhuPJ77wSoBxo6l1BQD6zhyE6LgPjmwddeTmn4=; b=BG6gdEbUmSnN2zqrftB7labPy5VmyKkCaDWmZex7Hy5GUvcpKO0zqIl9f7Qx7xDpxP wxFfNAYUdm5ZFzte5z9M6meNKYZKmVDaC/44GEsWvYG5FEkpgAX3hAi5C/DpW/LK0PtW bF/U5XeZ2z23S1mgtcoNHC7+L6hXXBfhwClCkRhOhtbMkHvLkjzx8B56FkVICkMx3+fc qsS5PjQQOY2oWe0cJwRsyFQk3vkxSJmH9vj/GJeDzvYCum6j3NLvK64I3oxJs/l37yLL vAluBVmlv3uTJTL+vExmZyhUi4S5FeKs3vtsAkNVv9P04aXzBNXbl1EaGuZLRHdvHSCH T0cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y10-20020a63de4a000000b003816043eef5si7241954pgi.234.2022.04.14.04.29.41; Thu, 14 Apr 2022 04:29:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239492AbiDNBrN (ORCPT + 99 others); Wed, 13 Apr 2022 21:47:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239503AbiDNBrH (ORCPT ); Wed, 13 Apr 2022 21:47:07 -0400 Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD8A55FE3; Wed, 13 Apr 2022 18:44:43 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R291e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VA05hUu_1649900680; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VA05hUu_1649900680) by smtp.aliyun-inc.com(127.0.0.1); Thu, 14 Apr 2022 09:44:41 +0800 From: Yang Li To: agross@kernel.org Cc: bjorn.andersson@linaro.org, srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] slimbus: qcom: Remove unnecessary print function dev_err() Date: Thu, 14 Apr 2022 09:44:30 +0800 Message-Id: <20220414014430.19051-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The print function dev_err() is redundant because platform_get_irq_byname() already prints an error. Eliminate the follow coccicheck warning: ./drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/slimbus/qcom-ctrl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c index ec58091fc948..c0c4f895d76e 100644 --- a/drivers/slimbus/qcom-ctrl.c +++ b/drivers/slimbus/qcom-ctrl.c @@ -510,10 +510,8 @@ static int qcom_slim_probe(struct platform_device *pdev) } ctrl->irq = platform_get_irq(pdev, 0); - if (ctrl->irq < 0) { - dev_err(&pdev->dev, "no slimbus IRQ\n"); + if (ctrl->irq < 0) return ctrl->irq; - } sctrl = &ctrl->ctrl; sctrl->dev = &pdev->dev; -- 2.20.1.7.g153144c