Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3805180e-a5df-7a5e-ce08-1a998a8bcf69@linaro.org>
Date:   Wed, 13 Apr 2022 21:27:04 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3 07/18] ARM: dts: qcom: reduce pci IO size to 64K for
 ipq8064
Content-Language: en-GB
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To:     Ansuel Smith <ansuelsmth@gmail.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Jonathan McDowell <noodles@earth.li>
References: <20220309190152.7998-1-ansuelsmth@gmail.com>
 <20220309190152.7998-8-ansuelsmth@gmail.com>
 <a7034b5e-24de-ef17-ae93-c626beb35a41@linaro.org>
In-Reply-To: <a7034b5e-24de-ef17-ae93-c626beb35a41@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 13/04/2022 16:19, Dmitry Baryshkov wrote:
> On 09/03/2022 22:01, Ansuel Smith wrote:
>> The current value for pci IO is problematic for ath10k wifi card
>> commonly connected to ipq8064 SoC.
>> The current value is probably a typo and is actually uncommon to find
>> 1MB IO space even on a x86 arch.
> 
> I checked other Qualcomm platforms (including downstream apq8084.dtsi). 
> All of them list 1MB region as IO space.
> 
> Interesting enough I couldn't get PCI to work on my IFC6410 (apq8064). 
> It has an ethernet adapter AR8151 sitting on the PCIe bus. The driver 
> probes, transmits packets successfully, but receives only garbage. I'm 
> not sure if it is the hardware or a software problem. Same adapter works 
> fine on db820c.

I noticed that it looks like the packet is shifted by two bytes. Maybe 
it's some weird maths somewhere. Maybe it's the lack of iommu on 
apq8064. Anyway, it seems to be unrelated to the issue being discussed.

> 
>> Also with recent changes to the pci
>> driver, pci1 and pci2 now fails to function as any connected device
>> fails any reg read/write. Reduce this to 64K as it should be more than
>> enough and 3 * 64K of total IO space doesn't exceed the IO_SPACE_LIMIT
>> hardcoded for the ARM arch.
>>
>> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
>> Tested-by: Jonathan McDowell <noodles@earth.li>
>> ---
>>   arch/arm/boot/dts/qcom-ipq8064.dtsi | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi 
>> b/arch/arm/boot/dts/qcom-ipq8064.dtsi
>> index e247bf51df01..36bdfc8db3f0 100644
>> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
>> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
>> @@ -918,7 +918,7 @@ pcie0: pci@1b500000 {
>>               #address-cells = <3>;
>>               #size-cells = <2>;
>> -            ranges = <0x81000000 0 0x0fe00000 0x0fe00000 0 
>> 0x00100000   /* downstream I/O */
>> +            ranges = <0x81000000 0 0x0fe00000 0x0fe00000 0 
>> 0x00010000   /* downstream I/O */
>>                     0x82000000 0 0x08000000 0x08000000 0 0x07e00000>; 
>> /* non-prefetchable memory */
>>               interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
>> @@ -969,7 +969,7 @@ pcie1: pci@1b700000 {
>>               #address-cells = <3>;
>>               #size-cells = <2>;
>> -            ranges = <0x81000000 0 0x31e00000 0x31e00000 0 
>> 0x00100000   /* downstream I/O */
>> +            ranges = <0x81000000 0 0x31e00000 0x31e00000 0 
>> 0x00010000   /* downstream I/O */
>>                     0x82000000 0 0x2e000000 0x2e000000 0 0x03e00000>; 
>> /* non-prefetchable memory */
>>               interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
>> @@ -1020,7 +1020,7 @@ pcie2: pci@1b900000 {
>>               #address-cells = <3>;
>>               #size-cells = <2>;
>> -            ranges = <0x81000000 0 0x35e00000 0x35e00000 0 
>> 0x00100000   /* downstream I/O */
>> +            ranges = <0x81000000 0 0x35e00000 0x35e00000 0 
>> 0x00010000   /* downstream I/O */
>>                     0x82000000 0 0x32000000 0x32000000 0 0x03e00000>; 
>> /* non-prefetchable memory */
>>               interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
> 
> 


-- 
With best wishes
Dmitry