Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp1451451pxb; Thu, 14 Apr 2022 06:35:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8zMVsbXwwoNWb6egeYaS8spvp/IW1sysuMT+0KUUmCQL9XywGus6xjIgb4bEAWkDjdZ1M X-Received: by 2002:a17:902:e94d:b0:158:2f50:d04c with SMTP id b13-20020a170902e94d00b001582f50d04cmr28178123pll.11.1649943304743; Thu, 14 Apr 2022 06:35:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649943304; cv=none; d=google.com; s=arc-20160816; b=QaCK3GYUOdf23hllcRTG40DOch+DG5D8488CAhtNUVaV4xLpsWeWQEz/OZ6LJkqvBb 28DkRc4b/nKPdyfh0s84xnFrJ6nLqgpyV8W1LtEoEga6MsnbGfojQcfXQL/GKtNfKAxZ FMg4CMpDrl2eOO0gvVxmt9otx7MqFxkx/UvX3PDTLgwefNQCAbBVz9hJJOT/C6Afu+4B 6MigrABEiStmxik59//Asz9Rm2VhiOjbUpjx3b1weT3HEMIEYXAteVogzfJ2Aenl1nDr VpmtqGozYCO4He31ju4Ko/r1J8DXOhG/U8RPVCCrO1Tku+ACgDF65WaOQIAiLn6tHuBw j1gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uc7ry7HIsnf2r8nUN2XsM9Cr609Rg9Ev/nf0gRDdVjA=; b=BVenHt1eN/yjDRjfyFrg2bfJOBb19Ya66g6U9PxrSToFZmo2Y5hvg6e0/fEaNqIjtZ VpkJluC7kS2NdNxVzohc0jdhipK6nEsFOU+bUyHPF/JA+kvSynnYaoGZifM3zPnbGrWL L975JZhWd4TlmVpul7HtGIT0HAHfyVsp3UK4bSEGPR6EOORZrwm7bPE+Cj0erx5echqn K1Z82SNJwkq4KhGUGyzuwOZizIqMlCM9UPVuQ0+xnbscDJU/V79Ez1CLbQXATiVJkEVj 9iBT3niqFNWX08Uu648w1lzT2lEhjhUICdzY2NvJlrxPfJQGcAx/6c2uPu0Pu/pVxoz3 sLqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J0EA2TPN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 20-20020a630114000000b0039cef73106esi8303785pgb.511.2022.04.14.06.34.50; Thu, 14 Apr 2022 06:35:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J0EA2TPN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239530AbiDNCk0 (ORCPT + 99 others); Wed, 13 Apr 2022 22:40:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbiDNCkX (ORCPT ); Wed, 13 Apr 2022 22:40:23 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB15E237C0 for ; Wed, 13 Apr 2022 19:37:58 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id bh17so7450437ejb.8 for ; Wed, 13 Apr 2022 19:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uc7ry7HIsnf2r8nUN2XsM9Cr609Rg9Ev/nf0gRDdVjA=; b=J0EA2TPN5DF45RPQJxsxLx9xc2kpvx4GDfs7GmNxtpSy3srw/qZOuOOnaLJe6pfBYu nJ/8EahmmrlsMrZxJ/kmV6hFdQWckTo0h2YFcNcLs91EfnKG7MFj7PRJwvOvDAC+Qvt5 jdt70t/HBqRAc94klhFS82Q1W/wvvCUC9JARqYX130KlM26o7BehHtm056rttE2ManH2 2qs+554u0U5lgCRra3W/8vKH7jA61mqurSeavoBH4IQE3BSH2mBVDdWKGKH0Ex4wXrr+ IddfVTGZEU/Ef78FbKae3ynglEcgS+Q13QmkIoi0KIZKOiyE9B/6zeEiBRbZO5PsCWMz vQxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uc7ry7HIsnf2r8nUN2XsM9Cr609Rg9Ev/nf0gRDdVjA=; b=lDXnL0AfibbtYVWoGXWAu+EraKKl1DpovOhIYhWljyXeoZwTjTZxButPTQu2sawShu EarlrjmtryT7xw3wBXJzyEC1u78+AGcTJtJGr9Vt9qmi1jmnBCQP8Ft4TVAQAK2iVK81 z5XBWpPzWIvj9lMBzZgqemf9PWZ3kMscTsjKJHVQoUgxecFGXL7jLSD9JvndVkhlYXkj VbkmLabMQVMiEyoG+e4opXp3QbD3LvvWPnVDJpnCcU29/xnlGZOMAlSOYk84yjREsC1b q0OwCWa5FRN3qkG5sR7KH3WbZpj/RTS3G/XtDK6oyNjkXXHZi7XsnOpbZiqq9nWSAL56 n6tg== X-Gm-Message-State: AOAM531Xc+psWOcGWM2UeTYG+I5m/47MqYpfkvNZZ3/BN5d1RCYc1gns CQyiszxi1slwNyorbrzOJyFyzA== X-Received: by 2002:a17:906:7314:b0:6df:839f:af7 with SMTP id di20-20020a170906731400b006df839f0af7mr497470ejc.65.1649903877223; Wed, 13 Apr 2022 19:37:57 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([104.245.96.34]) by smtp.gmail.com with ESMTPSA id lg4-20020a170906f88400b006e869103240sm193616ejb.131.2022.04.13.19.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 19:37:56 -0700 (PDT) Date: Thu, 14 Apr 2022 10:37:51 +0800 From: Leo Yan To: German Gomez Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf arm-spe: Test memory samples Message-ID: <20220414023751.GA539224@leoy-ThinkPad-X240s> References: <20220413010221.81332-1-leo.yan@linaro.org> <21978774-356b-bc08-ba68-80d877e2b6b4@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21978774-356b-bc08-ba68-80d877e2b6b4@arm.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 13, 2022 at 06:17:18PM +0100, German Gomez wrote: > > On 13/04/2022 02:02, Leo Yan wrote: > > Add a new test to verify the Arm SPE synthesized memory samples with > > 'perf mem report' command. > > > > Signed-off-by: Leo Yan > > Reviewed-by: German Gomez Thanks for reviewing. > Thanks for the patch. > > There are some tests for perf_event_attr fields. We added one for SPE > recently [1], but it's not checking the sample_type attribute yet. > > We could update it from our side and send another patch, to test the > DATA_SRC bit is not missing. Agreed, it's better to update the patch for checking DATA_SRC bit and resend it. Thanks! Leo > [1] https://lore.kernel.org/all/20220126160710.32983-1-german.gomez@arm.com/