Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Marc Zyngier <maz@kernel.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        'Linux Samsung SOC' <linux-samsung-soc@vger.kernel.org>,
        John Garry <john.garry@huawei.com>,
        Xiongfeng Wang <wangxiongfeng2@huawei.com>,
        David Decotigny <ddecotig@google.com>,
        Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v3 2/3] genirq: Always limit the affinity to online CPUs
In-Reply-To: <878rs8c2t2.wl-maz@kernel.org>
References: <20220405185040.206297-1-maz@kernel.org>
 <20220405185040.206297-3-maz@kernel.org>
 <CGME20220413145922eucas1p2dc46908354f4d2b48db79978d086a838@eucas1p2.samsung.com>
 <4b7fc13c-887b-a664-26e8-45aed13f048a@samsung.com>
 <878rs8c2t2.wl-maz@kernel.org>
Date:   Thu, 14 Apr 2022 12:49:38 +0200
Message-ID: <87mtgodjnh.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Wed, Apr 13 2022 at 18:26, Marc Zyngier wrote:
> Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>> This patch landed in linux next-20220413 as commit 33de0aa4bae9 
>> ("genirq: Always limit the affinity to online CPUs"). Unfortunately it 
>> breaks booting of most ARM 32bit Samsung Exynos based boards.
>> 
>> I don't see anything specific in the log, though. Booting just hangs at 
>> some point. The only Samsung Exynos boards that boot properly are those 
>> Exynos4412 based.
>> 
>> I assume that this is related to the Multi Core Timer IRQ configuration 
>> specific for that SoCs. Exynos4412 uses PPI interrupts, while all other 
>> Exynos SoCs have separate IRQ lines for each CPU.
>
> Can you also check that with the patch applied, it is this path that
> is taken and that it is the timer interrupts that get rejected? If
> that's the case, can you put a dump_stack() here and give me that
> stack trace? The use of irq_force_affinity() in the driver looks
> suspicious...

It's pretty clear what happens.

secondary_start_kernel()
  notify_cpu_starting(cpu);
    exynos4_mct_starting_cpu()
     irq_force_affinity() -> fail

  set_cpu_online(cpu, true);

Thanks,

        tglx