Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp1508800pxb; Thu, 14 Apr 2022 07:41:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuOTN6iz/Xg1qwJtJqR1kMU8XQfzaIJlsqJVn5sMs+dy6VWtBrVwamLX4RHuBson2W6YsA X-Received: by 2002:a17:907:1c11:b0:6e8:d305:1126 with SMTP id nc17-20020a1709071c1100b006e8d3051126mr2539679ejc.432.1649947272999; Thu, 14 Apr 2022 07:41:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649947272; cv=none; d=google.com; s=arc-20160816; b=zp46SnUv7CVTr363pmxwKDmY+GKPSIZ2oYnPPdQiNLHKJLHwByIpEBP0E4phKOtZH7 zu0vN4BfZm3ni8zN/4htv7SgPz+pK452gJ/jgBdb0jN8wF4HJbD3itW27eaSoJrTYX84 vteaz83foWctj6EXI+wtuFBi/wW/hOGL9WVaPvZjUsGwUhv7UpPmnBoTPuLgtSC3b1dH QUYZV/FeozHEI4k1OPkfopiLun9d2jRjBMqP2/psf4n/r/lo3bRlMmcKTmrIn4h9U9ot CjQwqC6gbVXHXUG4PSAMO7z+PftU5+UBXbU/ZlQ6367QT8ylYLbalqJId6GigxDU55WT TTOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=nTUAprv6XG9OcuDZYNH2opUhPZ8GJfLaCd84jjh7Cp8=; b=Io8+NkWiKaKIyWcYvb70rYShualSeC5YBR8Bws4t30EVUBClbiPz1ij7Cx8oXhjHpr 9ZW+9MMNhAkFvL0pOuErRC3IUdot2INzca4z4oyZ/fjhtx9ESRVugjemNiEOF9PHv8z6 XcSmfmXnbTvi+/7CraVPp2azvB3zMKj4vXsWIgbiAba9/MXfcajj4g8sNrlSH1ztZwkQ +aXwZppG2nUUYqvsiDtTaRkHjIahO7LP48GZG0KB9857PrFEpCpQsS33W5ErhNpcGgF0 mgOav5NczP46QGCh5SKINbU3WAEWqeCip8M4CKF7y6jAKrkIbolUTAdlBg2b3+f8Tkgj 56HQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gc9-20020a1709072b0900b006e8837e758esi1850135ejc.581.2022.04.14.07.40.36; Thu, 14 Apr 2022 07:41:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236847AbiDMQnR (ORCPT + 99 others); Wed, 13 Apr 2022 12:43:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234493AbiDMQnR (ORCPT ); Wed, 13 Apr 2022 12:43:17 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 293C437AB0; Wed, 13 Apr 2022 09:40:55 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 752F768AFE; Wed, 13 Apr 2022 18:40:52 +0200 (CEST) Date: Wed, 13 Apr 2022 18:40:52 +0200 From: Christoph Hellwig To: Baoquan He Cc: akpm@linux-foundation.org, willy@infradead.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, hch@lst.de, yangtiezhu@loongson.cn, amit.kachhap@arm.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH v5 RESEND 2/3] vmcore: Convert __read_vmcore to use an iov_iter Message-ID: <20220413164052.GB31487@lst.de> References: <20220408090636.560886-1-bhe@redhat.com> <20220408090636.560886-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220408090636.560886-3-bhe@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 08, 2022 at 05:06:35PM +0800, Baoquan He wrote: > From: "Matthew Wilcox (Oracle)" > > This gets rid of copy_to() and let us use proc_read_iter() instead > of proc_read(). > > Signed-off-by: Matthew Wilcox (Oracle) > Signed-off-by: Baoquan He Looks good: Reviewed-by: Christoph Hellwig