Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yihao Han <hanyihao@vivo.com>
To:     Shahed Shaikh <shshaikh@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        GR-Linux-NIC-Dev@marvell.com,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] net: qlogic: qlcnic: simplify if-if to if-else
Date:   Wed, 13 Apr 2022 20:11:09 -0700
Message-Id: <20220414031111.76862-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yOQFyxcYPygy3reV0Tas4dhYclDDV2Nl9GhqDDbpVppTdYwhp9J7DyyzHq20?=
 =?us-ascii?Q?Q+syzTdsxuyMZFBTuFxo2GBtDGTvTQ1T4EHbzUg1+JfWyjGd1gjYwD2Zqp3G?=
 =?us-ascii?Q?EAcPTWrihC+pm3D7yQSQxp2oTNUClm2nm3Ku+nNR7fsIhL1AxCX9hCIze8Qe?=
 =?us-ascii?Q?fgr8mgMrOeDqUQGOyKRskjQ4+JhslhVboSJP1AwSurOkfeM8XSgvFS2He77b?=
 =?us-ascii?Q?c+GCQUCoCkzqxFjNvGbajdu2IcuvV2WveuMMTCVqKWvLLKWHry6ZBv2heKQn?=
 =?us-ascii?Q?9BxkyYMC8OaVW0uI3vqGVIz4muuzroicwO0p4fyPEfQtmbPhBBusC0MVPB4r?=
 =?us-ascii?Q?7WGA1PIC+l7DEJqkplv03/joDxRqdsl4sXTuFIberi1CRrqmpMWuaWePsMnK?=
 =?us-ascii?Q?Xei0pZhiQ6Zuay9E8x8xmtsILDyDBo8ZPNpY/OaZ0sH/EfeGbxFDG09oqDqp?=
 =?us-ascii?Q?upmxh4PyfcirqUJtrE5qf2jVAlTHmSgUU642RHc16QhWD65q5dbJCba0KtNG?=
 =?us-ascii?Q?ebsO47vC1up/JYJxMvn/wojKjILat9AiI2m9YnnlIG8jDslc2Cqsb3aHzprR?=
 =?us-ascii?Q?G05ntdQrtNHSVUx1B4Zbj341a5sk2PSAqBTIFO4WiPYivgRQ9cJuotYUd5l9?=
 =?us-ascii?Q?tMdQuzoBpb43YGtCJRq34acxGOcOWAgmbP0lMIJE5gu2BCYaxYc0g/gPfk/s?=
 =?us-ascii?Q?L07WTvEDVAbcdFj6E/k6vB8zel30l3TyABxr24qZJXlJaWRYlEBK4Inr+iur?=
 =?us-ascii?Q?8S1VjUtXi56MVeCt2cmOTnz1ltiDy1hnlM3h2K6h4+K+8bnnl6/8RacDBYQb?=
 =?us-ascii?Q?Xmsf8T/8YjHm9jrRjM0JhKdK5rsAAYV3TtnBM4PkIgnu/0aqFOoC3bcn3ucf?=
 =?us-ascii?Q?pKxHrrOT7894HY3/W9aqcNO4Uslo/YF7tiznsHP78egJzWIvuH76yeHtWgh+?=
 =?us-ascii?Q?RbNXR9IS3fxH4YSONEnlITLlgXIxsEAnKUZn0SmxLTPwDLFYoxfQPGjL8zT6?=
 =?us-ascii?Q?8ssAxuYUB767TP48ILLNazBPOREwP3xkyxjRLxgOCTFcddP4N8G0oUosJ2Gq?=
 =?us-ascii?Q?1omeH83q0JRd5tpu0ydzn0QlOYnpORltsLGV+SJf64PaEvc+a3dxrKfNjsay?=
 =?us-ascii?Q?gIjGNjgMWIVRdfxr5ogAVE5OAFwzB3cg+PRVTCssNTaRPxFA/7hjDmErSBVU?=
 =?us-ascii?Q?Sbncs4QHrqlWtgrp+NjYhePZpzzrbEExPkPkHoNa88F8TCvOQ3MLa9FZW0EL?=
 =?us-ascii?Q?LtaEdexNRb1ezxGonM2g4gVSvkXUgn3kNNqAp99K7zhBb5JrGmEWe2aFC0HA?=
 =?us-ascii?Q?LyG8dko+h+6hld7FS8teD7EQqg64eew7yX+1UyVgTucIUahxtZCM4sX+cBmV?=
 =?us-ascii?Q?AmEwm8p0Ymets/8UccYkdV6Pfp5D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46bd10b2-3150-429f-b65e-08da1dc479f3
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 03:11:32.5029
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AsMXPiC6q85f+3pnb51eQ31vjDPSYWh1rwJjb+wUXN1YT40a03oZr09Fv/im+bh6Me+WVojueMfQisedXHtJaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4452
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Replace `if (!pause->autoneg)` with `else` for simplification
and add curly brackets according to the kernel coding style:

"Do not unnecessarily use braces where a single statement will do."

...

"This does not apply if only one branch of a conditional statement is
a single statement; in the latter case use braces in both branches"

Please refer to:
https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
index bd0607680329..e3842eaf1532 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
@@ -3752,7 +3752,7 @@ int qlcnic_83xx_set_pauseparam(struct qlcnic_adapter *adapter,
 	if (ahw->port_type == QLCNIC_GBE) {
 		if (pause->autoneg)
 			ahw->port_config |= QLC_83XX_ENABLE_AUTONEG;
-		if (!pause->autoneg)
+		else
 			ahw->port_config &= ~QLC_83XX_ENABLE_AUTONEG;
 	} else if ((ahw->port_type == QLCNIC_XGBE) && (pause->autoneg)) {
 		return -EOPNOTSUPP;
-- 
2.17.1