Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ming Qian <ming.qian@nxp.com>
To:     mchehab@kernel.org, shawnguo@kernel.org
Cc:     hverkuil-cisco@xs4all.nl, robh+dt@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, aisheng.dong@nxp.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/2] media: amphion: copy timestamp from output to
Date:   Thu, 14 Apr 2022 17:00:28 +0800
Message-Id: <cover.1649753692.git.ming.qian@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NIgXYe/fx1WdRDY7IpYlONKDeNYXq6jhnzAd8ZtRi98hGa1ZcCeimNRhtF5S?=
 =?us-ascii?Q?f9nBry2HiPnGXtvSfwcuzD9hYWafsFunbPkLi1mrb7tTqbSWgZ9nuSsWJX6V?=
 =?us-ascii?Q?xueF7GqDswHL1xGDSkoL+5R1bFMk7rr71EF6vryFXinr2Fbmcp64yvI3K10m?=
 =?us-ascii?Q?A7OQIB5j1gadI/RVwpA4+TooPaBABK++yUbgV1Z1XoioEoBQDQxrRDaZPwaD?=
 =?us-ascii?Q?L5Yn4nGm9ReBzk/cVIsV/3ncNGEGjUpAb4El6mgKfLDJiaJatBL56J4rE9Do?=
 =?us-ascii?Q?S1MfAmRf7jh3TBhTwhZttXaSVhGXLYgFont+VERXVzKdeuLP3zQVQv+9NM7Z?=
 =?us-ascii?Q?Mq6c8zsje6rVUyu+QRC+LYvaP/W1YC/z7iCmhtxxid9QNILPUbd29Apd/aYn?=
 =?us-ascii?Q?/rzcGLKguwxFcPVOq+keFwcj0dr7QLFdcH75c+3GwDYx8Z3MrJ8cakp8YxjM?=
 =?us-ascii?Q?mJZHbVHw5VS3JzJHWyuw5GnfD3pTNXr/xTJdTUNACAzd+X6R+phK+n0qDaeq?=
 =?us-ascii?Q?E6pjWVlzJLSFvyHzTZ8IEmsFYmPaMmUyPB3RDy6Btn51TC6WX+qkFEfnzZee?=
 =?us-ascii?Q?pO1kv4BMtZl0RH6Q5ZtFcpQH4tbEIT/oTLqHsNhqpX6MinfcsgjCfOB37ycl?=
 =?us-ascii?Q?KmXGakVq/PAEq6/TuLh1S9NmVdiRQO6o0nlGW84s0ib3kNO5Oiy5Tujnu91O?=
 =?us-ascii?Q?+VEdDEkrZKHIykLg9tkGacooj9eZnI/t9+s9UrQ3fPFCr7Y+LPH+9+QCfUpo?=
 =?us-ascii?Q?7eYMkos4Oqal4MmVjpi1q/NiU+0KNlD5ZEzNDRShCVgp/M61ld3wKcExiSow?=
 =?us-ascii?Q?K9BgRq/QNY2jAcSunioeShRGHGn8dgwgNsRmuBozQFhy+C5+tdhanak7lLd7?=
 =?us-ascii?Q?eMLsdMsDEpmwMDOR5TVzMf32bTcxtjCO3CvdAIUshRb89XXoRfZYXJbvdnGW?=
 =?us-ascii?Q?ccS9ya8+gWflIwyA+XWJtZTDwEsJ2gACamnJ91JBdOhjb/my4jXUYDgX67dl?=
 =?us-ascii?Q?ANjd0ACh8hmK/yEML1AOkiPDCQc9dfYIUSWkHyOei9buCMwci7J2kLtONk2K?=
 =?us-ascii?Q?1C8vJ+JbHu2PEyCvEPz3jqsNqFyxxEiaKaLdxAq4IUn4GV62ghq2g93s+Dd3?=
 =?us-ascii?Q?hCxJCXxImYeIcdoUnI7K6HPduhgkxGzMp2mNWmjzTFPe0OPvLEFDzC/DD+ZT?=
 =?us-ascii?Q?uwHcSgAAQ3ZH3M7n3uT4rkxeg9J5egtGjnwvgQspdE7LfJ4F9IC0NAdL/k/s?=
 =?us-ascii?Q?Rxzr8o3TsAZD7KEazfvLodTOYbIFjiAEwvy1JWXjSlSqRWDj7/PyhbBcmQk8?=
 =?us-ascii?Q?AH8H/4Vo2effxbslvlBl12HhN2SlTA/f/nj4g/Ivg0nXaO4Nkyr5lM3DXcGM?=
 =?us-ascii?Q?ZPxNcVV96v26aCaP63RXiMp3UWnUSmEv17RJ76E/2QXqYwotnm+U77vCK1G/?=
 =?us-ascii?Q?OfD/+iiznEO9fkYTPz0hB2TGz0hV8TSN4nJ4eLlBu17x3BuADQdahO9eMt9o?=
 =?us-ascii?Q?R3eQLWXoaeZBoV8xJJo0+HLnqerLSQLnDK9Fqe2Jm26c/w3RkiizZmH83wMt?=
 =?us-ascii?Q?pFpaACyQgSFBdm9B7iwQz8CUyw6ZuhBUH4jW37P+5lCDvSBZHoeERU7DzRUC?=
 =?us-ascii?Q?OGKjIhgdtd5E2x1pjzP+6PdWl02FxdgXWfqO25MB2gR5ZF1YdNjMs8Z+hylN?=
 =?us-ascii?Q?3LUAleM8rJ/qd6u9f0/K9KEK/PHqXqKvWVVOVcOrOlAOwU7JWUwiKL27xIpa?=
 =?us-ascii?Q?B8w8z6kYCw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d741faf-076d-466b-7b05-08da1df54fe7
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 09:01:07.4234
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GwfZB3kiUc+1FEqT/Vj1pSEqpGl5X8iPTQ86WSjlNAGW0gAaV1Nxb/tx/u3c4mTNr111wYaJsQ7TMfJL50MCXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6885
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

v2
- reduce the min buffers count

There is a timestamp manager in firmware,
so in previous, driver will pass the timestamp to firmware,
and when a frame is decoded or encoded,
firmware will pass the timestamp to driver,
then driver set the timestamp to the capture vb2_buffer.

But there is problem that the timestamp manager will ensure that the
timestamps are monotonically increasing.
So if there are reorder frames, the capture buffer's timestamp is
inconsistent with the timestamp of the corresponding output buffer.

It goes against the description of V4L2_BUF_FLAG_TIMESTAMP_COPY in the
specification

In order to comply with the specification, driver should copy timestamp
from output buffer to capture buffer, and there is an helper function
v4l2_m2m_buf_copy_metadata to handle it.

Ming Qian (2):
  media: amphion: decoder copy timestamp from output to capture
  media: amphion: encoder copy timestamp from output to capture

 drivers/media/platform/amphion/vdec.c     | 89 ++++++++++-------------
 drivers/media/platform/amphion/venc.c     | 47 ++++--------
 drivers/media/platform/amphion/vpu_v4l2.c | 13 ++++
 drivers/media/platform/amphion/vpu_v4l2.h |  1 +
 4 files changed, 70 insertions(+), 80 deletions(-)

-- 
2.35.1