Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1bd1ab210eae96fdd0280b9ef6876ae918d48cb3.camel@nxp.com>
Subject: Re: [PATCH v6 resend 2/5] phy: Add LVDS configuration options
From:   Liu Ying <victor.liu@nxp.com>
To:     Vinod Koul <vkoul@kernel.org>
Cc:     linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org, kishon@ti.com,
        robh+dt@kernel.org, andrzej.hajda@intel.com,
        narmstrong@baylibre.com, Laurent.pinchart@ideasonboard.com,
        jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie,
        daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        agx@sigxcpu.org, robert.chiras@nxp.com, martin.kepplinger@puri.sm,
        robert.foss@linaro.org
Date:   Thu, 14 Apr 2022 14:35:29 +0800
In-Reply-To: <YlezKAw+W8HOa322@matsya>
References: <20220402052451.2517469-1-victor.liu@nxp.com>
         <20220402052451.2517469-3-victor.liu@nxp.com> <YlZpnrKt9NbHZv26@matsya>
         <d77b41d911e126331138ddaca146a581d316bd09.camel@nxp.com>
         <YlaqwoFCfusFgIIe@matsya>
         <a2731b2d77f9bf2adf36f0c05cb5e3b14a5a91a9.camel@nxp.com>
         <YlezKAw+W8HOa322@matsya>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0JZQTA4dTRRaFZDOXdmNGFDcUlFRXhpU1dEeml6eG5zWkNDUTVoYlJLR2Fa?=
 =?utf-8?B?azNVY3UxbVg2Z2JUM2hOMlNpblFZRFhLeHI1MW13OWViUmRCaHcrUk9JY25a?=
 =?utf-8?B?RHd4NU45cDRWcU9NL2tpM04xcEpTQmc2UDdhYzM5QUtBWXdmSFFhbTl4T3dh?=
 =?utf-8?B?UGl4T3dqSncvSllQcVBid1NpQlFNSWprTUluRHdSTlJDcm85ZHNIM3FuWjht?=
 =?utf-8?B?MUcrYnd2RDlSZzlvQlkvbzF0aGRKcDM2L2xlN0tuUmxienJKeDRHVS9Jd3ZT?=
 =?utf-8?B?MlhsN1h0Rkk2akx6Ym11L2QxQXRkYVRXQ0s2V1pJN1FUb0k0K1FoK1kyOStX?=
 =?utf-8?B?WkExd2RwanhvQ0pHWGFDaDRkZW43bERvUkR2RHFvUUtheEk0T2FWb2RkZUZ5?=
 =?utf-8?B?VXRwdi9ZREhvbFA3OHJqaGpRWXJBVXJwQW5MMjBMMnFqRFF2dXBNbXhBdDFB?=
 =?utf-8?B?cXNEU2RaK2pGZGhKY01Qck1LY2drZkcvM2ZxNUdNTXRpOTZHcEZQWEM0N1V0?=
 =?utf-8?B?d2VuS25wUUJhc3BHanZJdjNBbEk3YTBXeUxGdnoxa1ViTVBVUDhsOWF3M2hW?=
 =?utf-8?B?OEp0b2llUTczbnFTTVg4Y2VlY0I2bnRKMFNEbjVqSWd3OTcvY0JYNW1hZjJu?=
 =?utf-8?B?MEdsK1oyalZZaVVqbmpsWDR3ZU5kVFFZYzVzVGd5WlVTVEd1QkZNeDlySXpk?=
 =?utf-8?B?WDNpREw3SVFnLzcza0I0b3F5dTV5VWpDRkhiaG1iOVh1VGx5TG5jbXBZczRl?=
 =?utf-8?B?N2NUdk9XRmFoM2lCaGQ5TUlQQXc0Q2Q4d2daVzZRMTBuTk5LL0ZuUGVMM1BB?=
 =?utf-8?B?c0VIQ1pzZVNKekZ2di9sV1pkcW5TcWFEeDRhb012dmhxeVYvN1RuaS8zNVdq?=
 =?utf-8?B?dXZPTkFtcGc5djFuWm5yRnlrUFRHazhEdUJWMkN0N2tLdXhQR25hUUVLZjQz?=
 =?utf-8?B?MGJlZDFRSDlLUTBCbWNpRjVjZzZDLy9HYXhEWHRXMm83b2hKcXVNOUN4dlFU?=
 =?utf-8?B?aWwvQzdhVWdUbk04c1lNTjMvRkYrT1A4RHdCSzZvVDNscmZ2Si81TzNIYWxw?=
 =?utf-8?B?ZnRLWi9ISlNrVm9XRE5vMnJsREJPTWhMMjJOTjI2bklSaHdGWVEvSlgrRytS?=
 =?utf-8?B?SCt0Vy93MTlxZ25CdFc1VFY1aDloM2FKL2g1TUV3eDNUUVdYZTFaMWp6bldP?=
 =?utf-8?B?My9ZZEN0Tk5uV2hhY0h4RnBtU1dMbnY3U1N5c2swY3NOTFYyNlZEd20vRHZj?=
 =?utf-8?B?Y2pJeVVPU2x0bE51dmYzTHRYUHloNXIxd2hjNlppQWEwaFVuQTM5bjNQRzRv?=
 =?utf-8?B?aUFNUVhSZ2czU2J5UXBXamVlWEc1ZDdOeTlSTnZkUE1lRUtNOEgxQWgxekR1?=
 =?utf-8?B?WCs2ZUJFRDI2MDFVZXlqRU9LcnFsRTVuZUxXYURZRE9DRjlCaWd1UjRQOFU2?=
 =?utf-8?B?aHhqdUZkSXlydjVrY2I5QUhPNWgyM0VRWXZuZE43b2l3b1ZHbU5RY1IwWEky?=
 =?utf-8?B?Z2pkaTdjbXVFS1NzeDhkbTdlV2VTM0pVVFZ2S1dJZVhhZFNmbUlBclkvdXBz?=
 =?utf-8?B?SGdaN2Z0VURLN0FNL0ZOWmRlWkRldXpGbUoxVUN6aFlYbUZQd0hDajd5S0Iz?=
 =?utf-8?B?NXlPY1I1a3JnVCtFUHRpU2M3Z2kvam42QXFEejBtUmRtSWxYcXpJZEJnWlEy?=
 =?utf-8?B?SVIwVTBCNm1zZ0wyMHVXeEhZanh1MDNXbFg3bHp5UXkydGNJNU1LMHFxbzkw?=
 =?utf-8?B?eWFNUDVVUHMrWHVvbHQvdmZzVUg1RWVURFAzUkVVMVhCTmdVck92N25ZY2dp?=
 =?utf-8?B?ZmlOUWxDeFJqQWhwT2ZrUmF2MzRERUY3SytNbGlUN3djMFJMbFNnTXF0UWhE?=
 =?utf-8?B?YWxoWHhNdVI1SzlRU2hCWklNeHcrS1d1OWN1Y0txUGV2SEtjVXMrdmpFUkVU?=
 =?utf-8?B?MU1LZE94WVoxc2xTRzdNblNPa29aampZQStncnZYM0JTcXkyanVzdlBkK2o1?=
 =?utf-8?B?cDF2TWRIcXEyWmxGUXlsM29XbGVKcisrZXB5Szk0N1NRdkI0K2VhNWVtRkVF?=
 =?utf-8?B?cEVkdHg0WmFkS2FFb2pwQkxRWTd3cnpiWmFDdmw4bm4rY3VUbW9lVUFCRXdS?=
 =?utf-8?B?ZjgxVnZDcGlkUjdvMU5YMndLUkxtNldseVh2N2ExNzJGN29nVFpOUUEwa1Yx?=
 =?utf-8?B?TjZKZTVCbGhqSFc5Vk82R29ZTHZ1YnRJYy82UDlac1U1VnVlSkhyUGRYOUpY?=
 =?utf-8?B?eG1NS0oydHc2bjcvTlNabndodVFRTFhyelo1eWhvWVREbXNHTEpNZEF4aWFH?=
 =?utf-8?B?eHc3UXVBRURTZFc5dXZuTWltV3cwT0lETEpVTW5vTWRyZDVIWU1FQT09?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b21b07f-45e4-4a59-7091-08da1de0ff04
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 06:35:41.8000
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RkB7V2kZiy1fMV8ODwU9rssbVnAXIalaG7qZ4g4nOgQBGm8mgPVBwAffjquBeUSvRD5el5Lh0/zdVYk6U34lHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5782
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2022-04-14 at 11:07 +0530, Vinod Koul wrote:
> On 13-04-22, 20:39, Liu Ying wrote:
> > On Wed, 2022-04-13 at 16:19 +0530, Vinod Koul wrote:
> > > On 13-04-22, 18:04, Liu Ying wrote:
> > > > Hi Vinod,
> > > > 
> > > > On Wed, 2022-04-13 at 11:41 +0530, Vinod Koul wrote:
> > > > > On 02-04-22, 13:24, Liu Ying wrote:
> > > > > > This patch allows LVDS PHYs to be configured through
> > > > > > the generic functions and through a custom structure
> > > > > > added to the generic union.
> > > > > > 
> > > > > > The parameters added here are based on common LVDS PHY
> > > > > > implementation practices.  The set of parameters
> > > > > > should cover all potential users.
> > > > > > 
> > > > > > Cc: Kishon Vijay Abraham I <kishon@ti.com>
> > > > > > Cc: Vinod Koul <vkoul@kernel.org>
> > > > > > Cc: NXP Linux Team <linux-imx@nxp.com>
> > > > > > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > > > > > ---
> > 
> > [...]
> > 
> > > > > > + */
> > > > > > +
> > > > > > +#ifndef __PHY_LVDS_H_
> > > > > > +#define __PHY_LVDS_H_
> > > > > > +
> > > > > > +/**
> > > > > > + * struct phy_configure_opts_lvds - LVDS configuration set
> > > > > > + * @bits_per_lane_and_dclk_cycle:	Number of bits per data
> > > > > > lane
> > > > > > and
> > > > > > + *					differential clock
> > > > > > cycle.
> > > > > 
> > > > > What does it mean by bits per data lane and differential
> > > > > clock
> > > > > cycle?
> > > > 
> > > > Please check
> > > > Documentation/devicetree/bindings/display/panel/lvds.yaml.
> > > > lvds.yaml metions slot.  'bits_per_lane_and_dclk_cycle' means
> > > > the
> > > > number of slots.  But, I don't find the word 'slot' in my lvds
> > > > relevant
> > > > specs which mentioned in lvds.yaml, so 'slots' is probably not
> > > > a
> > > > generic name(lvds.yaml is for display panel).  So, I use
> > > > 'bits_per_lane_and_dclk_cycle' as the name tells what it means.
> > > 
> > > variable name is fine, explanation for bit per lane and
> > > differential
> > > clock cycle didnt help, maybe add better explanation of what this
> > > variable means
> > 
> > I may add an example diagram as below...
> 
> Not really a diagram, you can add if you like.. But something which
> explains in a sentence or few about the variable.

Ok, no diagram.

> 
> bits per lane per differential clock cycle ?

Ok, will use this explaination.

Regards,
Liu Ying