Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dcd403b025eb28186c3f05d682c383cb06e5b8ee.camel@gmail.com>
Subject: Re: [PATCH 1/1] scsi: ufs: remove redundant HPB unmap
From:   Bean Huo <huobean@gmail.com>
To:     Po-Wen Kao <powen.kao@mediatek.com>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Matthias Brugger <matthias.bgg@gmail.com>
Cc:     wsd_upstream@mediatek.com, peter.wang@mediatek.com,
        stanley.chu@mediatek.com, alice.chao@mediatek.com,
        chun-hung.wu@mediatek.com, cc.chou@mediatek.com,
        chaotian.jing@mediatek.com, jiajie.hao@mediatek.com,
        yohan.joung@sk.com, jason.li@sk.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Date:   Wed, 13 Apr 2022 23:29:53 +0200
In-Reply-To: <20220412073131.10644-1-powen.kao@mediatek.com>
References: <20220412073131.10644-1-powen.kao@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.0-1 
MIME-Version: 1.0
Precedence: bulk

Hi, Po wen and Peter


I must give this patch Ack, because:

1. =E2=80=9CfHPBReset Flag=E2=80=9D can be sent in both host control mode a=
nd device
control mode. =E2=80=9Cbuffer id=3D3 HpbWriteBuffer=E2=80=9D can only be se=
nt in device
control mode.

2. =E2=80=9CfHPBReset Flag=E2=80=9D inactivate all the regions for the whol=
e device.
=E2=80=9Cbuffer id=3D3 HpbWriteBuffer=E2=80=9D can only inactivate all the =
regions for
this LUN. The LUN is written in the UPIU header.

In the ufshpb_init, we have set fHPBReset Flag. here doesn't need to
issue =E2=80=9Cbuffer id=3D3 HpbWriteBuffer=E2=80=9D in the case of device =
mode.

Regarding the reset flow issue we are talking about, I will submit a
fix.


Acked-by: Bean Huo <beanhuo@micron.com>


Bean