Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Apr 2022 13:28:40 -0500
From:   Rob Herring <robh@kernel.org>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Jarrett Schultz <jaschultzms@gmail.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Mark Gross <markgross@kernel.org>,
        Maximilian Luz <luzmaximilian@gmail.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        Felipe Balbi <balbi@kernel.org>,
        Jarrett Schultz <jaschultz@microsoft.com>
Subject: Re: [PATCH v5 0/4] platform: surface: Introduce Surface XBL Driver
Message-ID: <YlcWWPqGzc4Zk9R+@robh.at.kernel.org>
References: <20220405210750.619511-1-jaschultzMS@gmail.com>
 <d648629e-2339-449f-f63c-41af85ba35b5@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d648629e-2339-449f-f63c-41af85ba35b5@redhat.com>
Precedence: bulk

On Mon, Apr 11, 2022 at 02:13:42PM +0200, Hans de Goede wrote:
> Hi Jarrett,
> 
> On 1/1/70 01:00, Jarrett Schultz wrote:
> > After v4, there were some suggestions to change the driver again to use
> > nvmem that would include some other changes to the sm8150 dtsi. While
> > the suggestions make sense, this driver was supposed to remain simple
> > for the introduction in order to get it into the tree and I think that
> > it would be best to implement those and any other suggestions in a future
> > patch. Hopefully this patch is now in a state where it can be accepted.
> > Thanks to all who have helped and been patient along the way, this was
> > my first patch :)
> I appreciate your efforts to get this upstream, but this is not
> how upstream development typically works. We usually iterate a patch
> until all stakeholders are happy and then merge it.
> 
> So unless Rob changes its mind and gives his Reviewed-by for the
> devicetree bits from this v5, then this cannot be merged as is.

This is dependent on the QCom folks. We can't really define the child 
without first defining the parent binding.

Rob