Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <42a52a6018e8dadb4c3eebefaae4dab31c0d5721.camel@kernel.org>
Subject: Re: [PATCH V4 00/31] x86/sgx and selftests/sgx: Support SGX2
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Reinette Chatre <reinette.chatre@intel.com>,
        dave.hansen@linux.intel.com, tglx@linutronix.de, bp@alien8.de,
        luto@kernel.org, mingo@redhat.com, linux-sgx@vger.kernel.org,
        x86@kernel.org, shuah@kernel.org, linux-kselftest@vger.kernel.org
Cc:     seanjc@google.com, kai.huang@intel.com, cathy.zhang@intel.com,
        cedric.xing@intel.com, haitao.huang@intel.com,
        mark.shanahan@intel.com, vijay.dhanraj@intel.com, hpa@zytor.com,
        linux-kernel@vger.kernel.org
Date:   Thu, 14 Apr 2022 19:55:42 +0300
In-Reply-To: <9fbf26c8-5808-20c5-8653-d4f36bf398a4@intel.com>
References: <cover.1649878359.git.reinette.chatre@intel.com>
         <2f4338f37943c2b067db16ae65c9af665d3b51d9.camel@kernel.org>
         <9fbf26c8-5808-20c5-8653-d4f36bf398a4@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.0 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-04-14 at 09:34 -0700, Reinette Chatre wrote:
> Hi Jarkko,
>=20
> On 4/14/2022 4:25 AM, Jarkko Sakkinen wrote:
> > On Wed, 2022-04-13 at 14:10 -0700, Reinette Chatre wrote:
> > IMHO, we can pull this after +1 version. I think I had only one nit
> > (one character to a struct name it was), and I've been testing this
> > series *extensively* with real-world code (wasm run-time that we are
> > developing), so I'm confident that=C2=A0 it is *good enough*.
>=20
> Thank you very much. I am aware of other teams successfully building
> on and testing this work. I do hope that they could also provide an
> ack to help increase the confidence in this work.
>=20
> >=20
> > Reinette, for the EMODT patch, as long as you fix the struct name
> > you can add my reviewed-by and also tested-by to that patch before
> > you send it! It's so narrow change.
>=20
> Thank you. I will make the struct name change and also plan to
> make the same change to the function names in that patch to ensure that
> everything is consistent in that regard.=20

I think getting ack from anyone working Graphene-SGX would bring
a great coverage of different use cases. It's different same of
Enarx in the sense that both can run arbitrary applicatons written
e.g. with C++ although approaches are on opposite sides.

> Reinette

BR; Jarkko