Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Jianglei Nie <niejianglei2021@163.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH] ice: Fix memory leak in
 ice_get_orom_civd_data()
Thread-Topic: [Intel-wired-lan] [PATCH] ice: Fix memory leak in
 ice_get_orom_civd_data()
Thread-Index: AQHYRdCcBpO6yZ8+Y0ehAJFIE980MqzvCaig
Date:   Thu, 14 Apr 2022 06:41:52 +0000
Message-ID: <BYAPR11MB3367D0896E6DD74BE81196FCFCEF9@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20220401080051.16846-1-niejianglei2021@163.com>
In-Reply-To: <20220401080051.16846-1-niejianglei2021@163.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ixopFbUITuzZTn+ZqKOorszaa+t88WBNPPN7wkqlkviEb1bDhG3S7xlS9V4C?=
 =?us-ascii?Q?+Ms31gSp6HY52OeZV+sb1Wjuy/ir3ey6w/kkSBuTVqQOq4cnR8TcBKCBEkxT?=
 =?us-ascii?Q?2IbJ7CB8PVPyIU7cjKtQUxKE3cMVXCUTl52Ca7fRWIzK1PqWMvt7boF7S7SW?=
 =?us-ascii?Q?Zj8gyZ/fke92Gl16N9ilJIz00W2gz9fA1MJ75NVdbr09vxgpYDey68ipYwJ+?=
 =?us-ascii?Q?X8rRgwGqgXz8Q2VxZeoVQe94ARDXgrTdboEJRypj9AxAQkK3/M6AuYOq8YM7?=
 =?us-ascii?Q?omxj62mz3wk3Y2ZdUachsNoIczzkCyiP67MNF1g5I9Wu9e48/LxmPl1B8oWr?=
 =?us-ascii?Q?fDYLjltDQH2upPBrt6gKRzuTgmQn3rTUAXBpWfUN+5h8G0OJsPnP5VNgeRSM?=
 =?us-ascii?Q?WTTaDclo0kWBCmdPIboG1OPsMZ2tEJ7KGZKtGuUn3H7kLbZudI/VSuLXsEZT?=
 =?us-ascii?Q?jdXneFPpeLewmPA9waHOyOL8pkXpozfNrAIn8axYR/EPWPGHX6w1LenBJXeX?=
 =?us-ascii?Q?l5srcR8IW7L8h5/9h6FCgNygG8L4xXakL2nOz3V68hnTJY+YcRhzt3woQrV1?=
 =?us-ascii?Q?GIGY8LuU5RIVuGYbuA02IjuXxuUmsMar7sO+nKshpUXYk1cTurN8mXbxrAKk?=
 =?us-ascii?Q?lY8fGYaEV30TNSU/KqG3V5uhR2iG2RjT0vxO5TIkTlVqKm/B+KhC5uJ5/07U?=
 =?us-ascii?Q?p2i3tcVvNrxLPCwnX/mBh8SlCGjFkoyewWUWC6y+zk9GtRmT3mq0rNT6v2oG?=
 =?us-ascii?Q?T8IZGbxvmhvSHlYsBYRYp7aSrSO04u4+vmiCsNckc0qZBnGYqnZEjaAam3WZ?=
 =?us-ascii?Q?At3fBBMwTg0XSx3pP8cuDwiRaxgBUOFZGYZZm9yK0G1ML8gxytIpShLidCjI?=
 =?us-ascii?Q?cZ+nPDs+8N6UMQWRvrMeY7MuG6PWznxhn9VsrTkU9v1tR/opZC8mo2jibZm9?=
 =?us-ascii?Q?1mvYm4tjCOApVS6vQo+Cn43ERzcD8qxROv1dtQb1HZK9vSkTjk2TO9/XHGzo?=
 =?us-ascii?Q?PMgpXI29NZAPqTT87Ty93BT0e2j34oVHww/tSCNp+otS7rMBU0h1eDHtexay?=
 =?us-ascii?Q?uzI5GnqmmCbCydcGJzqdYPTUWRca1SYyv3nuiEANm2bCkMWRSpnTNUKJJppj?=
 =?us-ascii?Q?s96/iDQAP9r5bvtuK1NCB5r9OVABxiBEsYYa3rRcn0wJELjUsg11spYFbn7/?=
 =?us-ascii?Q?8DZYazgrgVTu8H4983+YErP4DZ8GF6KELO+fgveBdFPNlCrgYTcrEUF4paRZ?=
 =?us-ascii?Q?v3qqt9lTEOKl/zOOk166gsXXlWMx4TIBRS4KxxVsJsOTUkgAJ9bFGr26pTsX?=
 =?us-ascii?Q?4luaIrc2/JtkfGSu4CvmTGbAqub0VRN0JXrV1BIUFUS1kpyNLvWrNxn4cbsz?=
 =?us-ascii?Q?XBFjWw4GcKV6f2O9q0ChNkISJLuj2fyG5BJzd8+cocvXIGrOAFF7O2DpKOVg?=
 =?us-ascii?Q?X4BVgeq2WaKNlQOPmV1KdTmKprz/X/CcHYFwe4K3ZRbF6uxQsFPjVbFsHEIY?=
 =?us-ascii?Q?ykaKR2FGA6b8JIVliqN1pU4qW+0zhwdwblUMgQyQUJSbncTZDItTyNhKimE+?=
 =?us-ascii?Q?7KwEwpxENkq1EN6MxpI3dkT2X30Bsgqc2I8STVlfNG54uRzpssVJb7lRy879?=
 =?us-ascii?Q?obTfMlz7PC3f6v5vQMmLv9ulvDJGqQPDZjlUFRo6MYAi/dDb985qNYlRQTCq?=
 =?us-ascii?Q?myv5VY8kUVHx3lii6FHsR04qiDGK05F3TJmEoXMqHQZruvzfquCMtShY1AqB?=
 =?us-ascii?Q?n9brZI6u9w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e932d43-25cb-41b3-3b87-08da1de1dc82
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2022 06:41:52.9466
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: g5EF7Z5Xtzsd/LQv2/Ngn9gOfUmrEIJIM0blTI0gaoqpDIOPEcd27vaIN6H2/UamisDxnT+tCO4jGNWF8/lklw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4816
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Jianglei Nie
> Sent: Friday, April 1, 2022 1:31 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; davem@davemloft.net; kuba@kernel.org
> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-
> kernel@vger.kernel.org; Jianglei Nie <niejianglei2021@163.com>
> Subject: [Intel-wired-lan] [PATCH] ice: Fix memory leak in
> ice_get_orom_civd_data()
>=20
> Line 637 allocates a memory chunk for orom_data by vzmalloc(). But when
> ice_read_flash_module() fails, the allocated memory is not freed, which w=
ill
> lead to a memory leak.
>=20
> We can fix it by freeing the orom_data when ce_read_flash_module() fails.
>=20
> Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_nvm.c | 1 +
>  1 file changed, 1 insertion(+)
>=20

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Int=
el)